Re: race condition bugs

2004-08-09 Thread Tony Finch
On Mon, 9 Aug 2004, Wayne Davison wrote: > > I went ahead and checked the change into CVS. Ace, thanks. I wish all bugs were this easy to resolve :-) Tony. -- f.a.n.finch <[EMAIL PROTECTED]> http://dotat.at/ BERWICK ON TWEED TO WHITBY: WEST OR SOUTHWEST 2 OR 3 INCREASING 3 OR 4. FAIR. GOOD. SL

Re: race condition bugs

2004-08-09 Thread Wayne Davison
On Mon, Aug 09, 2004 at 03:27:56PM -0400, Paul Green wrote: > Can we make up a test case that the build farm can execute? Sure. I added something to the rsync test suite. > I know of no issues from the POSIX standard that would prevent > applying this mod. Yeah. I'm probably just being overly

RE: race condition bugs

2004-08-09 Thread Paul Green
Wayne Davison wrote: > On Mon, Aug 09, 2004 at 12:12:16PM +0100, Tony Finch wrote: > > This is because of race conditions in finish_transfer() which mean > > that it does not update files atomically. > > There is a diff in the "patches" dir named early-chmod.diff > that changes > this behavior.

Re: race condition bugs

2004-08-09 Thread Wayne Davison
On Mon, Aug 09, 2004 at 12:12:16PM +0100, Tony Finch wrote: > This is because of race conditions in finish_transfer() which mean > that it does not update files atomically. There is a diff in the "patches" dir named early-chmod.diff that changes this behavior. It sets the permissions prior to the

race condition bugs

2004-08-09 Thread Tony Finch
We're using rsync to update the tables on our email relays, and very occasionally we get an error in the logs saying that a table has the wrong permissions. This is because of race conditions in finish_transfer() which mean that it does not update files atomically. This makes rsync not entirely saf