Re: [PATCH] Optimized assembler version of md5_process() for x86-64

2020-05-23 Thread Sebastian Andrzej Siewior via rsync
On 2020-05-23 10:21:31 [-0700], Wayne Davison wrote: > > Adding optional support for openssl's crypto library is also a good idea. I posted [0] openssl support with SHA1 support and asked whether openssl is possible. At that time added md5 and I think md4. I received no feedback bach then but if

Re: [PATCH] Optimized assembler version of md5_process() for x86-64

2020-05-23 Thread Sebastian Andrzej Siewior via rsync
On 2020-05-22 22:54:18 [-0700], Wayne Davison via rsync wrote: > Thanks for the optimizing patches, Jorrit! I've merged your latest changes > into the git master branch. Wouldn't it be better to add support for a crypto library (like openssl) which would provide optimized algorithms for more than

Re: [PATCH] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-18 Thread Sebastian Andrzej Siewior via rsync
On 2020-05-18 21:55:13 [+0200], Jorrit Jongma wrote: > What do you base this on? So my memory was wrong. SSE2 is supported by all x86-64bit CPUs. Sorry for that. > would imply that SSSE3 is enabled out of the box on builds on machines > that support it, this is not the case (it certainly isn't on

Re: [PATCH] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-18 Thread Sebastian Andrzej Siewior via rsync
On 2020-05-18 17:55:58 [+0200], Jorrit Jongma via rsync wrote: > I don't disagree that MD5 could (or even should) be replaced so it is > no longer the bottleneck in several real-world cases (including mine). > > However this patch is not for MD5 performance, rather for the rolling > checksum rsync

Re: [PATCH] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-18 Thread Sebastian Andrzej Siewior via rsync
On 2020-05-18 17:06:51 [+0200], Jorrit Jongma via rsync wrote: > diff --git a/checksum.c b/checksum.c > index cd234038..4e696f3d 100644 > --- a/checksum.c > +++ b/checksum.c > @@ -99,6 +99,7 @@ int canonical_checksum(int csum_type) > return csum_type >= CSUM_MD4 ? 1 : 0; > } > > +#ifndef __SSE2

Re: [RFC PATCH] Add SHA1 support

2020-03-17 Thread Sebastian Andrzej Siewior via rsync
On 2020-03-17 00:03:03 [+0100], Dimitrios Apostolou via rsync wrote: > On Thursday, February 20, 2020 10:34:53 PM CET, Sebastian Andrzej Siewior > via rsync wrote: > > > > I'm still not sure if rsync requires a cryptographic hash _or_ if a > > strong hash like xxHash

Re: [RFC PATCH] Add SHA1 support

2020-02-20 Thread Sebastian Andrzej Siewior via rsync
On 2020-02-20 20:06:39 [+0100], Markus Ueberall wrote: > On 2020-02-09 23:19, Sebastian Andrzej Siewior wrote: > > [...] > > My primar motivation to use SHA1 for checksumming (by default) instead > > of MD5 is not the additional security bits but performance. On a decent > > x86 box the SHA1 perfor

[RFC PATCH] Add SHA1 support

2020-02-09 Thread Sebastian Andrzej Siewior via rsync
From: Sebastian Andrzej Siewior This is a huge all-in-one patch and deserves a little cleanup and splitting. However, I wanted to get it out here for some feedback. My primar motivation to use SHA1 for checksumming (by default) instead of MD5 is not the additional security bits but performance.

[PATCH] Add support for zstd compression

2020-02-06 Thread Sebastian Andrzej Siewior via rsync
From: Sebastian Andrzej Siewior zstd compression was announced as "good compression with high throughput" so I gave it a try. With zlib, on high speed links the CPU is usually the bottle neck. With zstd I'm able to fill a 200Mbit link :) zstd detection happens automatically via pkg-config. No zs