[Bug 7120] Variable bandwidth limit .. bwlimit

2017-03-01 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7120 --- Comment #7 from roland --- please mind the note from this posting when using pv: http://superuser.com/questions/778066/using-pv1-to-limit-rsync-speed --snipp-- It seems that pv is waiting for data from rsync, and rsync is waiting for data too

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-20 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 Wayne Davison changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-19 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 Wayne Davison changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #10 from Wayne Daviso

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-17 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #9 from Paul Donohue --- popt ticket requesting a solution in popt itself: http://rpm5.org/cvs/tktview?tn=98 -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avo

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-17 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #8 from Paul Donohue --- I agree with the general philosophy that it isn't rsync's problem to secure the command line. However, I don't see any good way that sudo can secure the rsync command line unless rsync provides some mechanism f

[Bug 12583] New: [PATCH] Add new daemon option "syslog tag"

2017-02-15 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12583 Bug ID: 12583 Summary: [PATCH] Add new daemon option "syslog tag" Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: normal

[Bug 12527] Sender waits for timeout when fuzzy basis file found

2017-02-14 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12527 --- Comment #3 from Ben RUBSON --- So sounds like that when the generator sends too much info (too many checksums) to the sender, the sender does not receive / see (important) messages anymore. Perhaps we could solve this by making the generator w

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #7 from Kevin Korb --- I have been thinking about this a bit and I believe it is a sudo problem and not an rsync problem. It is not rsync's job to secure the command line. Plus rsync is far from the only program that uses popt to pars

[Bug 12527] Sender waits for timeout when fuzzy basis file found

2017-02-12 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12527 --- Comment #2 from Ben RUBSON --- I'm troubleshooting and found that this happens when generate_and_send_sums() writes too many bufs. If I replace : for (i = 0; i < sum.count; i++) { by : for (i = 0; i < 4500; i++) { (sum.count > 15000 in this te

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-12 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #6 from Paul Donohue --- This all makes sense, I appreciate the suggestions, and I may actually implement some of this. However, the existence of this rrsync solution doesn't change the fact that there exists another simple and obvious

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #5 from Karl O. Pinc --- On Sun, 12 Feb 2017 02:18:35 + samba-b...@samba.org wrote: > https://bugzilla.samba.org/show_bug.cgi?id=12576 > > --- Comment #4 from Paul Donohue --- > That's an interesting solution, but it doesn't real

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #4 from Paul Donohue --- That's an interesting solution, but it doesn't really work well for my use case. I would like my users to be able to maintain their own SSH keys (this solution would require me to manage users' SSH keys in /roo

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #3 from Kevin Korb --- There is no reason to involve rsyncd (or even sudo). See the rrsync script in the support directory. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for mos

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #2 from Paul Donohue --- Created attachment 12916 --> https://bugzilla.samba.org/attachment.cgi?id=12916&action=edit Add a new --no-popt-aliases option to explicitly disable popt aliases -- You are receiving this mail because: You a

[Bug 12576] New: popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 Bug ID: 12576 Summary: popt aliases allow users to bypass sudo argument restrictions Product: rsync Version: 3.1.3 Hardware: All OS: All Status: N

[Bug 12576] popt aliases allow users to bypass sudo argument restrictions

2017-02-11 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12576 --- Comment #1 from Paul Donohue --- Created attachment 12915 --> https://bugzilla.samba.org/attachment.cgi?id=12915&action=edit Do not enable popt aliases if --server or --daemon is specified -- You are receiving this mail because: You are the

[Bug 12570] Problems with --checksum --existing

2017-02-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12570 --- Comment #1 from Kevin Korb --- Unfortunately rync's --checksum is just that dumb. It checksums *EVERYTHING* on the source and the target before it does anything else. Since --checksum is almost always the wrong thing to do nobody seems to be

[Bug 12570] New: Problems with --checksum --existing

2017-02-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12570 Bug ID: 12570 Summary: Problems with --checksum --existing Product: rsync Version: 3.1.1 Hardware: All OS: All Status: NEW Severity: normal Priori

[Bug 12569] New: Missing directory errors not ignored

2017-02-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12569 Bug ID: 12569 Summary: Missing directory errors not ignored Product: rsync Version: 3.1.2 Hardware: All OS: Linux Status: NEW Severity: normal Pri

[Bug 12568] New: Integer overflow still affects xattrs.c

2017-02-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12568 Bug ID: 12568 Summary: Integer overflow still affects xattrs.c Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: critical

[Bug 12544] New: Confusing return codes on unauthorized connections

2017-01-31 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12544 Bug ID: 12544 Summary: Confusing return codes on unauthorized connections Product: rsync Version: 3.1.3 Hardware: All OS: Linux Status: NEW Severity: normal

[Bug 2294] Detect renamed files and handle by renaming instead of delete/re-send

2017-01-22 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=2294 --- Comment #27 from Wolfgang Hamann --- Hi, I recently ran into the problem that a large file set got renamed and then re-sent. I tried to fix after the fact, so I went the obvious way of comparing sizes and modtimes on the destination and calcula

[Bug 12530] New: [REQ] Improve fuzzy using files being uploaded

2017-01-19 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12530 Bug ID: 12530 Summary: [REQ] Improve fuzzy using files being uploaded Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: normal

[Bug 12527] Sender waits for timeout when fuzzy basis file found

2017-01-18 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12527 --- Comment #1 from Ben RUBSON --- Same issue with rsync-HEAD-20161010-1854GMT. My quick previous test uses these local files : -rw--- 1 root root 1177136858 Jan 10 2017 bf.iso -rw--- 1 root root68558591 Jan 10 2017 sf2.dmg And

[Bug 12527] New: Sender waits for timeout when fuzzy basis file found

2017-01-18 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12527 Bug ID: 12527 Summary: Sender waits for timeout when fuzzy basis file found Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: critic

[Bug 12525] [PATCH] Avoid uploading whole file when transfer fails

2017-01-18 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12525 Ben RUBSON changed: What|Removed |Added Attachment #12839|0 |1 is obsolete|

[Bug 12522] [PATCH] Send last error messages to sender

2017-01-18 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12522 Ben RUBSON changed: What|Removed |Added Attachment #12838|0 |1 is obsolete|

[Bug 12525] New: [PATCH] Avoid uploading whole file when transfer fails

2017-01-17 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12525 Bug ID: 12525 Summary: [PATCH] Avoid uploading whole file when transfer fails Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: norm

[Bug 12522] [PATCH] Send last error messages to sender

2017-01-17 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12522 Ben RUBSON changed: What|Removed |Added Attachment #12832|0 |1 is obsolete|

[Bug 12522] New: [PATCH] Send last error messages to sender

2017-01-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12522 Bug ID: 12522 Summary: [PATCH] Send last error messages to sender Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: normal

[Bug 12519] New: Failed to open lock file, add reason

2017-01-15 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12519 Bug ID: 12519 Summary: Failed to open lock file, add reason Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: normal Prior

[Bug 12508] New: fileflags & forcechange don't work for hardlinks

2017-01-10 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12508 Bug ID: 12508 Summary: fileflags & forcechange don't work for hardlinks Product: rsync Version: 3.1.2 Hardware: All OS: FreeBSD Status: NEW Severity: normal

[Bug 12489] --fuzzy --fuzzy does not work with daemon

2017-01-05 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12489 Ben RUBSON changed: What|Removed |Added Severity|critical|normal --- Comment #1 from Ben RUBSON --- As

[Bug 12498] New: --fuzzy --fuzzy hugely impacts performance even if its' not needed

2017-01-05 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12498 Bug ID: 12498 Summary: --fuzzy --fuzzy hugely impacts performance even if its' not needed Product: rsync Version: 3.1.2 Hardware: All OS: All Stat

[Bug 10312] Rsync times out during deletion on big folders

2017-01-02 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10312 --- Comment #2 from Ben RUBSON --- Regarding --link-dest, I made further testing with rsync daemon 3.1.2. I added a usleep(5000) at the beginning of try_dests_reg() in generator.c, so that hard-linking all the files takes more than 2 minutes instea

[Bug 2294] Detect renamed files and handle by renaming instead of delete/re-send

2016-12-30 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=2294 --- Comment #26 from Ben RUBSON --- ### What's the diff between --fuzzy and --detect-renamed ? If I understand correctly, --fuzzy looks only in destination folder, for either a file that has an identical size and modified-time, or a similarly-named

[Bug 12489] New: --fuzzy --fuzzy does not work with daemon

2016-12-30 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12489 Bug ID: 12489 Summary: --fuzzy --fuzzy does not work with daemon Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: critical

[Bug 10338] Start deletion from the top of the hierarchy

2016-12-29 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10338 Ben RUBSON changed: What|Removed |Added Resolution|WORKSFORME |WONTFIX -- You are receiving this mail becau

[Bug 10338] Start deletion from the top of the hierarchy

2016-12-29 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10338 Ben RUBSON changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Bug 5324] Reduce the performance penalty of --xattrs on Mac OS X

2016-12-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=5324 --- Comment #11 from Björn Jacke --- no, because the problem was fixed with metzes patch. if you see a need for the ctime compare, then please open a new bug report for it. this bug here is closed and fixed. -- You are receiving this mail because:

[Bug 5324] Reduce the performance penalty of --xattrs on Mac OS X

2016-12-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=5324 --- Comment #10 from Oren Kishon --- > how about adding an option like "--use-ctime-before-xattr-compares", which > only > reads and compares EAs for files where the ctime on the source side is > newer > than the ctime on the target side. EA modif

[Bug 12472] invalid rsync-command syntax or options with —stats

2016-12-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12472 --- Comment #3 from rutleco...@gmail.com --- (In reply to Paul Slootman from comment #1) Also, no error when the server side is 3.1.2, only when the server side is 3.0.9 -- You are receiving this mail because: You are the QA Contact for the bug.

[Bug 12472] invalid rsync-command syntax or options with —stats

2016-12-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12472 --- Comment #2 from rutleco...@gmail.com --- (In reply to Paul Slootman from comment #1) For the bug reporter, not in my rsync command. (My rsync command is the same script that I used w/o error with 3.0.9) I think the error has something to do wit

[Bug 12472] invalid rsync-command syntax or options with —stats

2016-12-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12472 --- Comment #1 from Paul Slootman --- Did you cut&paste the --stats from some webpage? As you can see from the emailed version of your report: Summary: invalid rsync-command syntax or options with â\200\224stats There's your problem! You're not

[Bug 12472] New: invalid rsync-command syntax or options with —stats

2016-12-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12472 Bug ID: 12472 Summary: invalid rsync-command syntax or options with —stats Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: enhan

[Bug 3444] Deal with case-insensitive file-systems better (perhaps by adding an option)

2016-12-02 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=3444 Dmitry changed: What|Removed |Added CC||dm...@mail.ru --- Comment #12 from Dmitry --- I b

[Bug 12454] New: rsync server is not going down.

2016-11-29 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12454 Bug ID: 12454 Summary: rsync server is not going down. Product: rsync Version: 3.1.3 Hardware: x64 OS: Linux Status: NEW Severity: major Priority:

[Bug 12440] make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 Wayne Davison changed: What|Removed |Added Resolution|--- |WONTFIX Status|REOPENED

[Bug 12440] make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 Harri changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX

[Bug 12440] make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 --- Comment #3 from Harri --- I have several objections: * --numeric-ids is in wide use, while there is no --crtimes in rsync yet * --crtimes is useful only on MacOS, --numeric-ids on all Unix-like platforms. The probality for someone using --nu

[Bug 12440] make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 Wayne Davison changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 12440] make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 --- Comment #1 from Harri --- Created attachment 12689 --> https://bugzilla.samba.org/attachment.cgi?id=12689&action=edit proposed patch -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for m

[Bug 12440] New: make "rsync -N" == "rsync --numeric-ids" ?

2016-11-23 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12440 Bug ID: 12440 Summary: make "rsync -N" == "rsync --numeric-ids" ? Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: enhancement

[Bug 12430] New: rsync daemon chooses wrong place for pathes containing space and the module name

2016-11-16 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12430 Bug ID: 12430 Summary: rsync daemon chooses wrong place for pathes containing space and the module name Product: rsync Version: 3.1.1 Hardware: All OS: Linux

[Bug 7249] Add an option to use O_NOATIME

2016-11-15 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7249 --- Comment #7 from cyril...@gmail.com --- +1 I'm currently using a locally patched version, because I'm using rsync to mirror my whole data daily, plus using a deduplicating backup tool weekly that stores atime (so if rsync sets atime, the metadata

[Bug 12417] Sametimes currupted file after disconnect

2016-11-15 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12417 --- Comment #1 from Wayne Davison --- Rsync 3.1.2 doesn't leave its tmp files around unless it is killed by an uncaught signal, such as a sigbus. You might want to enable core files and/or monitor the rsync process to see how it is dying. As for t

[Bug 12417] New: Sametimes currupted file after disconnect

2016-11-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12417 Bug ID: 12417 Summary: Sametimes currupted file after disconnect Product: rsync Version: 3.1.2 Hardware: x64 OS: All Status: NEW Severity: major P

[Bug 12367] temporary lines in --progress output are not cleared

2016-10-29 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12367 --- Comment #3 from Wayne Davison --- Actually, I diagnosed this further, and noticed that the file counts shouldn't be output at all -- the check for progress output was being fooled by a temporary setting of the xfer_dirs var when -R is used with

[Bug 12367] temporary lines in --progress output are not cleared

2016-10-29 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12367 Wayne Davison changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 12386] Copy Loop

2016-10-21 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12386 Wayne Davison changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 12386] Copy Loop

2016-10-20 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12386 --- Comment #1 from Kevin Korb --- That isn't a bug you are using it wrong. drop the .* and it will do what you expect. There should almost never be a * in the source parameter. Also, don't rsync without --times unless you have a really good rea

[Bug 12386] New: Copy Loop

2016-10-20 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12386 Bug ID: 12386 Summary: Copy Loop Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component:

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-14 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 --- Comment #6 from Kevin Korb --- If you want to sync files newer than say 3 days ago that is what --files-from is for... cd /source find . -mtime -3 -print | rsync -vai --files-from=- . /target The primary purpose of --files-from is to give rsyn

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-14 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 --- Comment #5 from Alessio --- (In reply to Wayne Davison from comment #4) Well if it's by design I will not go further. But for me it's a missing "feature" because one has to prepare the list beforehand while rsync could do the job "while it's t

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 Wayne Davison changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 --- Comment #3 from Kevin Korb --- I didn't say anything specific about a remote host. You excluded .cache then you told it to copy specific files some of which are in .cache. If there was a file named .cache inside of a directory that you told i

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 --- Comment #2 from Alessio --- (In reply to Kevin Korb from comment #1) Excuse me, but i don't get it, what's the difference between excluding (matching) the pattern from a --files-from and a remote host? debugging the rsync transfer from the r

[Bug 12378] why i cannot exclude dir/files if using option "--files-from"

2016-10-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 --- Comment #1 from Kevin Korb --- It did not copy the directory you excluded it copied the files within that directory that you explicitly told it to copy and created the appropriate directories to allow that to happen. IOW, .cache is not relativ

[Bug 12378] New: why i cannot exclude dir/files if using option "--files-from"

2016-10-13 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12378 Bug ID: 12378 Summary: why i cannot exclude dir/files if using option "--files-from" Product: rsync Version: 3.1.2 Hardware: x64 OS: Linux Status:

[Bug 11588] better handling for --preallocate with --sparse

2016-10-10 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #25 from Коренберг Марк --- What about fallcate()d area beyond file size ? Will they be synchronized ? Just curious. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replie

[Bug 11588] better handling for --preallocate with --sparse

2016-10-10 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #24 from Theodore Ts'o --- So a simple workaround would be to use fallocate with KEEP_SIZE at first, then use punch whole, write the blocks, etc., and then use either truncate to set i_size, or seek to the desired size minus one and wri

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #23 from Wayne Davison --- > Continuing to think aloud. It's not really a hole, it's already reserved > space. Exactly, and it's impossible to punch holes in that allocation. I'm changing my patch to give the file a size to deal with

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #22 from Andrey Gursky --- (In reply to Andrey Gursky from comment #21) Continuing to think aloud. It's not really a hole, it's already reserved space. -- You are receiving this mail because: You are the QA Contact for the bug. --

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #21 from Andrey Gursky --- (In reply to Andrey Gursky from comment #20) Sorry, it is indeed preallocated. Other still holds: hole-punch doesn't fail because the file already consists of only hole. Such file I would call a preallocated

[Bug 11588] better handling for --preallocate with --sparse

2016-10-09 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #20 from Andrey Gursky --- (In reply to Wayne Davison from comment #17) From what I see, it doesn't fail, since the file is not preallocated at all with FALLOC_FL_KEEP_SIZE, but just a fully sparse file is created (consisting of only o

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #19 from Wayne Davison --- Also, to be more like rsync would do you can follow the hole-punch with a seek and a write so that the file ends up with a non-zero size. Apparently if I change the order to do the seek & the write first and T

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #18 from Wayne Davison --- FYI, I tested on Linux 4.2.0 and 3.10.0 (I don't have a newer kernel running here to try). -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most repli

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #17 from Wayne Davison --- Take the test program and change the SYS_fallocate to use the FALLOC_FL_KEEP_SIZE flag (don't forget to "rm test-file") and it will fail. Rsync always pre-allocates with FALLOC_FL_KEEP_SIZE when the flag is av

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #16 from Andrey Gursky --- (In reply to Theodore Ts'o from comment #15) Theo, thanks for taking time to test it! This works for me too (Debian Testing 4.7.4-2, ext4): $ /usr/sbin/filefrag -v test-file Filesystem type is: ef53 File si

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #15 from Theodore Ts'o --- Created attachment 12557 --> https://bugzilla.samba.org/attachment.cgi?id=12557&action=edit Test program to show that fallocate followed by punch hole works just fine -- You are receiving this mail bec

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #14 from Theodore Ts'o --- >I believe "on the same file handle" is the unusual prerequisite to trigger the >>behavior described by Wayne. I was fairly sure that was a red herring, so I was trying to save myself some time, but no, it d

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #13 from Andrey Gursky --- (In reply to Theodore Ts'o from comment #11) Theo, I believe "on the same file handle" is the unusual prerequisite to trigger the behavior described by Wayne. Or such a test is already contained in e2fsprogs

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #12 from Andrey Gursky --- (In reply to Wayne Davison from comment #9) >> Hole-punch works only for full filesystem blocks > That has nothing to do with it. Wayne, OK, might be. I haven't tested it the exactly way you're doing it now,

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #11 from Theodore Ts'o --- Re: #9. I'm not able to reproduce the described behavior. If you want to follow up on what you think is a kernel bug, please send a simple repro program or script and what version of the kernel you are usin

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #10 from Wayne Davison --- > ... I can share my work. Sounds interesting! Looking forward to seeing what you've come up with. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for m

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #9 from Wayne Davison --- > Hole-punch works only for full filesystem blocks That has nothing to do with it. If you fallocate() the full file length and then (on the same file handle) try to punch out parts of the allocated file, no bl

[Bug 11588] better handling for --preallocate with --sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #8 from Andrey Gursky --- (In reply to Wayne Davison from comment #7) Wayne, since this bug made rsync unusable for me, I fixed that and implemented additional checks needed for ext4 a month or two after I reported this bug and saw no

[Bug 12305] --fallocate and --sparse work wrong

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12305 --- Comment #5 from Коренберг Марк --- Fallocated: areas of the file that has been fallocate()d, but stillnot written. Technically, on sender, even written parts that was written, but contain zeroes may be considered as fallocated areas. I mean tha

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #7 from Wayne Davison --- Created attachment 12556 --> https://bugzilla.samba.org/attachment.cgi?id=12556&action=edit Preliminary patch to support punching holes In my testing, using both a pre-allocate call on a file followed by a h

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #6 from Carson Gaspar --- For punching holes, Solaris and UnixWare support F_FREESP(64) in fcntl(). Windows supports both reporting and punching holes, but I don't know if cygwin (or any other rsync on windows platform) implements it.

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #5 from Carson Gaspar --- (In reply to Carson Gaspar from comment #4) Actually, you never want the sender to scan for zero regions if SEEK_HOLE isn't supported, as performance would then be terrible. And a given filesystem may not suppo

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #4 from Carson Gaspar --- rsync currently just has the receiver turn "long" sequences of zeroes into sparse regions when --sparse is specified. If --preallocate is also specified, what would you like rsync to do? No wire protocol chang

[Bug 12305] --fallocate and --sparse work wrong

2016-10-08 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12305 --- Comment #4 from Carson Gaspar --- Please define what you mean by 'fallocated' in (1) and (2). Please also specify how you're determining that something has been 'fallocated'. I agree that (3) is a bug, and as the only real one that I can see, a

[Bug 12367] temporary lines in --progress output are not cleared

2016-10-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12367 --- Comment #1 from Andrey Gursky --- Hi Paul, you reported something similar on the list (https://lists.samba.org/archive/rsync/2015-December/030478.html). I've instantly recalled that, because this issue also annoys me. If I redirect rsync outpu

[Bug 12367] New: temporary lines in --progress output are not cleared

2016-10-07 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12367 Bug ID: 12367 Summary: temporary lines in --progress output are not cleared Product: rsync Version: 3.1.2 Hardware: All OS: All Status: NEW Severity: minor

[Bug 12336] New: SKYPE password reset((+1 (866)*769 (8I27) @SKYPE Tech Support number

2016-10-03 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12336 Bug ID: 12336 Summary: SKYPE password reset((+1 (866)*769 (8I27) @SKYPE Tech Support number Product: rsync Version: 3.1.3 Hardware: All OS: All St

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-02 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #3 from Andrey Gursky --- (In reply to Коренберг Марк from comment #2) Марк, nevertheless it is still the same issue. You're welcome to add the details here. Please, be sure, to fix the typo: instead of --fallocate it should be --preall

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-02 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 --- Comment #2 from Коренберг Марк --- Bug 12305 has much more detailed description -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsu

[Bug 12305] --fallocate and --sparse work wrong

2016-10-01 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=12305 Wayne Davison changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 11588] missing option: preallocate for all files except for sparse

2016-10-01 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11588 Wayne Davison changed: What|Removed |Added CC||socketp...@gmail.com --- Comment #1 from W

  1   2   3   4   5   6   7   8   9   10   >