macro feature tests in rsync code

2005-02-12 Thread John E. Malmberg
The tests in rsync for features have been changed to testing the value of a macro definition instead of previously testing if the macro was defined. This testing is now inconsistent with the HAVE_SOCKETPAIR macro, where in some places it is tested to see if the macro is defined, and other plac

Re: macro feature tests in rsync code

2005-02-12 Thread Wayne Davison
On Sat, Feb 12, 2005 at 09:53:28PM -0500, John E. Malmberg wrote: > The tests in rsync for features have been changed to testing the value > of a macro definition instead of previously testing if the macro was > defined. Acutally, the various tests were sometimes inconsistent -- some were testin

Re: macro feature tests in rsync code

2005-02-13 Thread John E. Malmberg
Wayne Davison wrote: On Sat, Feb 12, 2005 at 09:53:28PM -0500, John E. Malmberg wrote: I don't see this. All the code in CVS uses "#if" to test the value of HAVE_SOCKETPAIR. I found the problem, one of the bugs in my first experimental pthreads version is that it sometimes creates a file with t