[rt-users] [PATCH] RT::Users-WhoBelongToGroups applies LimitToPrivileged filter

2013-03-13 Thread Craig Ringer
Hi all I've noticed that the WhoBelongToGroups method of user search class RT::Users unconditionally calls LimitToPrivileged, making it useless for when you want to find both privileged and unprivileged users, or when you want to find only unprivileged users where you've already called

Re: [rt-users] [PATCH] RT::Users-WhoBelongToGroups applies LimitToPrivileged filter

2013-03-13 Thread Craig Ringer
On 03/13/2013 04:40 PM, Craig Ringer wrote: Hi all I've noticed that the WhoBelongToGroups method of user search class RT::Users unconditionally calls LimitToPrivileged, making it useless for when you want to find both privileged and unprivileged users, or when you want to find only

Re: [rt-users] [PATCH] RT::Users-WhoBelongToGroups applies LimitToPrivileged filter

2013-03-13 Thread Thomas Sibley
On 03/13/2013 03:06 AM, Craig Ringer wrote: I think I could hot-insert the method into RT::Users with something like: { package RT::Users; sub WhoBelongToGroupsIncludingPrivileged { # } } in my module. It doesn't have to be visible to other modules, so it'd essentially

Re: [rt-users] [PATCH] RT::Users-WhoBelongToGroups applies LimitToPrivileged filter

2013-03-13 Thread Craig Ringer
On 03/14/2013 01:50 AM, Thomas Sibley wrote: That injects the method into RT::Users. It will override the existing method and all code will use it once your extension is loaded. It is not private, as you describe. Yes, but the name isn't referenced anywhere else so the additional method

Re: [rt-users] [PATCH] RT::Users-WhoBelongToGroups applies LimitToPrivileged filter

2013-03-13 Thread Thomas Sibley
On 03/13/2013 02:15 PM, Craig Ringer wrote: On 03/14/2013 01:50 AM, Thomas Sibley wrote: That injects the method into RT::Users. It will override the existing method and all code will use it once your extension is loaded. It is not private, as you describe. Yes, but the name isn't