Hi,
On Wed, Nov 23, 2016 at 10:46 AM, Alexandre Belloni
wrote:
>> Ok, could you please indicate which lines so I can fix them instead of
>> wasting your time?
>>
>
> checkpatch.pl --strict will find them for you
Thanks, I had the wrong tab setting.
--
You received this message because you are s
This is a cleanup and preparation of rtc-twl to reduce the usage of
twl-core exported functions.
The next patch series will further reduce the usage of exported functions
but first it requires some changes in mfd/twl-core.c
v2:
- dropped patch "rtc: rtc-twl: use irq_of_parse_and_map helper"
- fixe
The current code uses static variables which prevent
the use of multiple rtc twl instances.
We also make it clear that this driver supports only
TWL4030 and TWL6030 classes.
Signed-off-by: Nicolae Rosia
---
drivers/rtc/rtc-twl.c | 190 ++
1 file ch
Since there are no platform based users and all users
of this code are TI OMAP-based which is DT only, it makes
sense to remove unused code.
Signed-off-by: Nicolae Rosia
---
drivers/rtc/Kconfig | 1 +
drivers/rtc/rtc-twl.c | 12 +++-
2 files changed, 8 insertions(+), 5 deletions(-)
d
On 23/11/2016 at 10:39:12 +0200, Nicolae Rosia wrote :
> Hi,
> Thanks for the review.
>
> On Wed, Nov 23, 2016 at 12:31 AM, Alexandre Belloni
> wrote:
> > Hi,
> >
> > A few alignments are off but I can fix that provided you answer the
> > question below:
> >
> Ok, could you please indicate which
Hi,
On Wed, Nov 23, 2016 at 12:33 AM, Alexandre Belloni
wrote:
>> static struct platform_driver twl4030rtc_driver = {
>> .probe = twl_rtc_probe,
>
>
> You can then get rid of of_match_ptr()
>
Sure, doing it in v2.
--
You received this message because you are subscribed to "rtc-l
Hi,
Thanks for the review.
On Wed, Nov 23, 2016 at 12:31 AM, Alexandre Belloni
wrote:
> Hi,
>
> A few alignments are off but I can fix that provided you answer the
> question below:
>
Ok, could you please indicate which lines so I can fix them instead of
wasting your time?
> On 12/11/2016 at 12:
