[rtc-linux] Re: [PATCH v2 0/6] Provides bug fixes for rtc-mcp795.c

2016-12-07 Thread Alexandre Belloni
On 08/12/2016 at 00:27:36 +0100, Emil Bartczak wrote : > This patchset provides 4 bug fixes (patch 1, 2, 3, 4), one > improvement (patch 5) and whitespace, indention errors fixes > (patch 6) in the file driver/rtc/rtc-mcp795.c. > Please review the changes and consider to apply them to the > main

[rtc-linux] [PATCH v2 5/6] rtc: mcp795: Prefer using the BIT() macro.

2016-12-07 Thread Emil Bartczak
This patch doesn't change the code but replaces all bitmask values with the BIT(x) macro. Signed-off-by: Emil Bartczak --- drivers/rtc/rtc-mcp795.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c index 89b0ffa..8ed55f6 1

[rtc-linux] [PATCH v2 2/6] rtc: mcp795: fix bitmask value for leap year (LP).

2016-12-07 Thread Emil Bartczak
According the datasheet the leap year is a fifth bit in month register. Signed-off-by: Emil Bartczak --- drivers/rtc/rtc-mcp795.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c index 0389ee0..5fbdb4c 100644 --- a/drivers/

[rtc-linux] [PATCH v2 1/6] rtc: mcp795: use bcd2bin/bin2bcd.

2016-12-07 Thread Emil Bartczak
Change rtc-mcp795.c to use the bcd2bin/bin2bcd functions. This change fixes the wrong conversion of month value from binary to BCD (missing right shift operation for 10 month). Signed-off-by: Emil Bartczak --- drivers/rtc/rtc-mcp795.c | 25 + 1 file changed, 13 insertions

[rtc-linux] [PATCH v2 6/6] rtc: mcp795: Fix whitespace and indentation.

2016-12-07 Thread Emil Bartczak
Fix whitespace and indentation errors and the following checkpatch warnings: - line 15: Block comments use a trailing */ on a separate line - line 256: Line over 80 characters No code change. Signed-off-by: Emil Bartczak --- drivers/rtc/rtc-mcp795.c | 12 ++-- 1 file changed, 6 insertion

[rtc-linux] [PATCH v2 0/6] Provides bug fixes for rtc-mcp795.c

2016-12-07 Thread Emil Bartczak
This patchset provides 4 bug fixes (patch 1, 2, 3, 4), one improvement (patch 5) and whitespace, indention errors fixes (patch 6) in the file driver/rtc/rtc-mcp795.c. Please review the changes and consider to apply them to the main kernel tree. Changes from v1: - Introduced SoB to all patches.

[rtc-linux] [PATCH v2 3/6] rtc: mcp795: fix time range difference between linux and RTC chip.

2016-12-07 Thread Emil Bartczak
In linux rtc_time struct, tm_mon range is 0~11, while in RTC HW REG, month range is 1~12. This patch adjusts difference of them. Signed-off-by: Emil Bartczak --- drivers/rtc/rtc-mcp795.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rt

[rtc-linux] [PATCH v2 4/6] rtc: mcp795: fix month write resetting date to 1.

2016-12-07 Thread Emil Bartczak
According to Microchip errata some combinations of date and month values may result in the date being reset to 1, even if the date is also written with the month (for example 31-07 or 31-08). As a workaround avoid writing date and month values within the same Write command. Instead, terminate the W

[rtc-linux] Re: [PATCH v3] rtc: add support for EPSON TOYOCOM RTC-7301SF/DG

2016-12-07 Thread Alexandre Belloni
On 04/12/2016 at 23:04:39 +0900, Akinobu Mita wrote : > This adds support for EPSON TOYOCOM RTC-7301SF/DG which has parallel > interface compatible with SRAM. > > This driver supports basic clock, calendar and alarm functionality. > > Tested with Microblaze linux running on Artix7 FPGA board with

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
Hi, It seems mostly fine. On 02/12/2016 at 15:09:56 +0100, Amelie Delaunay wrote : > This patch adds support for the STM32 RTC. > > Signed-off-by: Amelie Delaunay > --- > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile| 1 + > drivers/rtc/rtc-stm32.c | 777 >

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
On 05/12/2016 at 10:43:14 +0100, Amelie DELAUNAY wrote : > >> + > >> +device_init_wakeup(&pdev->dev, true); > > > > What happens if device_init_wakeup() returns an error? > It means that RTC won't be able to wake up the board with RTC alarm. I can > add a warning for the user in this case ? > >

[rtc-linux] Re: [PATCH V1] rtc: ds1307: Add ACPI support

2016-12-07 Thread Alexandre Belloni
Hi, On 30/11/2016 at 09:57:31 +0700, Tin Huynh wrote : > This patch enables ACPI support for rtc-ds1307 driver. > > Signed-off-by: Tin Huynh > --- > drivers/rtc/rtc-ds1307.c | 51 ++--- > 1 files changed, 43 insertions(+), 8 deletions(-) > Applied afte

[rtc-linux] Re: [PATCH 1/2] rtc: imxdi: (trivial) fix a typo

2016-12-07 Thread Alexandre Belloni
On 19/11/2016 at 14:03:33 +0100, Martin Kaiser wrote : > Signed-off-by: Martin Kaiser > --- > drivers/rtc/rtc-imxdi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.c

[rtc-linux] Re: [PATCH 2/2] rtc: imxdi: use the security violation interrupt

2016-12-07 Thread Alexandre Belloni
Hi, On 19/11/2016 at 14:03:34 +0100, Martin Kaiser wrote : > The DryIce chipset has a dedicated security violation interrupt that is > triggered for security violations (if configured to do so). According to > the publicly available imx258 reference manual, irq 56 is used for this > interrupt. >

[rtc-linux] Re: [PATCH] rtc: ds1374: Merge conditional + WARN_ON()

2016-12-07 Thread Alexandre Belloni
On 29/11/2016 at 11:04:37 +, Srikant Ritolia wrote : > WARN_ON does both these things in one statement. > Using a better pattern with WARN_ON(). > > Signed-off-by: Srikant Ritolia > --- > drivers/rtc/rtc-ds1374.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks.

[rtc-linux] [abelloni:at91-dt 11/16] Error: arch/arm/boot/dts/sama5d3xmb_cmp.dtsi:179.17-18 syntax error

2016-12-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git at91-dt head: 750b08cc0f79f0077c4f8e13ca12d2906ae71ffa commit: 20b8867ba75e7f1c01fc938b27d8a9194a44e8e9 [11/16] ARM: dts: at91: add dts file for sama5d36ek CMP board config: arm-omap2plus_defconfig (attached as .config)

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Amelie DELAUNAY
On 12/05/2016 05:32 PM, Mathieu Poirier wrote: On Mon, Dec 05, 2016 at 10:43:14AM +0100, Amelie DELAUNAY wrote: Hi Mathieu, Thanks for reviewing On 12/02/2016 06:56 PM, Mathieu Poirier wrote: On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: This patch adds support for the S