On 18/03/2017 at 14:45:49 +0100, Hans de Goede wrote: > On some systems (e.g. Intel Bay Trail systems) the legacy PIC is not > used, in this case virq 8 will be a random irq, rather then hw_irq 8 > from the PIC. > > Requesting virq 8 in this case will not help us to get alarm irqs and > may cause problems for other drivers which actually do need virq 8, > for example on an Asus Transformer T100TA this leads to: > > [ 28.745155] genirq: Flags mismatch irq 8. 00000088 (mmc0) vs. 00000080 (rtc0) > <snip oops> > [ 28.753700] mmc0: Failed to request IRQ 8: -16 > [ 28.975934] sdhci-acpi: probe of 80860F14:01 failed with error -16 > > This commit fixes this by making the rtc-cmos driver continue > without using an irq rather then claiming irq 8 when no irq is > specified in the pnp-info and there are no legacy-irqs. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > drivers/rtc/rtc-cmos.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > Applied, thanks.
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.