[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-12 Thread Amelie DELAUNAY
Hi, Thanks for the review. On 12/07/2016 08:08 PM, Alexandre Belloni wrote: Hi, It seems mostly fine. On 02/12/2016 at 15:09:56 +0100, Amelie Delaunay wrote : This patch adds support for the STM32 RTC. Signed-off-by: Amelie Delaunay --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefil

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-12 Thread Amelie DELAUNAY
Hi Alexandre, On 12/07/2016 07:37 PM, Alexandre Belloni wrote: On 05/12/2016 at 10:43:14 +0100, Amelie DELAUNAY wrote : + +device_init_wakeup(&pdev->dev, true); What happens if device_init_wakeup() returns an error? It means that RTC won't be able to wake up the board with RTC alarm. I c

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
Hi, It seems mostly fine. On 02/12/2016 at 15:09:56 +0100, Amelie Delaunay wrote : > This patch adds support for the STM32 RTC. > > Signed-off-by: Amelie Delaunay > --- > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile| 1 + > drivers/rtc/rtc-stm32.c | 777 >

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Alexandre Belloni
On 05/12/2016 at 10:43:14 +0100, Amelie DELAUNAY wrote : > >> + > >> +device_init_wakeup(&pdev->dev, true); > > > > What happens if device_init_wakeup() returns an error? > It means that RTC won't be able to wake up the board with RTC alarm. I can > add a warning for the user in this case ? > >

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-07 Thread Amelie DELAUNAY
On 12/05/2016 05:32 PM, Mathieu Poirier wrote: On Mon, Dec 05, 2016 at 10:43:14AM +0100, Amelie DELAUNAY wrote: Hi Mathieu, Thanks for reviewing On 12/02/2016 06:56 PM, Mathieu Poirier wrote: On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: This patch adds support for the S

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-05 Thread Mathieu Poirier
On Mon, Dec 05, 2016 at 10:43:14AM +0100, Amelie DELAUNAY wrote: > Hi Mathieu, > > Thanks for reviewing > > On 12/02/2016 06:56 PM, Mathieu Poirier wrote: > > On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: > >> This patch adds support for the STM32 RTC. > > > > Hello Amelie, > >

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-05 Thread Amelie DELAUNAY
On 12/02/2016 07:05 PM, Mathieu Poirier wrote: On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: This patch adds support for the STM32 RTC. Signed-off-by: Amelie Delaunay --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile| 1 + drivers/rtc/rtc-stm32.c | 777 +++

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-05 Thread Amelie DELAUNAY
Hi Mathieu, Thanks for reviewing On 12/02/2016 06:56 PM, Mathieu Poirier wrote: > On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: >> This patch adds support for the STM32 RTC. > > Hello Amelie, > >> >> Signed-off-by: Amelie Delaunay >> --- >> drivers/rtc/Kconfig | 10 + >>

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-02 Thread Mathieu Poirier
On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: > This patch adds support for the STM32 RTC. > > Signed-off-by: Amelie Delaunay > --- > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile| 1 + > drivers/rtc/rtc-stm32.c | 777 >

[rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver

2016-12-02 Thread Mathieu Poirier
On Fri, Dec 02, 2016 at 03:09:56PM +0100, Amelie Delaunay wrote: > This patch adds support for the STM32 RTC. Hello Amelie, > > Signed-off-by: Amelie Delaunay > --- > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile| 1 + > drivers/rtc/rtc-stm32.c | 777 >