Re: Patches for classic affinity implementation and test

2014-02-20 Thread Sebastian Huber
On 2014-02-21 02:55, Gedare Bloom wrote: >>I would prefer to see symmetry between our choice to use cpu_set_t as >>the opaque type for the cpu bit sets. Thus I recommend using the score >>name _Cpu_set for the handler. (It is unfortunate that we can't use >>_CPU_set because that would clash with

Re: [PATCH 2/4] score: SMP initialization and shutdown changes

2014-02-20 Thread Sebastian Huber
On 2014-02-21 01:31, Chris Johns wrote: On 21/02/2014 3:31 am, Sebastian Huber wrote: Hello Chris, On 2014-02-20 03:50, Chris Johns wrote: On 20/02/2014 12:42 am, Sebastian Huber wrote: +/** + * @brief State of a processor. + * + * @dot + * digraph states { + * bi [label="PER_CPU_STATE_BEFO

Re: [PATCH v2] score: SMP initialization and shutdown changes

2014-02-20 Thread Sebastian Huber
On 2014-02-20 18:36, Gedare Bloom wrote: What RTEMS configure and BSPs do you test this on? My configure options are --enable-posix --enable-smp --enable-tests --enable-cxx --enable-networking I test on SPARC LEON4 (NGMP is a four processor board), on PowerPC P1020RDB (two processor board) a

Re: patch for cpuset test to check for cpuset in newlib

2014-02-20 Thread Gedare Bloom
I'd like a plan for removing the checks. Perhaps each release cycle should sweep up these feature checks as the tools get stabilized? On Thu, Feb 20, 2014 at 5:17 PM, Joel Sherrill wrote: > > On 2/20/2014 3:12 PM, Gedare Bloom wrote: >> Do we do this with other newlib features? > Various configur

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Gedare Bloom
On Thu, Feb 20, 2014 at 5:22 PM, Joel Sherrill wrote: > > On 2/20/2014 3:11 PM, Gedare Bloom wrote: >> I mostly focused on the 0002-score... file. The others seemed ok at a >> glance... with respect to the 0002 patch I have the following: >> >> Copyright should only be applied to code from the tim

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Gedare Bloom
On Thu, Feb 20, 2014 at 5:54 PM, Joel Sherrill wrote: > > On 2/20/2014 4:45 PM, Peter Dufault wrote: >> On Feb 20, 2014, at 16:11 , Gedare Bloom wrote: >> >>> +#if __RTEMS_HAVE_SYS_CPUSET_H__ >>> I think we decided to prefer the more explicit "#if defined(...)" for >>> checking for CPP defines. >

Re: [PATCH 2/4] score: SMP initialization and shutdown changes

2014-02-20 Thread Chris Johns
On 21/02/2014 3:31 am, Sebastian Huber wrote: Hello Chris, On 2014-02-20 03:50, Chris Johns wrote: On 20/02/2014 12:42 am, Sebastian Huber wrote: +/** + * @brief State of a processor. + * + * @dot + * digraph states { + * bi [label="PER_CPU_STATE_BEFORE_INITIALIZATION"]; + * rsm [label="PE

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Joel Sherrill
On 2/20/2014 4:45 PM, Peter Dufault wrote: > On Feb 20, 2014, at 16:11 , Gedare Bloom wrote: > >> +#if __RTEMS_HAVE_SYS_CPUSET_H__ >> I think we decided to prefer the more explicit "#if defined(...)" for >> checking for CPP defines. >> Also, what is this define checking against / where is it defi

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Peter Dufault
On Feb 20, 2014, at 16:11 , Gedare Bloom wrote: > +#if __RTEMS_HAVE_SYS_CPUSET_H__ > I think we decided to prefer the more explicit "#if defined(...)" for > checking for CPP defines. > Also, what is this define checking against / where is it defined? I think "#if defined()" isn't more explicit

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Joel Sherrill
On 2/20/2014 3:11 PM, Gedare Bloom wrote: > I mostly focused on the 0002-score... file. The others seemed ok at a > glance... with respect to the 0002 patch I have the following: > > Copyright should only be applied to code from the time it is written. > We should avoid copy-paste and extending co

Re: patch for cpuset test to check for cpuset in newlib

2014-02-20 Thread Joel Sherrill
On 2/20/2014 3:12 PM, Gedare Bloom wrote: > Do we do this with other newlib features? Various configure.ac's have these type of tests in them. I know we have code which uses them. It is likely other tests do as well. We are trying to ease the bump with older tools and minimize the risk that git b

Re: patch for cpuset test to check for cpuset in newlib

2014-02-20 Thread Gedare Bloom
Do we do this with other newlib features? On Thu, Feb 20, 2014 at 3:09 PM, Jennifer Averett wrote: > > The attached patch adds the check for cpuset.h in newlib > into the cpuset test. > > Jennifer Averett > On-Line Applications Research > ___ > rtems-de

Re: Patches for classic affinity implementation and test

2014-02-20 Thread Gedare Bloom
I mostly focused on the 0002-score... file. The others seemed ok at a glance... with respect to the 0002 patch I have the following: Copyright should only be applied to code from the time it is written. We should avoid copy-paste and extending copyright into the past. fix the license address as r

patch for cpuset test to check for cpuset in newlib

2014-02-20 Thread Jennifer Averett
The attached patch adds the check for cpuset.h in newlib into the cpuset test. Jennifer Averett On-Line Applications ResearchFrom 2bbd8fb24aa8a9393d3b11455400cb823253f80a Mon Sep 17 00:00:00 2001 From: Jennifer Averett Date: Thu, 6 Feb 2014 12:51:01 -0600 Subject: [PATCH 01/19] sptests: Add chec

Patches for classic affinity implementation and test

2014-02-20 Thread Jennifer Averett
Attached is a set of patches for review that implement classic affinity. Jennifer Averett On-Line Applications ResearchFrom e950c2191bc05f9d60afda99f6529360ae03670b Mon Sep 17 00:00:00 2001 From: Jennifer Averett Date: Thu, 6 Feb 2014 12:42:24 -0600 Subject: [PATCH 02/19] score: Add cpuset suppo

Re: [PATCH v2] score: SMP initialization and shutdown changes

2014-02-20 Thread Gedare Bloom
What RTEMS configure and BSPs do you test this on? On Thu, Feb 20, 2014 at 11:22 AM, Sebastian Huber wrote: > Rename _SMP_Request_other_cores_to_perform_first_context_switch() into > _SMP_Request_start_multitasking() since this requests now a multitasking > start on all configured and available p

[PATCH v2] score: SMP initialization and shutdown changes

2014-02-20 Thread Sebastian Huber
Rename _SMP_Request_other_cores_to_perform_first_context_switch() into _SMP_Request_start_multitasking() since this requests now a multitasking start on all configured and available processors. The name corresponds _Thread_Start_multitasking() and _SMP_Start_multitasking_on_secondary_processor() a

Re: [rtems commit] posix: Set pthread attribute values in detach and setschedparm methods.

2014-02-20 Thread Joel Sherrill
On 2/20/2014 2:45 AM, Sebastian Huber wrote: > On 2014-02-19 17:33, Jennifer Averett wrote: >> Module:rtems >> Branch:master >> Commit:52eecbaa089523a4afaef1024225c7bf5181495e >> Changeset:http://git.rtems.org/rtems/commit/?id=52eecbaa089523a4afaef1024225c7bf5181495e >> >> Author:J

Re: [rtems commit] posix: Set pthread attribute values in detach and setschedparm methods.

2014-02-20 Thread Sebastian Huber
On 2014-02-19 17:33, Jennifer Averett wrote: Module:rtems Branch:master Commit:52eecbaa089523a4afaef1024225c7bf5181495e Changeset:http://git.rtems.org/rtems/commit/?id=52eecbaa089523a4afaef1024225c7bf5181495e Author:Jennifer Averett Date: Wed Feb 19 10:36:01 2014 -0600 posi