Re: [RTnet-developers] Monitoring Link Beat

2006-12-05 Thread Jan Kiszka
Jorge Almeida wrote: > Hello Jan ( not all :) ) > > Please check the new patch against revision 1091. > I think now is everything ok. Thanks. I merged it with minor cleanups, see #1092. Jan signature.asc Description: OpenPGP digital signature --

Re: [RTnet-developers] Monitoring Link Beat

2006-12-05 Thread Jorge Almeida
Hello Jan ( not all :) ) Please check the new patch against revision 1091. I think now is everything ok. Greetings Em Terça, 5 de Dezembro de 2006 08:23, escreveu: > Hi Jorge, > > Jorge Almeida wrote: > > Hello to all. > > > > Hmm, but your mail didn't reach them all yet... > > > > > Sorry

Re: [RTnet-developers] Monitoring Link Beat

2006-12-05 Thread Jan Kiszka
Hi Jorge, Jorge Almeida wrote: > Hello to all. > Hmm, but your mail didn't reach them all yet... > > Sorry for the late answer but i was out of the office in the last days. > > Please see the attached patch with your comments incorporated. The patch to socket.c looks broken (empty hunk, a lo

Re: [RTnet-developers] Monitoring Link Beat

2006-11-29 Thread Jan Kiszka
Paulo Stein wrote: > Hi, > > I pretty new to rtnet, so forgive me any nonsense. No nonsense, valuable feedback in fact! >>> Index: stack/socket.c >>> === >>> --- stack/socket.c(revision 1087) >>> +++ stack/socket.c(working c

Re: [RTnet-developers] Monitoring Link Beat

2006-11-29 Thread Paulo Stein
Hi, I pretty new to rtnet, so forgive me any nonsense. Jan Kiszka wrote: Jorge Almeida wrote: Jan, please consider the new patch for the link beat functionality using the ethtool structure. Any comments??!! Looks OK, find just one issue below. For the nitpicking (coding style

Re: [RTnet-developers] Monitoring Link Beat

2006-11-28 Thread Jan Kiszka
Jorge Almeida wrote: > > Jan, > > please consider the new patch for the link beat functionality using the > ethtool structure. > > > Any comments??!! Looks OK, find just one issue below. For the nitpicking (coding style etc.) see my previous review. [please trim your replies...] > -

Re: [RTnet-developers] Monitoring Link Beat

2006-11-27 Thread Jorge Almeida
Jan, please consider the new patch for the link beat functionality using the ethtool structure. Any comments??!! Jorge Almeida Em Segunda, 27 de Novembro de 2006 10:55, o Jorge Almeida escreveu: > Em Sexta, 24 de Novembro de 2006 17:58, escreveu: > > Jorge Almeida wrote: > > >>>

Re: [RTnet-developers] Monitoring Link Beat

2006-11-27 Thread Jorge Almeida
Em Sexta, 24 de Novembro de 2006 17:58, escreveu: > Jorge Almeida wrote: > >>> > >>> > >>> Index: stack/include/rtnet.h > >>> === > >>> --- stack/include/rtnet.h

Re: [RTnet-developers] Monitoring Link Beat

2006-11-24 Thread Jan Kiszka
Jorge Almeida wrote: >>> >>> >>> Index: stack/include/rtnet.h >>> === >>> --- stack/include/rtnet.h (revision 1087) >>> +++ stack/include/rtnet.h (working cop

Re: [RTnet-developers] Monitoring Link Beat

2006-11-24 Thread Jorge Almeida
Em Sexta, 24 de Novembro de 2006 15:10, escreveu: > Jorge Almeida wrote: > > Hello Jan. > > > > > > In attach follows a patch for the link beat functionality for the rt_8139too > > driver and SOCK_RAW. > > Fine. I added my comments below. > > > > > For more drivers to support this it must be

Re: [RTnet-developers] Monitoring Link Beat

2006-11-24 Thread Jan Kiszka
Jorge Almeida wrote: > Hello Jan. > > > In attach follows a patch for the link beat functionality for the rt_8139too > driver and SOCK_RAW. Fine. I added my comments below. > > For more drivers to support this it must be implemented in the driver (like > rt_8139too) but it think is easy. Ye

Re: [RTnet-developers] Monitoring Link Beat

2006-11-24 Thread Jorge Almeida
Hello Jan. In attach follows a patch for the link beat functionality for the rt_8139too driver and SOCK_RAW. For more drivers to support this it must be implemented in the driver (like rt_8139too) but it think is easy. For the other sockets the only thing to do is add two or three code lines

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jan Kiszka
Jorge Almeida wrote: > Em Quinta, 23 de Novembro de 2006 17:27, o Jan Kiszka escreveu: >> Jorge Almeida wrote: >>> Em Quinta, 23 de Novembro de 2006 16:46, escreveu: Jorge Almeida wrote: > Em Quinta, 23 de Novembro de 2006 16:02, escreveu: >> Jorge Almeida wrote: >>> Hello Jan, >>>

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jorge Almeida
Em Quinta, 23 de Novembro de 2006 17:27, o Jan Kiszka escreveu: > Jorge Almeida wrote: > > Em Quinta, 23 de Novembro de 2006 16:46, escreveu: > >> Jorge Almeida wrote: > >>> Em Quinta, 23 de Novembro de 2006 16:02, escreveu: > Jorge Almeida wrote: > > Hello Jan, > > > > I'm trying

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jan Kiszka
Jorge Almeida wrote: > Em Quinta, 23 de Novembro de 2006 16:46, escreveu: >> Jorge Almeida wrote: >>> Em Quinta, 23 de Novembro de 2006 16:02, escreveu: Jorge Almeida wrote: > Hello Jan, > > I'm trying to implement an easy way of monitoring the link beat of one >>> board. > Wh

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jan Kiszka
Jorge Almeida wrote: > Em Quinta, 23 de Novembro de 2006 16:02, escreveu: >> Jorge Almeida wrote: >>> Hello Jan, >>> >>> I'm trying to implement an easy way of monitoring the link beat of one > board. >>> What i want is to pass the index of the board, and internaly call the >>> "do_ioctl" functio

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jorge Almeida
Em Quinta, 23 de Novembro de 2006 16:02, escreveu: > Jorge Almeida wrote: > > > > Hello Jan, > > > > I'm trying to implement an easy way of monitoring the link beat of one board. > > > > What i want is to pass the index of the board, and internaly call the > > "do_ioctl" function that should b

Re: [RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jan Kiszka
Jorge Almeida wrote: > > Hello Jan, > > I'm trying to implement an easy way of monitoring the link beat of one board. > > What i want is to pass the index of the board, and internaly call the > "do_ioctl" function that should be initialialized in the rtnet_device struct > for each device. > >

[RTnet-developers] Monitoring Link Beat

2006-11-23 Thread Jorge Almeida
Hello Jan, I'm trying to implement an easy way of monitoring the link beat of one board. What i want is to pass the index of the board, and internaly call the "do_ioctl" function that should be initialialized in the rtnet_device struct for each device. My question is, How do i call the do_io