[Rails-core] Re: Testing Patches Need Lovin

2007-01-18 Thread Rich Collins
I do as well. The first one is actually a fairly critical bug. Borderline blocker. It has to do with creation of the join model with has_many :through: http://dev.rubyonrails.org/ticket/7153 The others (mostly just test coverage from heckle - thanks Kevin) http://dev.rubyonrails.org/ti

[Rails-core] Symlinked Plugins

2007-01-18 Thread Mark Van Holstyn
Could we get the following simple patch applied? http://dev.rubyonrails.org/ticket/4245 Mark -- Mark Van Holstyn [EMAIL PROTECTED] http://lotswholetime.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on R

[Rails-core] Re: AJAX problem in 1.2 (but works in RC2) - FIXED

2007-01-18 Thread Brian D. Burns
1.2.1 - Beautiful :) On Jan 18, 4:16 pm, "Michael Koziarski" <[EMAIL PROTECTED]> wrote: > link_to_remote appears to be ignoring :method in the new 1.2 today. > I'm using :method => :put > The template is rendering ok: > {asynchronous:true, evalScripts:true, method:'put'} > However, the logs are

[Rails-core] Re: Lost mySQL connections on OS X, in development mode, with ruby adapter

2007-01-18 Thread Wayne E. Seguin
::cough:: err... whoops... (*only* a dual core unfortunately ;) ) Good point, for multi-core or multi processor the use of -j4 with make is optional but *may* speed up compile time. ~Wayne On Jan 18, 2007, at 17:09 , Manfred Stienstra wrote: On Jan 18, 2007, at 11:00 PM, Wayne E. Seguin

[Rails-core] Re: Testing Patches Need Lovin

2007-01-18 Thread Zack Chandler
On 1/18/07, Kevin Clark <[EMAIL PROTECTED]> wrote: > I've got four patches improving test coverage in various parts of the > framework that could use some love. Here are a few more test coverage patches that resulted from the rcov looking glass: http://dev.rubyonrails.org/ticket/7166 http://d

[Rails-core] Re: Testing Patches Need Lovin

2007-01-18 Thread Kevin Clark
Do note that the patch in 7110 needs Mocha 0.3.3 (released yesterday). There was a bug that caused other problems, but it has been fixed. On 1/18/07, Kevin Clark <[EMAIL PROTECTED]> wrote: I've got four patches improving test coverage in various parts of the framework that could use some love.

[Rails-core] Testing Patches Need Lovin

2007-01-18 Thread Kevin Clark
I've got four patches improving test coverage in various parts of the framework that could use some love. The gaps were found using heckle, and I think I've attached the failing mutations to most of the tickets. http://dev.rubyonrails.org/ticket/7152 http://dev.rubyonrails.org/ticket/7122 http:/

[Rails-core] Re: Lost mySQL connections on OS X, in development mode, with ruby adapter

2007-01-18 Thread Manfred Stienstra
On Jan 18, 2007, at 11:00 PM, Wayne E. Seguin wrote: Then continue as normal: make -j4 Or just make if you don't have 5 processors (: Manfred --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core"

[Rails-core] Re: Lost mySQL connections on OS X, in development mode, with ruby adapter

2007-01-18 Thread Wayne E. Seguin
Pete, My team has also encountered such issues. As far as compiling the mysql gem is concerned, are you using OSX? If so, you'll need to do the following: manually download the mysql-ruby gem, extract and move to the extracted directory then run: > ruby extconf.rb --with-mysql-dir=/usr/local/

[Rails-core] Lost mySQL connections on OS X, in development mode, with ruby adapter

2007-01-18 Thread pete
I just posted a new but likely old bug to the trac, at: http://dev.rubyonrails.org/ticket/7172 In short, the ruby mysql bindings try to send /1 characters to closed connections, causing AR to bail on a call to Finalizer at random places during execution. I don't know if this is a blocker, but

[Rails-core] Re: AJAX problem in 1.2 (but works in RC2)

2007-01-18 Thread Michael Koziarski
link_to_remote appears to be ignoring :method in the new 1.2 today. I'm using :method => :put The template is rendering ok: {asynchronous:true, evalScripts:true, method:'put'} However, the logs are showing the request as :post (no route error). This is happening using the 1.2 gem, and when usin

[Rails-core] Re: Schema dumper and migrations

2007-01-18 Thread Michael Koziarski
I understand why that approach makes sense, but this does feel like a bug for those of us who use this type of naming convention. For example, with the current SchemaDumper, here's some sample output: Oh definitely, the current behaviour is a bug, I just don't think the right solution is to

[Rails-core] Re: Defining the expected behavior of DatabaseStatements.execute()

2007-01-18 Thread Michael Koziarski
It would be very helpful if the core team could define and document the expected behavior of DatabaseStatements.execute(). The implementations appear to vary. Most adapters will return some sort of native result set, SQL Server returns nil and expects a block, DB2 and Sybase return the affected

[Rails-core] Scaffold Resource Patches

2007-01-18 Thread Manfred Stienstra
There are quite a few useful scaffold_resource patches laying around, it would be really great if someone could check them out an maybe apply them? http://dev.rubyonrails.org/search?q=scaffold+resource +patch&noquickjump=1&ticket=on Thanks, Manfred --~--~-~--~~~

[Rails-core] Re: CRITICAL - DB Adapters - Syntax Errors

2007-01-18 Thread Michael A. Schoen
Jonathan Younger wrote: Anyone else notice that changeset 5980[1] hosed several of the db adapters? Note that this wasn't caught by my AR/Oracle autotest because the change was made only on the 1.2 branch, and not on trunk. --~--~-~--~~~---~--~~ You receive

[Rails-core] AJAX problem in 1.2 (but works in RC2)

2007-01-18 Thread Brian D. Burns
Hey, link_to_remote appears to be ignoring :method in the new 1.2 today. I'm using :method => :put The template is rendering ok: {asynchronous:true, evalScripts:true, method:'put'} However, the logs are showing the request as :post (no route error). This is happening using the 1.2 gem, and when

[Rails-core] Re: CRITICAL - DB Adapters - Syntax Errors

2007-01-18 Thread DHH
Yes! David moved the opening { of the hash up a line, after the # nodoc, so it's effectively a comment. Hold the presses! Patch applied, gem repushed. Thanks for spotting this before I announced 1.2 ;) --~--~-~--~~~---~--~~ You received this message because

[Rails-core] Re: CRITICAL - DB Adapters - Syntax Errors

2007-01-18 Thread Jason Garber
Yes! David moved the opening { of the hash up a line, after the # nodoc, so it's effectively a comment. Hold the presses! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to th

[Rails-core] Re: CRITICAL - DB Adapters - Syntax Errors

2007-01-18 Thread Jason Garber
Yes! David moved the opening { of the hash up a line, after the # nodoc, so it's effectively a comment. Hold the presses! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to th

[Rails-core] Re: Schema dumper and migrations

2007-01-18 Thread Benjamin Curtis
On Jan 17, 2007, at 1:55 PM, Michael Koziarski wrote: I don't know if this patch (http://dev.rubyonrails.org/ticket/7085) is worthy of inclusion in 1.2, but I thought I'd highlight here just in case it is. Basically, it fixes the schema dumper and create_table in migrations to determin

[Rails-core] Re: New label helper

2007-01-18 Thread Jarkko Laine
On 18.1.2007, at 16.01, Erik Kastner wrote: I agree - anything to encourage label's is great. Most browsers shift focus to the "for" attribute on click. But even without that, a label tag is semantically correct in describing a form element. I submitted my first patch that add labels for the

[Rails-core] Re: New label helper

2007-01-18 Thread Erik Kastner
I agree - anything to encourage label's is great. Most browsers shift focus to the "for" attribute on click. But even without that, a label tag is semantically correct in describing a form element. I submitted my first patch that add labels for the generated scaffold source for resources: http:/

[Rails-core] Re: New label helper

2007-01-18 Thread Jarkko Laine
On 18.1.2007, at 12.04, Andrew Kaspick wrote: I thought rails needed a label helper at first, but then I decided that form builders fill the gap just fine as well as allowing more flexibility and control. I have my own form builder for example that automatically associates labels with my cont

[Rails-core] CRITICAL - DB Adapters - Syntax Errors

2007-01-18 Thread Jonathan Younger
Anyone else notice that changeset 5980[1] hosed several of the db adapters? Specifically: activerecord/lib/active_record/connection_adapters/frontbase_adapter.rb activerecord/lib/active_record/connection_adapters/mysql_adapter.rb activerecord/lib/active_record/connection_adapters/openbase_ada

[Rails-core] patch - really deprecat assert_tag

2007-01-18 Thread Rob Sanheim
I know its really close to 1.2, but this is a really small patch that really deprecates assert_tag and assert_no_tag. There are articles and docs that talk about this, but it was never implemented, so the current code could be confusing or misleading. Here's a patch that deprecates it, refers u

[Rails-core] Re: changing the default behaviour of to_xml for has-many: associations

2007-01-18 Thread James.Strachan
John Wilger wrote: On Jan 17, 5:32 pm, "Michael Koziarski" <[EMAIL PROTECTED]> wrote: Hmm, that is certainly annoying behaviour. I can definitely buy the case for an option to use the association name rather than foo.bars.first.whatever.that.code.does. I'm not necessarily sure that 'polym

[Rails-core] Re: New label helper

2007-01-18 Thread Andrew Kaspick
I thought rails needed a label helper at first, but then I decided that form builders fill the gap just fine as well as allowing more flexibility and control. I have my own form builder for example that automatically associates labels with my controls without me needing to specify them in my vie

[Rails-core] Re: Worrisome trac spam

2007-01-18 Thread Jarkko Laine
On 17.1.2007, at 7.09, Michael Koziarski wrote: Stupid question: Why doesn't some go ahead and make it so that you have to register an account with a captcha in order to post to the Rails trac? Is it that difficult? Spammers are already manually registering accounts and then spamming all the

[Rails-core] New label helper

2007-01-18 Thread Jarkko Laine
Bump: http://dev.rubyonrails.org/ticket/7139 Thoughts? (Not for 1.2, but in general) //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi smime.p7s Description: S/MIME cryptographic signature

[Rails-core] Re: Schema dumper and migrations

2007-01-18 Thread Jarkko Laine
On 18.1.2007, at 10.34, Michael Koziarski wrote: Sure, but that's a setting telling active record how to determine the name of the primary key for a given model, not what to call the primary key of a given table when creating it. They're two seperate things, otherwise the api could also respec

[Rails-core] Re: Schema dumper and migrations

2007-01-18 Thread Michael Koziarski
I don't think this patch is about the API. ActiveRecord::Base.primary_key_prefix_type already exists, the patch just makes the schema dumper and migrations respect that setting. Sure, but that's a setting telling active record how to determine the name of the primary key for a given model, no

[Rails-core] Re: Schema dumper and migrations

2007-01-18 Thread Jarkko Laine
On 17.1.2007, at 23.55, Michael Koziarski wrote: I don't know if this patch (http://dev.rubyonrails.org/ticket/7085) is worthy of inclusion in 1.2, but I thought I'd highlight here just in case it is. Basically, it fixes the schema dumper and create_table in migrations to determine the