[Rails-core] Re: Inconsistent Method Visibility

2007-03-12 Thread Jeremy Kemper
On 3/12/07, Jonathan Viney <[EMAIL PROTECTED]> wrote: > It might be easier to change alias_method_chain to ensure that the new > methods have the same public/private/protected status as the original one. > Or is that not desirable? Sounds like a good idea. In any case, I think it's good practice

[Rails-core] Re: Inconsistent Method Visibility

2007-03-12 Thread Jonathan Viney
It might be easier to change alias_method_chain to ensure that the new methods have the same public/private/protected status as the original one. Or is that not desirable? -Jonathan. On 3/13/07, Dan Manges <[EMAIL PROTECTED]> wrote: > > > When researching an issue today I noticed > ActionControll

[Rails-core] Inconsistent Method Visibility

2007-03-12 Thread Dan Manges
When researching an issue today I noticed ActionController::Base#render is originally protected, but then made public after including modules. I submitted ticket #7812 to fix it, and then thought I would check the other methods. I submitted ticket #7813 to fix other inconsistencies. Due to movi