[Rails-core] Re: Odd error handling in ActionView#compile_template causes WSOD

2007-04-05 Thread Dan Kubb
On 5-Apr-07, at 9:01 AM, Julian Tarkhanov wrote: > Is it only me or has the template lookup code in Rails become an > unmanagable-unrefactorable pile of gunk? (blantly put) Its not just you, I've tried to debug view problems before and often get lost in the tangle of code that's present. My big

[Rails-core] Re: Odd error handling in ActionView#compile_template causes WSOD

2007-04-05 Thread Rick Olson
URLs so you folks at home can play along: > BEFORE > raise TemplateError.new(@base_path, file_name || template, @assigns, > template, e) http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_view/base.rb?rev=6119#L514 > AFTER > raise TemplateError.new(lookup_template_base_path_for(file

[Rails-core] Re: Odd error handling in ActionView#compile_template causes WSOD

2007-04-05 Thread Rick Olson
On 4/5/07, Jon <[EMAIL PROTECTED]> wrote: > > If a view file cannot be compiled (eg it has a block with a missing > 'end' statement), I'm experiencing WSODs - the browser reports a lost > network connection, rather than the helpful compilation error that we > used to have. > > When the compilation

[Rails-core] Re: Current problems with Rails tests and the CI build

2007-04-05 Thread Roderick van Domburg
Hi Alex, Great work on CC.rb. Lovely stuff! > A bit of nagging about tests. I still cannot include the following things in > the continuous integration loop, because their tests do not pass: > > * AR with SQLite > * AR with SQLite3 The patch I submitted with ticket #7981 [1] reduces the number

[Rails-core] Re: Odd error handling in ActionView#compile_template causes WSOD

2007-04-05 Thread Julian Tarkhanov
On Apr 5, 2007, at 2:37 PM, Jon wrote: > > The reason I'm posting here rather than submitting a patch to Trac is > that I'm struggling to understand a few things about that line of > code, and so I'm not sure of the best way to fix it. Is it only me or has the template lookup code in Rails beco

[Rails-core] Odd error handling in ActionView#compile_template causes WSOD

2007-04-05 Thread Jon
If a view file cannot be compiled (eg it has a block with a missing 'end' statement), I'm experiencing WSODs - the browser reports a lost network connection, rather than the helpful compilation error that we used to have. When the compilation fails, ActionView#compile_template raises this error :