[Rails-core] Request for Review, Ticket 10681

2008-01-02 Thread James H.
Hey gang. Can I get some love on ticket 10681 (http://dev.rubyonrails.org/ticket/ 10681)? I've refactored ActionController::Verification and cleaned up the docs. As described in the ticket, all tests pass, and I've verified against my own applications. I'd really appreciate some additional ver

[Rails-core] Fix render :text => false and render :text => nil

2008-01-02 Thread chuyeow
Obie Fernandez (http://www.jroller.com/obie/entry/render_text_gotcha) was asking in the #rails-contrib channel about getting this ticket (http://dev.rubyonrails.org/ticket/6684) fixed. If someone's free could you please review/verify it and appease the "ignored" ticket reporter ;)? Cheers, Chu Ye

[Rails-core] Re: Rails core team - only development?

2008-01-02 Thread Anthony Kelly
Jeremy McAnally wrote: > Yeah we moved all the book work over to the Basecamp. I think we're > keeping the core work there and then we'll handle tickets, issues, and > other input through Lighthouse. > > We'll hopefully have some more information soon (we're hacking out an > outline and such at

[Rails-core] Re: Rails core team - only development?

2008-01-02 Thread Jeremy McAnally
Yeah we moved all the book work over to the Basecamp. I think we're keeping the core work there and then we'll handle tickets, issues, and other input through Lighthouse. We'll hopefully have some more information soon (we're hacking out an outline and such at present). --Jeremy On Jan 2, 2008

[Rails-core] Re: Rails core team - only development?

2008-01-02 Thread Anthony Kelly
Anthony Kelly wrote: > This looks pretty good. I saw the other thing on lighthouse: > http://railsdocs.lighthouseapp.com/projects/2637 Oops I meant: http://www.railsdocumentation.org/book.html It wasn't on lighthouse, that one never took off. -- Posted via http://www.ruby-forum.com/. --~--~---

[Rails-core] Re: Rails core team - only development?

2008-01-02 Thread Anthony Kelly
Michael Slater wrote: > My colleague Christopher Haupt and I are deep into building a portal > site to serve Ruby on Rails developers at www.BuildingWebApps.com. > We're going to be providing annotated links to all the key content on > the web related to Rails, and we'll have quite a few of our o

[Rails-core] Re: Rails core team - only development?

2008-01-02 Thread Anthony Kelly
August Lilleaas wrote: > Because of the reasons mentioned above. An API is a reference tool, > and has a tremendously steep learning curve if you don't know anything > about Rails. The API is indeed documentation, but it's not sufficient > for a beginner. So, the official documentation is no good

[Rails-core] Sybase gem is buggy

2008-01-02 Thread Anthony Kelly
This is an old issue from before it was a gem. The two tickets that describe the bugs are #8400 and #10629. What will happen now that it is a gem? -- Posted via http://www.ruby-forum.com/. --~--~-~--~~~---~--~~ You received this message because you are subscribed

[Rails-core] Re: Sybase Adaptor patch: User.find("1") will fail when numc

2008-01-02 Thread Anthony Kelly
Need an active record expert to look into two tickets on the Sybase adapter (which is now a gem). Tickets are #8400 and #10629. Thanks in advance! ~ Anthony Jeremy Burks wrote: > The same issue occurs with validates_uniqueness_of: > http://groups.google.com/group/rubyonrails-talk/browse_thread

[Rails-core] [CruiseControl] RubyOnRails build 8526 fixed

2008-01-02 Thread alexey . verkhovsky
The build has been fixed. CHANGES --- Revision 8526 committed by bitsweat on 2008-01-02 18:09:52 Fix failing date helper test. Closes #10664 [Wesley Moxam] M /trunk/actionpack/test/template/date_helper_test.rb See http://cruisecontrolrb.thoughtworks.com/builds/RubyOnRails/8526 for detai

[Rails-core] Can someone apply these verified patches?

2008-01-02 Thread Jeff
I'm hoping someone from core would be willing to commit this one: http://dev.rubyonrails.org/ticket/10565 And also to just get a thumbs-up or down on this one, one way or the other. We've had several opinions and I think it's in need of an "official Rails opinion" at this point: http://dev.rub

[Rails-core] Re: RubyOnRails build 8525 failed

2008-01-02 Thread chuyeow
Fix for the bad (failing) test here: http://dev.rubyonrails.org/ticket/10664 On Jan 2, 5:33 pm, [EMAIL PROTECTED] wrote: > The build failed. > > CHANGES > --- > Revision 8522 committed by bitsweat on 2008-01-02 09:03:56 > db:sessions:clear task uses session_table_name method. Closes #10631 [C

[Rails-core] Re: Submitted a patch, got pluses, what now?

2008-01-02 Thread Frederick Cheung
On 2 Jan 2008, at 13:31, Pratik wrote: > > Sweet. Now you can wait for a core member to apply the patch. If you > lose patience, you can always try to find a core guy in #rails-contrib > irc channel at irc.freenode.net And bear in mind that the last 10 days or so have been quiet, what with ch

[Rails-core] Re: Submitted a patch, got pluses, what now?

2008-01-02 Thread Cheah Chu Yeow
> > Can anybody advise or just review the patch and take care of the issue? What you just did (posting about your ticket here) works too ;) Your ticket is already verified so all that's left is to raise it to the attention of a Rails core committer so he can review and probably apply it. And this

[Rails-core] Re: Submitted a patch, got pluses, what now?

2008-01-02 Thread Pratik
Sweet. Now you can wait for a core member to apply the patch. If you lose patience, you can always try to find a core guy in #rails-contrib irc channel at irc.freenode.net On Jan 2, 2008 1:25 PM, Yuri Leikind <[EMAIL PROTECTED]> wrote: > Hello Rails people, > > I submitted a patch recently to ge

[Rails-core] Submitted a patch, got pluses, what now?

2008-01-02 Thread Yuri Leikind
Hello Rails people, I submitted a patch recently to get rid of an annoying exception raised when an AR object is created - http://dev.rubyonrails.org/ticket/10556 , had some people review it, got some pluses... What am I supposed to do now? Can anybody advise or just review the patch and take car

[Rails-core] [CruiseControl] RubyOnRails build 8525 failed

2008-01-02 Thread alexey . verkhovsky
The build failed. CHANGES --- Revision 8522 committed by bitsweat on 2008-01-02 09:03:56 db:sessions:clear task uses session_table_name method. Closes #10631 [Cheah Chu Yeow] M /trunk/railties/lib/tasks/databases.rake Revision 8523 committed by bitsweat on 2008-01-02 09:08:14 Ruby 1.9 co

[Rails-core] [CruiseControl] RubyOnRails build 8521 failed

2008-01-02 Thread alexey . verkhovsky
The build failed. CHANGES --- Revision 8521 committed by bitsweat on 2008-01-02 09:01:19 Correct Hash#assert_valid_keys docs. Closes #10621 [Cheah Chu Yeow, blackanger] M /trunk/activesupport/lib/active_support/core_ext/hash/keys.rb TEST FAILURES AND ERRORS --- Name:

[Rails-core] [CruiseControl] RubyOnRails build 8519 failed

2008-01-02 Thread alexey . verkhovsky
The build failed. CHANGES --- Revision 8519 committed by bitsweat on 2008-01-02 08:28:58 SQLite: db:drop:all doesn't fail silently if the database is already open. Closes #10577. M /trunk/railties/lib/tasks/databases.rake M /trunk/railties/CHANGELOG TEST FAILURES AND ERRORS -

[Rails-core] [CruiseControl] RubyOnRails build 8518 failed

2008-01-02 Thread alexey . verkhovsky
The build failed. CHANGES --- Revision 8518 committed by bitsweat on 2008-01-02 08:26:37 Fix invalid time test. Closes #10632 [Dirkjan Bussink] M /trunk/activesupport/test/core_ext/time_ext_test.rb M /trunk/activesupport/CHANGELOG M /trunk/activesupport/test/multibyte_chars_test.rb