On Jan 25, 2008 9:22 PM, Michael Koziarski <[EMAIL PROTECTED]> wrote:
>
> I'm happy with the documentation but not sure I buy the need for
> #8720?
Why match the API of polymorphic_path with polymorphic_url? Because there is
no need for these two to have different signatures, especially since
ge
The build failed.
CHANGES
---
Revision 8734 committed by nzkoz on 2008-01-26 05:11:09
Correct documentation for dom_id [jbarnette] Closes #10775
M /trunk/actionpack/lib/action_controller/record_identifier.rb
TEST FAILURES AND ERRORS
---
Name: test_ordering(FirstSecon
The build failed.
CHANGES
---
Revision 8733 committed by nzkoz on 2008-01-26 05:08:20
Add tests and documentation for allow_blank. Closes #10651 [blj]
M /trunk/activerecord/test/cases/validations_test.rb
M /trunk/activerecord/lib/active_record/validations.rb
TEST FAILURES AND ERRORS
-
Hi guys,
I came across this obscure bug in the new preload associations:
NoMethodError (undefined method `preload_associations' for
NilClass:Class):
/vendor/rails/activerecord/lib/active_record/
association_preload.rb:25:in `preload_associations'
/vendor/rails/activerecord/lib/active_rec
The build failed.
CHANGES
---
Revision 8732 committed by gbuesing on 2008-01-26 00:34:44
TimeWithZone#- added, so that #- can handle a Time or TimeWithZone argument
correctly
M /trunk/activesupport/CHANGELOG
M /trunk/activesupport/test/core_ext/time_with_zone_test.rb
M /trunk/activesu
The build failed.
CHANGES
---
Revision 8731 committed by gbuesing on 2008-01-26 00:11:59
with_timezone test helper renamed with_env_tz, to distinguish between setting
ENV['TZ'] and setting Time.zone in tests
M /trunk/activesupport/test/core_ext/date_ext_test.rb
M /trunk/activesupport/tes
The build failed.
CHANGES
---
Revision 8730 committed by gbuesing on 2008-01-25 23:55:07
Time#- coerces TimeWithZone argument to a Time instance so that difference in
seconds can be calculated. Closes #10914 [Geoff Buesing, yyyc514]
M /trunk/activesupport/lib/active_support/core_ext/time/c
I created a ticket with simplified application:
http://dev.rubyonrails.org/ticket/10925
Daniel
On Jan 25, 3:18 pm, "Michael Koziarski" <[EMAIL PROTECTED]> wrote:
> On Jan 26, 2008 5:10 AM, Daniel Guettler <[EMAIL PROTECTED]> wrote:
>
>
>
> > I came across this when switching from rails 1.2.6 to
> OK, so we're keeping formatted_foo helpers for now. But what of my patch?
>
> http://dev.rubyonrails.org/ticket/10883
>
> It fixes issues. It adds tons of documentation. It provides more test
> coverage. Is there anything wrong with it? Anything that someone would like
> to put up for discussion
On Jan 26, 2008 5:10 AM, Daniel Guettler <[EMAIL PROTECTED]> wrote:
>
> I came across this when switching from rails 1.2.6 to 2.0.2, there is
> a change in the way routes are generated between these to version due
> to the routing optimization in rails 2.0.2.
> In version 1.2.6 it was possible to
The build failed.
CHANGES
---
Revision 8720 committed by gbuesing on 2008-01-25 18:23:22
Adding UTC zone to TimeZone; TimeWithZone no longer has to fake UTC zone with
nil
M /trunk/activesupport/test/core_ext/time_ext_test.rb
M /trunk/activesupport/CHANGELOG
M /trunk/activesupport/lib/a
Thanks Michael. I did just that and Ben Scofield pointed me in the
right direction.
Can I get a +1?
-Chris
On Jan 24, 10:58 pm, "Michael Koziarski" <[EMAIL PROTECTED]>
wrote:
> > But I am having a tough time writing a failing test. It seems as
> > though TestRequest does not implement the get
The build failed.
CHANGES
---
Revision 8719 committed by gbuesing on 2008-01-25 16:12:43
Time.get_zone refactored to private method, given that the encapsulated logic
is only useful internally
M /trunk/activesupport/CHANGELOG
M /trunk/activesupport/lib/active_support/core_ext/time/zones.
The build failed.
CHANGES
---
Revision 8718 committed by gbuesing on 2008-01-25 15:52:23
Time.zone uses thread-local variable for thread safety. Adding Time.use_zone,
for
overriding Time.zone locally inside a block. Removing unneeded Time.zone_reset!
M /trunk/activesupport/CHANGELOG
M
I came across this when switching from rails 1.2.6 to 2.0.2, there is
a change in the way routes are generated between these to version due
to the routing optimization in rails 2.0.2.
In version 1.2.6 it was possible to overwrite the default_url_options
method in ActionController::Base to define p
OK, so we're keeping formatted_foo helpers for now. But what of my patch?
http://dev.rubyonrails.org/ticket/10883
It fixes issues. It adds tons of documentation. It provides more test
coverage. Is there anything wrong with it? Anything that someone would like
to put up for discussion, or to have m
16 matches
Mail list logo
