[Rails-core] Re: Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Joshua Peek
Applied the fix to Rails. I also submitted this patch to Rack: http://rack.lighthouseapp.com/projects/22435/tickets/ On Jan 20, 11:21 am, "Mislav Marohnić" wrote: > Ticket > createdhttp://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/17... > I would like to ask someone to create

[Rails-core] Re: Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Mislav Marohnić
Ticket created http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1785-empty-file-uploads-should-not-come-through-as-empty-tempfiles I would like to ask someone to create a failing tests for this. I didn't figure out how to simulate a browser submitting an empty form field -- I don'

[Rails-core] Re: Integrity for CI instead of CC.rb?

2009-01-20 Thread Mike Gunderloy
Here's the problem: if we use the multiruby command, we end up with one pass-or-fail for "Rails across all installed versions of ruby". Instead, we need separate cc.rb projects (or integrity or runcoderun or whatever) so we can quickly see "rails passed on ruby 1.8.7" in one project and "r

[Rails-core] Re: Integrity for CI instead of CC.rb?

2009-01-20 Thread Rob Sanheim
On Thu, Jan 15, 2009 at 11:29 AM, Mike Gunderloy wrote: > > One note on this: we probably *don't* want to just run the tests with > multiruby. Instead, we want to have multiple versions of ruby > installed, and run the tests separately with each version. That makes > it much easier to spot whethe

[Rails-core] Re: Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Joshua Peek
On Tue, Jan 20, 2009 at 9:48 AM, Mislav Marohnić wrote: > In my workaround I detect there was no file if the `filename` property is > blank. Are there cases a valid file could be uploaded without an original > filename? Is a better check to see if the size of Tempfile is 0, also? I think a filen

[Rails-core] Re: Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Mislav Marohnić
On Tue, Jan 20, 2009 at 16:41, Joshua Peek wrote: > > I'm trying to make Rails 2.3 w/ Rack as backwords compat with the CGI > API. So this is definitely something we need to fix in Rails. > > Please create a ticket on LH with some tests (so we can catch this > issue if it happens again) and I'll

[Rails-core] Re: Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Joshua Peek
I'm trying to make Rails 2.3 w/ Rack as backwords compat with the CGI API. So this is definitely something we need to fix in Rails. Please create a ticket on LH with some tests (so we can catch this issue if it happens again) and I'll pull it in ASAP. Thanks for finding this. On Tue, Jan 20, 20

[Rails-core] Switching to Rack possibly breaks user code dealing with file uploads

2009-01-20 Thread Mislav Marohnić
We're using Paperclip for file uploads and recent edge Rails rendered our user profile forms unusable. File uploads don't break our application when there was an actual file upload; what breaks Paperclip is the case when *nothing was selected* in the file input. The form is still sent with multipar