Re: [Rails-core] Rails 3 no longer URI escaping [ and ]

2010-11-16 Thread Jeremy Evans
On Sun, Oct 10, 2010 at 8:36 PM, Michael Koziarski wrote: >>> Is it breaking your app some how? >> >> It breaks some test code, that's all.  Test code that works on 5 other >> web frameworks and previous versions of Rails. >> >> It's not a big deal either way, but I wanted to know rails-core >> op

[Rails-core] Fwd: [railsbridge] Postponed: Bugmash December 3-5

2010-11-16 Thread Santiago Pastorino
-- Forwarded message -- From: Dan Pickett Date: Tue, Nov 16, 2010 at 3:23 PM Subject: [railsbridge] Postponed: Bugmash December 3-5 To: railsbri...@googlegroups.com This must have not of made it through moderation for some reason. Would anyone be willing to help out with a late J

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
On Oct 18, 7:13 pm, Joe Fiorini wrote: > ActionDispatch::Assertions::RoutingAssertions (https://gist.github.com/ > a57e3addfe0aa3857e12). Does anyone else see value for this in core? Is > the code okay? I personally would not use that. You're just adding line to tests that ensures that you adde

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
I don't think that you need to do such unit tests, without mounting an engine you will not be able to reach engine's routes, so tests will fail anyway. > Yeah i have spent the last week trying to mount an app Remember that this is still an edge version and some things can (and probably will) chan

[Rails-core] Arel 2 isn't playing nice with my legacy tables

2010-11-16 Thread Jason King
Specifically, it's not playing nice with any type that it doesn't recognize, eg. SET, ENUM, etc.. Just trying to start my Rails 3.0.2 app I get a NotImplementedError exception "Column type `` is not currently handled" on the first SET field it encounters. Am I missing something here? Should I be

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
Damn, google groups ate my post, so again ;) Joe Fiorini: I don't like that kind of tests. You just add a line in tests that ensures that you added a line in routes. Better way to do that would be to check if engine can be properly rendered inside application. But I'm not in core and it's only my

[Rails-core] # 5986 [Patch] Update Cookies API documentation and remove deprecated "cookie_verifier_secret"

2010-11-16 Thread Doug
Per the Rails contributor guide, I've opened a new Lighthouse ticket (#5986) and attached a patch. Can someone please review my patch to Rails 3? https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5986 Thanks, Doug Ireton -- You received this message because you are subscribe

[Rails-core] Re: Arel 2 isn't playing nice with my legacy tables

2010-11-16 Thread Jason King
Fixed in 2.0.3 - thanks. On Mon, Nov 15, 2010 at 3:38 PM, Jason King wrote: > Specifically, it's not playing nice with any type that it doesn't > recognize, eg. SET, ENUM, etc.. > > Just trying to start my Rails 3.0.2 app I get a NotImplementedError > exception "Column type `` is not currently h

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Ryan Bigg
I agree with Piotr.You should never be testing that routes are there in your application, but rather that whatever's on the end of that route is performing as it should.Let's say that I have a /forums route that displays a list of forums, one of them being called "The Ghetto".