Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 02:49:55PM -0700, David Chelimsky wrote: > > Perfect. That's what I would expect. Will `controller_class` ever > > return something that can't be constructed via `new`? > > > > Not by rspec, but I can't account for end users doing silly things :) Yes, and I presume end

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread David Chelimsky
On Sunday, July 29, 2012 5:22:05 PM UTC-4, Aaron Patterson wrote: > > On Sun, Jul 29, 2012 at 01:47:34PM -0700, David Chelimsky wrote: > > On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > > > > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > > > > > O

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 01:47:34PM -0700, David Chelimsky wrote: > On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > > > > > In the case a d

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread David Chelimsky
On Sunday, July 29, 2012 4:29:59 PM UTC-4, Aaron Patterson wrote: > > On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > > > In the case a developer has not constructed a controller, the setup > > > method of ActionCon

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Aaron Patterson
On Sun, Jul 29, 2012 at 11:54:33AM -0400, Matt Jones wrote: > > On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > > > In the case a developer has not constructed a controller, the setup > > method of ActionController::TestCase will attempt to construct a > > controller object. If it cannot

[Rails-core] In-memory uniqueness validator

2012-07-29 Thread Gabriel Sobrinho
Hi, Currently uniqueness validator uses database queries which not work for nested forms. For example, I have a company form which have many partners and each partner have a person and a percentage. Using uniqueness validator, I can not guarantee someone will not be a partner two times becau

Re: [Rails-core] ActionController::TestCase controller construction

2012-07-29 Thread Matt Jones
On Jul 28, 2012, at 11:44 PM, Aaron Patterson wrote: > In the case a developer has not constructed a controller, the setup > method of ActionController::TestCase will attempt to construct a > controller object. If it cannot construct a controller object, it > silently fails. > > I added a warni

[Rails-core] Need some feedback for my pull request

2012-07-29 Thread Guirec Corbel
Hello, I just send a new pull request. You can see it here : https://github.com/rails/rails/pull/7189. I don't know if there is a better way to do what I want but it's the solution I found. Can you check it please? Thanks! -- You received this message because you are subscribed to the Google G