Re: [Rails-core] Any rails experts able to offer some advice?

2012-09-25 Thread Jeffrey Jones
Hi Patrick That is very useful because it shows another way of testing things. I am not entirely sure I like it because it is faking the creation of the events rather than using the actual rails code to create the, but it is certainly something worth considering if I cannot break the wall. C

Re: [Rails-core] Excessive redundant object allocation in AR

2012-09-25 Thread Gary Weaver
On Friday, September 14, 2012 9:03:32 AM UTC-4, Gary Weaver wrote: > > On Thursday, September 13, 2012 5:38:57 PM UTC-4, Masterleep wrote: > >> Excellent! I verified that your fix did eliminate the redundancy on >> these field name strings in the case I was studying (from 15 extra strings >> p

[Rails-core] update_attribute, update_column and update_columns should update readonly attributes

2012-09-25 Thread Vadim Pushtaev
Hi. I created a pull request some time ago and didn't get any reaction yet. https://github.com/rails/rails/pull/7688 Should I do something special or just have a patient and wait? I'm ready to answer any questions about my commit. Thanks in advance. Best regards, Vadim Pushtaev -- You recei

Re: [Rails-core] [activerecord] Better loading pattern for connection adapters that play nicely with bundler --standalone

2012-09-25 Thread Aaron Patterson
On Tue, Sep 25, 2012 at 06:58:45AM -0700, excsm wrote: > Hi, > > I initially sent this idea as a github > issue: https://github.com/rails/rails/issues/7753 (closed) > > Steve Klabnik suggested I should post here first (better late than never). > > I've since created a PR: https://github.com/rai

Re: [Rails-core] Proposal for a new ActiveModel::Errors structure

2012-09-25 Thread Aaron Patterson
On Tue, Sep 25, 2012 at 06:39:58AM -0700, Szymon Nowak wrote: > There are few issues with the current ActiveModel::Errors class. > > Firstly, when an error is added to ActiveModel::Errors class via #add > method > (https://github.com/rails/rails/blob/master/activemodel/lib/active_model/errors.rb

Re: [Rails-core] Feature Request: Auto-infer .includes from .where with ActiveRecord queries

2012-09-25 Thread Everton Moreth
I believe it cant be inferred, thats why: Order.where(:items => {:name => "X"}) SELECT `orders`.* FROM `orders` WHERE `orders`.`name` = 'X' <== Clearly wrong. Order.*includes(:item)*.where(:items => {:name => "X"}) SELECT `orders`.`id` AS t0_r0, `orders`.`item_id` AS t0_r1, ... , `items`.`id` AS

[Rails-core] [activerecord] Better loading pattern for connection adapters that play nicely with bundler --standalone

2012-09-25 Thread excsm
Hi, I initially sent this idea as a github issue: https://github.com/rails/rails/issues/7753 (closed) Steve Klabnik suggested I should post here first (better late than never). I've since created a PR: https://github.com/rails/rails/pull/7755 Original discussion: == I'm using the

Re: [Rails-core] Any rails experts able to offer some advice?

2012-09-25 Thread Patrick Mulder
On Tue, Sep 25, 2012 at 7:00 AM, Jeffrey Jones wrote: > > #1 I am working on a rails3 gem called Yarder > (https://github.com/rurounijones/yarder). The goal of this gem is to replace > the rails logging system with one that is JSON based rather than string > based. > I am not an expert here, but

[Rails-core] Re: Any rails experts able to offer some advice?

2012-09-25 Thread Gary Weaver
Not an expert, but since I have been kind of slack on testing recently, I'll try to get some karma by trying to help. First, you may want to ask on this list instead/too: https://groups.google.com/forum/?fromgroups=#!forum/rubyonrails-talk (Stackoverflow is also a good place to get Rails stuff an

Re: [Rails-core] Where db tasks in Rails 4.0.0.beta

2012-09-25 Thread Geoffrey Roguelon
Hi, Excuse me, I have installed again Rails 4 and db tasks are back… Thanks. - Geoffrey Roguelon Le 24 sept. 2012 à 16:48, Rafael Mendonça França a écrit : > Everything work fine to me https://gist.github.com/3776317 > > Rafael Mendonça França > http://twitter.com/rafaelfranca > https:/

Re: [Rails-core] Proposal for a new ActiveModel::Errors structure

2012-09-25 Thread Piotr Sarnacki
I would really love to see such changes in AM::Errors. +1 from me. On Tue, Sep 25, 2012 at 3:39 PM, Szymon Nowak wrote: > There are few issues with the current ActiveModel::Errors class. > > Firstly, when an error is added to ActiveModel::Errors class via #add > method ( > https://github.com/rai

[Rails-core] Proposal for a new ActiveModel::Errors structure

2012-09-25 Thread Szymon Nowak
There are few issues with the current ActiveModel::Errors class. Firstly, when an error is added to ActiveModel::Errors class via #add method (https://github.com/rails/rails/blob/master/activemodel/lib/active_model/errors.rb#L294) its translation is added. It should not be translated when bein