Re: [Rails-core] smart eager loading and caching

2014-05-19 Thread Yves Senn
I agree with Matt on this subject. Even if we could come up with useful heuristics, we would not deprecate includes, eager_load and preload. There are always situations you can't detect. Also I wouldn't want to use that feature on some of my apps. It can be crucial what Query is executed and

[Rails-core] Re: Use pregenerated binstubs in guides?

2014-05-19 Thread Yves Senn
Hey Josef, A PR that promotes the use of bin/* would be great. It is the suggested way to run `rails` and `rake`. Feel free to mention me on the PR if you have questions or for review. Cheers, -- Yves On Tuesday, April 8, 2014 10:01:00 AM UTC+2, Josef Šimánek wrote: Hello. It looks like

Re: [Rails-core] HttpOnly cookies by default

2014-05-19 Thread Gabriel Sobrinho
I can't be sure but using cookies for that sounds the wrong solution for me, you have better options like a shared database, a redis instance may work. You'll need to use a cookie to share a session identifier (I would use a uuid) between the applications but reducing it to just one cookie may

[Rails-core] Fix request.ip and request.remote_ip inconsistencies

2014-05-19 Thread Aaron Suggs
Hi Rails Core! While adding a reverse proxy to a Rails 4 app, I was surprised to see that `request.ip` and `request.remote_ip` had different values. That's a gotcha that I'd like to fix. Here's a demo app https://github.com/ktheory/rails_remote_ip_demo showing how `Client-IP` and

Re: [Rails-core] Fix request.ip and request.remote_ip inconsistencies

2014-05-19 Thread Sergio Campamá
I don't know very well, but isn't ip meant to be for example the nginx instance that proxied the request and remote_ip the client? Are you proxing behind something or direct facing the web? If it's direct, then the values should be the same (from what I think should be, haven't read the code)

Re: [Rails-core] Re: Use pregenerated binstubs in guides?

2014-05-19 Thread Steve Klabnik
+1, for sure. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to

Re: [Rails-core] Re: Use pregenerated binstubs in guides?

2014-05-19 Thread Josef Šimánek
Working on. 2014-05-19 20:07 GMT+02:00 Steve Klabnik st...@steveklabnik.com: +1, for sure. -- You received this message because you are subscribed to a topic in the Google Groups Ruby on Rails: Core group. To unsubscribe from this topic, visit

Re: [Rails-core] Fix request.ip and request.remote_ip inconsistencies

2014-05-19 Thread Rodrigo Rosenfeld Rosas
I faced exactly the same issue last week when trying to figure out the correct Vagrant client ip for testing purposes. Since I later decided upon a better strategy for my case which didn't rely on the client ip but an extra param instead, I didn't go further to understand why I was not getting