[Rails-core] ActionMailer deliver_later and i18n in 4.2

2014-10-22 Thread Igor Kapkov
Hi all, previously if we needed in sending a mail in different locale we used `I18n.with_locale`. I didn't find any about that in sources and docs/guides. How it'll work with `deliver_later` and ActiveJob? Best Regards, Igas -- You received this message because you are subscribed to the

Re: [Rails-core] ActionMailer deliver_later and i18n in 4.2

2014-10-22 Thread Mohamed Wael Khobalatte
There shouldn't be any problem since deliver_later will simply invoke your deliver_now at some point, and that should run as you expect. On Wed, Oct 22, 2014 at 2:31 PM, Igor Kapkov igasg...@gmail.com wrote: Hi all, previously if we needed in sending a mail in different locale we used

Re: [Rails-core] ActionMailer deliver_later and i18n in 4.2

2014-10-22 Thread Carlos Antonio da Silva
You should probably be passing in the locale you want as an argument to your mailers, and set the locale there before actually creating the mail object/rendering the view. On Wed, Oct 22, 2014 at 1:07 PM, Mohamed Wael Khobalatte wael.khobala...@gmail.com wrote: There shouldn't be any problem

Re: [Rails-core] ActionMailer deliver_later and i18n in 4.2

2014-10-22 Thread Mohamed Wael Khobalatte
Ah yes, Carlos is correct. I always explicitly pass the locale to with_locale, so I assumed you are doing the same. On Wed, Oct 22, 2014 at 5:11 PM, Carlos Antonio da Silva carlosantoniodasi...@gmail.com wrote: You should probably be passing in the locale you want as an argument to your

[Rails-core] Failed TravisCI builds because test run exceeds 50 minutes

2014-10-22 Thread Tu Hoang
I raised this issue via Github (here https://github.com/rails/rails/issues/17358) and got informed by rafaelfranca that it's better to do this via the mailing list. Sorry, Rafael; and thank you as well :-). A few https://travis-ci.org/rails/rails/builds/38633209 builds

Re: [Rails-core] Failed TravisCI builds because test run exceeds 50 minutes

2014-10-22 Thread Chad Woolley
Sounds like a great idea, just make sure it doesn't break the build locally. For bonus points make the number of parallel builds configurable. For extra bonus points, make the parallelization work locally as well as Travis. -- Chad On Wed, Oct 22, 2014 at 9:22 AM, Tu Hoang saidre...@gmail.com

Re: [Rails-core] Failed TravisCI builds because test run exceeds 50 minutes

2014-10-22 Thread Rafael Mendonça França
In fact we already have parallelization, but it doesn’t work on Travis because we only have one core in our machines. To run railties tests in parallel you only need to specify the CORES environment variable. CORES=4 rake test I don’t think it is worth to split this build, it doesn’t fail

[Rails-core] Suggestions for Rails Enums -- detailed writeup

2014-10-22 Thread Justin Gordon
I wrote up this detailed description of the issues I'm having with Rails Enums: Enums and Queries in Rails 4.1, and Understanding Ruby http://www.railsonmaui.com/blog/2014/10/22/enums-and-queries-in-rails-4-dot-1/ At the bottom of the article, I post my recommendation: Recommendations to the