[Rails-core] Fix request.ip and request.remote_ip inconsistencies

2014-05-19 Thread Aaron Suggs
::Request#ip`. Feedback welcome! Aaron Suggs Operations Engineer, Kickstarter -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr

[Rails-core] Feedback for PR 13008: SQL sanitization in AR::QueryMethods#order

2013-12-08 Thread Aaron Suggs
I'm looking for feedback on PR #13008: Support SQL sanitization in AR::QueryMethods#order https://github.com/rails/rails/pull/13008. Currently, you can't do SQL sanitized interpolation like `['?', param]` with AREL `order` clauses. This sanitization would be useful for complex order clauses,