Currently the asset_host is set by a proc or an object for all controllers 
of the site. 

I think one could easily make this more flexible by allowing the controller 
to override the asset_host. As the asset host is currently only a 
configuration it is already available through the controller therefore one 
could change the 
compute_asset_host<https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/asset_url_helper.rb#L192>
 method 
to use the controller's asset_host by changing the line "host = 
config.asset_host if defined? config.asset_host" to "host = 
controller.asset_host if defined? controller.asset_host".

I am not sure if this change has no side effects (beside if someone defined 
an asset_host method on his controller which does something else) but as 
far as I can tell the asset host should still work as expected.

While this feature would be very useful for my special use case (my 
application has no access to the cdn the assets are hosted on and therefore 
we have quite a lot of switches when we can and can't use the cdn), it may 
not be for others. What do you guys think is this a change worth investing 
some time into and putting together a pull request?

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to