Re: [Rails-core] [ActiveRecord] feature request - QueryMethods method that augments the select clause.

2019-11-15 Thread Daniel Heath
Sorry, I was being unclear there. I think it might be sensible to convert .select(“users.*, sum(baz))” to the expanded form on the ruby side using the column cache. That way you get the functionality you want without introducing a new API. Thanks, Daniel Heath > On 16 Nov 2019, at 12:43

Re: [Rails-core] [Rails 6] Bug in caching key generation when working with active record collections?

2019-10-30 Thread Daniel Heath
I think it’s worth considering implementing per database, as the major ones all have something that’ll work and the keys don’t need to be stable across different data store implementations. Thanks, Daniel Heath > On 31 Oct 2019, at 6:17 am, Aaron Lipman wrote: > >  > Thanks

Re: [Rails-core] [Rails 6] Bug in caching key generation when working with active record collections?

2019-10-28 Thread Daniel Heath
The full collection could be millions of records. Fetching the ids to hash might not be an option either, unless they can be hashed on the database side. Thanks, Daniel Heath > On 29 Oct 2019, at 4:22 am, Aaron Lipman wrote: > >  > Hi Marc & Richard, > > I'd categori

Re: [Rails-core] [Feature] Zero argument for pluralize text helper

2019-10-02 Thread Daniel Heath
This doesn’t work for many languages, and only works for English if you format your copy to match (ex: “you don’t have any bookmarks” vs “you have no bookmarks”) Thanks, Daniel Heath > On 3 Oct 2019, at 5:49 am, Marc Köhlbrugge wrote: > >  > I wonder how many Rails apps use i1

[Rails-core] Allow stylesheet_packs_with_chunks_tag to fail silently if a chunk has JS but no CSS

2019-08-02 Thread Daniel Heath
Currently, if you call stylesheet_packs_with_chunks_tag and pass a chunk with no CSS, you get an exception. This is generally a good thing, since it stops you from misspelling your entry point names. However, in the specific case of entry points that have JS but no CSS, I think it makes more

Re: [Rails-core] [ActiveRecord] [Feature Proposal] Common Table Expression support

2019-01-15 Thread Daniel Heath
not working on CTEs would notice that this change exists. Thanks, Daniel Heath On Wed, Jan 16, 2019, at 11:58 AM, Rafael Mendonça França wrote: > Cool! I think the hard work is already done. But I still find it hard > to justify this in the framework. It is a feature that is out of Rails > for

[Rails-core] [ActiveRecord] [Feature Proposal] Common Table Expression support

2019-01-15 Thread Daniel Heath
ere(id: {post_ids: :post_id}) Would a patch supporting this syntax be accepted? Thanks, Daniel Heath -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from i