Re: [Rails-core] Versioning of Views; Our Approach

2012-09-20 Thread Piotr Sarnacki
Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en.

Re: [Rails-core] Proposal for a new ActiveModel::Errors structure

2012-09-25 Thread Piotr Sarnacki
Szymon > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/rubyonrails-core/-/FSdTDr6g6CwJ. > To post to this group, send email

Re: [Rails-core] Filter redirect logs

2012-10-01 Thread Piotr Sarnacki
groups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > -- Piotr Sarnacki http://piotrsarnacki.com -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post t

Re: [Rails-core] define_methods functionality

2012-10-04 Thread Piotr Sarnacki
oogle Groups > "Ruby on Rails: Core" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/rubyonrails-core/-/5DmvGbSVkYwJ. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to >

Re: [Rails-core] Customizable parameter name in routing.

2012-10-08 Thread Piotr Sarnacki
to readability, it's much better to say params[:slug] or params[:name] if that's what it is. I would like to have the ability to set the name of that param. Anyone from core team cares enough to accept/reject this idea? -- Piotr Sarnacki http://piotrsarnacki.com -- You received this mes

Re: [Rails-core] Is Rails 4 going to render JSON as a stream by default?

2012-11-01 Thread Piotr Sarnacki
group, send email to > rubyonrails-core@googlegroups.**com > . > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@**googlegroups.com > . > For more options, visit this group at http://groups.google.com/** > group/rubyonrails-core?hl=en<http

Re: [Rails-core] Is Rails 4 going to render JSON as a stream by default?

2012-11-01 Thread Piotr Sarnacki
and you can choose any library you want to render JSON with rails. If you need this kind of feature, you should rather talk with maintainers of one of the JSON libraries out there. -- Piotr Sarnacki http://piotrsarnacki.com -- You received this message because you are subscribed to the Google Group

Re: [Rails-core] Re: false.present? is false. Is it desired behaviour?

2013-06-26 Thread Piotr Sarnacki
an > email to rubyonrails-core+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- P

Re: [Rails-core] Decoupling of ActionPack

2013-07-10 Thread Piotr Sarnacki
is group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- Piotr Sarnacki http://piotrsarnacki.com -- You received this message

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
On Oct 18, 7:13 pm, Joe Fiorini wrote: > ActionDispatch::Assertions::RoutingAssertions (https://gist.github.com/ > a57e3addfe0aa3857e12). Does anyone else see value for this in core? Is > the code okay? I personally would not use that. You're just adding line to tests that ensures that you adde

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
I don't think that you need to do such unit tests, without mounting an engine you will not be able to reach engine's routes, so tests will fail anyway. > Yeah i have spent the last week trying to mount an app Remember that this is still an edge version and some things can (and probably will) chan

[Rails-core] Re: Testing Mounted Engines

2010-11-16 Thread Piotr Sarnacki
Damn, google groups ate my post, so again ;) Joe Fiorini: I don't like that kind of tests. You just add a line in tests that ensures that you added a line in routes. Better way to do that would be to check if engine can be properly rendered inside application. But I'm not in core and it's only my

[Rails-core] Re: 'rails new' does not work

2010-12-12 Thread Piotr Sarnacki
I think that Lunks is right, it's something with your config: http://pastie.org/1370927 On Dec 12, 6:38 pm, Lunks wrote: > You might wanna check if you have a partial rails install from your OS (i.e. > apt). Try removing everything and then installing the rails gem strictly > through rubygems. >

[Rails-core] Re: Are plugins still necessary in Rails3?

2010-12-14 Thread Piotr Sarnacki
Hey, Indeed, I started work on that, mainly because of mountable applications (engines), but it can be used to generate any kind of rails extension. It's based on http://github.com/josevalim/enginex and the key difference in comparison to older plugins generator is that dummy application is genera

[Rails-core] Re: Replacement for AV::TestCase

2011-01-12 Thread Piotr Sarnacki
+1 from me on that. I also added my comment. On Jan 11, 10:11 am, Nick Sutterer wrote: > Aaron- thanks! I added comments to answer your questions. > > On 10 Jan., 23:50, Aaron Patterson wrote: > > > > > > > > > On Mon, Jan 10, 2011 at 01:32:11PM -0800, Nick Sutterer wrote: > > > Hey friends, > >

[Rails-core] Re: class_attribute is too dangerous, here's an alternative

2011-01-21 Thread Piotr Sarnacki
I like Nick's implementation, not everyone know or remembers that modyfing object like Hash or Array will also change the superclass (which is clearly visible in the commit that Nick's linked - that was exactly the reason of the bug that I was fixing). I think that it would be nice to have inherit

Re: [Rails-core] Rails Engine

2012-03-15 Thread Piotr Sarnacki
he solution on this.. > > Thanks > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email

Re: [Rails-core] On handling staging servers

2012-04-13 Thread Piotr Sarnacki
I totally agree with what Josh said. When I used staging rails environment in the past it always ended up with some weird tweaks that I had to do. If you're running staging server on production environment all you need to do is to remember to keep configuration outside the code as Josh mentioned

[Rails-core] Re: Updating rails 2.3 plugins database

2012-05-02 Thread Piotr Sarnacki
Please specify which plugin have you used for engines migrations in 2.3 or describe your situation better - how does your migration files look like? On Wednesday, May 2, 2012 11:18:29 AM UTC-7, Vanuan wrote: > > As I discovered on github https://github.com/rails/rails/issues/5424 > rails engines

Re: [Rails-core] Re: Updating rails 2.3 plugins database

2012-05-03 Thread Piotr Sarnacki
to your app they should be skipped on next migrations:install task. > > On Thursday, 3 May 2012 05:59:56 UTC+3, Piotr Sarnacki wrote: >> >> Please specify which plugin have you used for engines migrations in 2.3 >> or describe your situation better - how does your migration fi

Re: [Rails-core] Loading delegates in Rails View Helpers on to instance objects

2012-05-03 Thread Piotr Sarnacki
To view this discussion on the web visit > https://groups.google.com/d/msg/rubyonrails-core/-/aULxrpmyo5IJ. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscr...@googlegroups.com. > For mor

Re: [Rails-core] Mountable Engines and ApplicationControllers

2012-05-08 Thread Piotr Sarnacki
On Fri, May 4, 2012 at 11:24 PM, Scott Johnson <7.scot...@gmail.com> wrote: > So my questions for the group are, does this seem like a reasonable > solution or am I missing something like, this is why ActionController::Base > exists and why don't you just open class it in the load path for the sam

Re: [Rails-core] loading two similar Rails Engine in single app

2012-05-28 Thread Piotr Sarnacki
ail to > rubyonrails-core+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core&q

Re: [Rails-core] Re: loading two similar Rails Engine in single app

2012-05-28 Thread Piotr Sarnacki
ick reply... > > I have not used isolate_namespace concept... > > controller also not loaded like models... > > cau u plz tell me any other solution > > On May 28, 3:34 pm, Piotr Sarnacki wrote: > > Short answer is: namespace your models, for example you should ha

Re: [Rails-core] Nested Resource Route Helpers

2012-06-05 Thread Piotr Sarnacki
gt;> . >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> Groups "Ruby on Rails: Core" group. >>> > To post to this group, send email to rubyonrails-core@googlegroups.** >>> com .

Re: [Rails-core] Pagination for Static Pages

2012-06-15 Thread Piotr Sarnacki
byonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > -- Piotr Sarnacki http://piotrsarnacki.com -- You rec

Re: [Rails-core] Transitive engine dependencies

2012-07-04 Thread Piotr Sarnacki
> "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/gro