In the case of failed builds because of exceeding runtime, it means there
are still tests left not run. Do we still merge the PR? What if one of the
leftover tests is the one related to the proposed code change?
On Thursday, October 23, 2014 1:18:51 AM UTC+7, Rafael Mendonça França
wrote:
In
Yes we still merge the pull request. We don't usually wait the build finish
to merge a pull request. If it is related with the code, it will fail
locally for someone.
Just to be clear we do use the CI but it is not a blocker to merge
something.
On Oct 23, 2014 9:39 AM, Tu Hoang
I raised this issue via Github (here
https://github.com/rails/rails/issues/17358) and got informed by
rafaelfranca that it's better to do this via the mailing list. Sorry,
Rafael; and thank you as well :-).
A few https://travis-ci.org/rails/rails/builds/38633209 builds
Sounds like a great idea, just make sure it doesn't break the build locally.
For bonus points make the number of parallel builds configurable.
For extra bonus points, make the parallelization work locally as well as
Travis.
-- Chad
On Wed, Oct 22, 2014 at 9:22 AM, Tu Hoang saidre...@gmail.com
In fact we already have parallelization, but it doesn’t work on Travis
because we only have one core in our machines.
To run railties tests in parallel you only need to specify the CORES
environment variable.
CORES=4 rake test
I don’t think it is worth to split this build, it doesn’t fail
