Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-26 Thread Rodrigo Rosenfeld Rosas
Why not just break unless user inside the block? Not sure if it should be break, next, or return in that context but you get the idea. I always prefer earlier returns for such case. Em 25/01/2013 19:17, Ngan nganp...@gmail.com escreveu: I originally brought this up in:

[Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Ngan
I originally brought this up in: https://github.com/rails/rails/issues/9067 Rails paved the way for Object#tap and Object#try...I'd like to propose Object#tap_if and its counterpart,Object#tap_unless. I've been following 37signals conventions of tapping variables in the views: %

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Andrew Kaspick
What's wrong with... % if user = account.owner % ... % end % or % if users = account.users.presence % ... % end % ? On Fri, Jan 25, 2013 at 3:17 PM, Ngan nganp...@gmail.com wrote: I originally brought this up in: https://github.com/rails/rails/issues/9067 Rails paved the way for

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Godfrey Chan
Object#try takes a block. It'll probably take care of most simple cases for you: % account.owner.try do |user| % !-- This is shown only if account.owner is not nil? -- % end % On Fri, Jan 25, 2013 at 1:17 PM, Ngan nganp...@gmail.com wrote: I originally brought this up in:

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Michael Breen
On Jan 25, 2013, at 5:02 PM, Andrew Kaspick wrote: What's wrong with... % if user = account.owner % ... % end % or % if users = account.users.presence % ... % end % ? If running with warnings enabled ruby will raise a warning on these. Best. Mike -- You received this message

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Godfrey Chan
Actually, on second thought, this would do exactly what you wanted, and It's Just Ruby (tm): % account.users.any? account.users.tap do |users| % # ... % end % On Fri, Jan 25, 2013 at 2:09 PM, Ngan nganp...@gmail.com wrote: Thank you Godfrey! This does solve 99% of my cases! @Andrew

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Ngan
The problem (I think) with that is that #users could be an expensive call you only wish to make once. And I don't want to get into memoizing... % account.expensive_call_for_users.any? account.expensive_call_for_users.tap ... % On Friday, January 25, 2013 2:11:18 PM UTC-8, Godfrey Chan

Re: [Rails-core] Object#tap_if and Object#tap_unless

2013-01-25 Thread Richard Schneeman
% (users = account.users).any? users.tap do |users| % Less pretty, still works. -- Richard Schneeman http://heroku.com @schneems (http://twitter.com/schneems) On Friday, January 25, 2013 at 4:13 PM, Ngan wrote: The problem (I think) with that is that #users could be an expensive call