It could be set as an alias for #travel_back.
>From a semantic perspective #unfreeze_time would read like an opposite to
#freeze_time, just like #travel_back is an opposite of #travel_to
It's a relatively small change that could improve the user experience of
using #freeze_time
--
You receive
I think it makes sense. For the code to read well, both verbs have to match.
Would you like to contribute a patch?
--
You received this message because you are subscribed to the Google Groups "Ruby
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an
Would this be easier if freezing time took place in a block, and any
unfrozen time followed the closure of the block? Then we wouldn't need a
separate method. I think this was the recommended practice with Timecop.
On Sun, Sep 2, 2018, 6:18 PM Xavier Noria wrote:
> I think it makes sense. For th
On Mon, Sep 3, 2018 at 1:28 AM, Geoff Harcourt
wrote:
Would this be easier if freezing time took place in a block, and any
> unfrozen time followed the closure of the block? Then we wouldn't need a
> separate method. I think this was the recommended practice with Timecop.
>
Right. Generally you'
Yes I'd love to contribute a patch for this.
I posted it as an issue in the rails repo and they directed me
here. https://github.com/rails/rails/issues/33771#issuecomment-417848091
Could you advise on your normal process for this? I've contributed a rails
before, but that was for an issue someo
On Mon, Sep 3, 2018 at 11:16 PM, 'Ryan' via Ruby on Rails: Core <
rubyonrails-core@googlegroups.com> wrote:
Yes I'd love to contribute a patch for this.
>
> I posted it as an issue in the rails repo and they directed me here.
> https://github.com/rails/rails/issues/33771#issuecomment-417848091
>
>
Right, I see the process is to fork rails and and make a PR with the patch.
Thanks for the tips, and for the offer of further support.
On Tuesday, 4 September 2018 15:12:54 UTC+1, Xavier Noria wrote:
>
> On Mon, Sep 3, 2018 at 11:16 PM, 'Ryan' via Ruby on Rails: Core <
> rubyonra...@googlegroups
I have now submitted a PR with this
change https://github.com/rails/rails/pull/33813
On Tuesday, 4 September 2018 18:47:37 UTC+1, Ryan wrote:
>
> Right, I see the process is to fork rails and and make a PR with the
> patch. Thanks for the tips, and for the offer of further support.
>
> On Tuesd
