[Rails-core] Re: Avoiding clone in AR::Base#attributes

2008-02-11 Thread Michael Koziarski
> As nobody reports any breakage, it seems natural to implement the same > behaviour to attributes_before_type_cast as well. > > Here is the patch to avoid cloning in attributes_before_type_cast: > http://dev.rubyonrails.org/ticket/11077 Agreed, applied, thanks! -- Cheers Koz --~--~-~

[Rails-core] Re: Avoiding clone in AR::Base#attributes

2008-02-11 Thread Juanjo Bazán
As nobody reports any breakage, it seems natural to implement the same behaviour to attributes_before_type_cast as well. Here is the patch to avoid cloning in attributes_before_type_cast: http://dev.rubyonrails.org/ticket/11077 Cheers, Juanjo --~--~-~--~~~---~--~~

[Rails-core] Re: Avoiding clone in AR::Base#attributes

2008-02-08 Thread Michael Koziarski
> Anyone have any objections to this new behaviour? I've applied the patch to edge, so if you notice any breakage shout out in this thread. -- Cheers Koz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on

[Rails-core] Re: Avoiding clone in AR::Base#attributes

2008-02-08 Thread Michael Koziarski
> Hi, > I've changed the ActiveRecord::Base#attributes method to avoid cloning of > objects and increase apps performance. > Here is the patch: http://dev.rubyonrails.org/ticket/11047 > This sure speeds up the method avoiding Kernel#clone calls, but I don't > know if there is any special case whe