I agree with Rafael. I don't see an obvious benefit over `builder.object`. 
I think block arguments should not be used for optional data and in most 
cases you don't need the `object`.

Am Freitag, 26. Oktober 2012 01:33:14 UTC+2 schrieb glaszig:
>
> hello everybody.
>
> i think it'd be very convenient to have the builder#object as an optional 
> second parameter in the block for fields_for, e.g.:
>
> fields_for(:comments) do |builder, object|
>   # builder.object === object
> end
>
> my proposal in code:
>
> https://github.com/glaszig/rails/commit/f22095f0ac120852fff7efc61b6bdf7401b39ad5
>
> before i request a pull - what do you think?
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/rubyonrails-core/-/4OknwHMjJ5wJ.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to 
rubyonrails-core+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.

Reply via email to