[Rails-core] Re: Plugin migrations - simplest approach

2009-03-31 Thread Sven Fuchs
James, thanks a ton for putting so much work into this. Looking at the long time this has been discussed and the number of attempts to solve it this seems to be something like the holy grail of engine plugins. I've read your blog post but I don't quite get a few problems that you point

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-31 Thread James Adam
Hi Sven, Thanks for taking the time to read my article and write your response :) On Mar 31, 10:52 am, Sven Fuchs svenfu...@artweb-design.de wrote: I've read your blog post but I don't quite get a few problems that you   point at. In solution #1 you say that Next to run is the application's

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-15 Thread James Adam
On Mar 15, 1:40 am, David Masover d...@3mix.com wrote: At the risk of bikeshedding, I'd rather not have duplicate, semi-generated code cluttering up that directory, and likely getting checked in to version control. It was bad enough with sass... A compromise might be to use symlinks instead,

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-15 Thread David Masover
On Sun, Mar 15, 2009 at 7:17 AM, James Adam ja...@lazyatom.com wrote: On Mar 15, 1:40 am, David Masover d...@3mix.com wrote: At the risk of bikeshedding, I'd rather not have duplicate, semi-generated code cluttering up that directory, and likely getting checked in to version control. It

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-15 Thread James Adam
On Mar 15, 7:35 pm, David Masover d...@3mix.com wrote: On Sun, Mar 15, 2009 at 7:17 AM, James Adam ja...@lazyatom.com wrote: I'd invite you to look athttp://interblah.net/plugin-migrations for a more in-depth 'think-through' of why this is important, but do let me know if you're still not

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-14 Thread David Masover
On Thu, Mar 12, 2009 at 12:36 PM, Tekin Suleyman te...@tekin.co.uk wrote: On 12 Mar 2009, at 17:01, Chad Woolley wrote: On Thu, Mar 12, 2009 at 9:10 AM, Tekin Suleyman te...@tekin.co.uk wrote: This looks good to me, much neater than having separate tables or extra columns to maintain

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-12 Thread James Adam
On Mar 12, 1:38 am, Josh Susser j...@hasmanythrough.com wrote: Desert creates a parallel table for plugin migrations:   plugin_schema_migrations.  It's like the app's schema_migrations   table, but each row has both a version and a plugin name.  Migrations   in plugins are accessed by putting

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-12 Thread Tekin Suleyman
On 11 Mar 2009, at 23:04, James Adam wrote: I've attached what I believe to be the simplest, least-intrusive implementation I can think of to the ticket - http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2058-rake-tasks-for-run-engine-migrations#ticket-2058-22 Please take

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-12 Thread Chad Woolley
On Thu, Mar 12, 2009 at 9:10 AM, Tekin Suleyman te...@tekin.co.uk wrote: This looks good to me, much neater than having separate tables or extra columns to maintain migrations from plugins.I think it's perfectly reasonable to expect a user of a plugin to copy the migrations that creates the

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-12 Thread Tekin Suleyman
On 12 Mar 2009, at 17:01, Chad Woolley wrote: On Thu, Mar 12, 2009 at 9:10 AM, Tekin Suleyman te...@tekin.co.uk wrote: This looks good to me, much neater than having separate tables or extra columns to maintain migrations from plugins.I think it's perfectly reasonable to expect a user

[Rails-core] Re: Plugin migrations - simplest approach

2009-03-12 Thread James Adam
On Mar 12, 5:01 pm, Chad Woolley thewoolley...@gmail.com wrote: Unnecessarily copying a file from a plugin seems wrong.  Referencing plugin migrations from your app (as Desert does) seems right. Spiritually, I prefer referencing too. It just requires a mode significant change to the way