Re: [Rails-core] Re: Possible bug with chained where methods on 3.0.4

2011-02-23 Thread Robert Pankowecki
This is fixed in https://github.com/rails/rails/commit/41c35abed778a7a03e7a9c14009321cd6bc11c26 and released in v3.0.5.rc1 right ? Shall we update the ticket https://rails.lighthouseapp.com/projects/8994/tickets/6188-model-name-for-default-submit-button-value-should-be-titleized and make sure it

Re: [Rails-core] Re: Possible bug with chained where methods on 3.0.4

2011-02-23 Thread Aaron Patterson
On Thu, Feb 24, 2011 at 12:21:03AM +0100, Robert Pankowecki wrote: This is fixed in https://github.com/rails/rails/commit/41c35abed778a7a03e7a9c14009321cd6bc11c26 and released in v3.0.5.rc1 right ? Shall we update the ticket and make sure it works the same way in master ? It's fixed in

[Rails-core] Re: Possible bug with chained where methods on 3.0.4

2011-02-16 Thread Ernie Miller
On Feb 16, 7:24 am, Ernie Miller er...@metautonomo.us wrote: Sound arguments. I didn't implement collapse_wheres, just in case a witch hunt starts. I was just the first person awake this morning to pose the answer. :) The change probably shouldn't have made it into a point release, but I

[Rails-core] Re: Possible bug with chained where methods on 3.0.4

2011-02-16 Thread Brian Morearty
Sound arguments. I didn't implement collapse_wheres, just in case a witch hunt starts. I was just the first person awake this morning to pose the answer. :) Understood. :-) With this commit, now neither callers nor callees have any idea what where(:hash = arguments) will result in - whether

[Rails-core] Re: Possible bug with chained where methods on 3.0.4

2011-02-16 Thread Akira Matsuda
+1 for reverting this ASAP. The reason was already very clearly explained in the 4th post of this thread. I believe, this is the most important point. On Wed, Feb 16, 2011 at 8:37 PM, Will Bryant will.bry...@gmail.com wrote: And to do it at all breaks the relational algebra idea badly. Now, let