[Rails-core] Re: Tests and the Rails 3 effort

2009-04-17 Thread Chad Woolley
On Thu, Apr 16, 2009 at 9:03 AM, Yehuda Katz wyc...@gmail.com wrote: 2.3 application. We're obviously not done yet (by any stretch), but if you go through the new_base specs, I think you'll be pleased with our thoroughness. I'd be happy to answer any other questions you might have. I'd like

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-17 Thread Chad Woolley
On Fri, Apr 17, 2009 at 1:09 AM, Chad Woolley thewoolley...@gmail.com wrote: I'd like to see the CI build kept green through these efforts: http://ci.rubyonrails.org/builds/rails Ah, it is green again. Nice :) -- Chad --~--~-~--~~~---~--~~ You received this

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Eloy Duran
Hi, It's probably no surprise that I agree with this email. What however comes as a surprise to me is that nobody responded yet. Are there no other people on this list that have concerns/opinions about this issue? Eloy On Apr 15, 2009, at 9:37 AM, Manfred Stienstra wrote: Hi Yehuda and

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Manfred Stienstra
On Apr 16, 2009, at 12:39 PM, Andrew White wrote: Well, I'm guessing the thinking is that the current tests should cover most of the changes. Sure, but I see new code without tests in the commits. The problem with that is that a lot of the current tests are tied to implementation specifics

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Andrew White
On 16 Apr 2009, at 13:06, Manfred Stienstra wrote: Sure, but I see new code without tests in the commits. On a cursory look I don't see anything that intends to change existing behaviour - can you point something out. I would expect a rewrite to happen in a separate branch and be merged

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Manfred Stienstra
On Apr 16, 2009, at 2:47 PM, Andrew White wrote: It'd be nice to know who is exactly working on what - for example is your work on refactoring AR scopes an 'official' project or just something you've taken upon yourself? I sort of agreed with Pratik that I would work on it. I don't know

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Yehuda Katz
My apologies for the delay in responding. I'm a bit new to all of this. I'll try to explain what's going on exactly. There are basically two kinds of changes that Carl and I have been making: 1) Refactoring of existing code. For the most part, the existing tests have held up reasonably well.

[Rails-core] Re: Tests and the Rails 3 effort

2009-04-16 Thread Mike Gunderloy
In addition to Yehuda's comments, I would add that there are several major initiatives planned for the Rails 3 timeframe: (1) Existing tests should be upgraded to be more thorough as the code is touched. There are various spots in the Rails 2.x codebase where tests could be improved,