[Rails-core] Re: rails.js etc.

2010-07-06 Thread michael.hasenst...@googlemail.com
> We would probably never work in the same company, then. :) Indeed. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-c...@googlegroups.com. To unsubscribe from this group, send email to r

Re: [Rails-core] Re: rails.js etc.

2010-07-06 Thread Mislav Marohnić
On Tue, Jul 6, 2010 at 02:45, Mislav Marohnić wrote: > > I've somehow lost commit access to prototype-ujs. Josh Peek, if you're > reading this, can you restore that for me? > Aaand my commit access is back, and the fixes are pushed: http://github.com/rails/prototype-ujs/compare/35b4551...c00e908

Re: [Rails-core] Re: rails.js etc.

2010-07-05 Thread Mislav Marohnić
Fully support Nicolás about this not being a place for religious discussions about JavaScript. Michael, did I understand correctly that what you said below in 2 simple sentences were the only things actually *wrong* with the script? On Sun, Jul 4, 2010 at 14:09, michael.hasenst...@googlemail.com <

Re: [Rails-core] Re: rails.js etc.

2010-07-05 Thread Nicolás Sanguinetti
Aand this is getting a bit off-topic. If you guys want to fight, that's fine, I'll get some popcorn, a boxing ring, and a bell to signal the rounds. But it's probably better not to do it on this list ;) Cheers On Mon, Jul 5, 2010 at 1:22 PM, Rodrigo Rosenfeld Rosas wrote: > Em 05-07-2010

Re: [Rails-core] Re: rails.js etc.

2010-07-05 Thread Rodrigo Rosenfeld Rosas
Em 05-07-2010 04:39, michael.hasenst...@googlemail.com escreveu: Hi, This could be written using no variable as: $('').appendTo('body') I think this is just an example of a smart refactoring. No it is not. Or even as: $('').text('content').a

Re: [Rails-core] Re: rails.js etc.

2010-07-05 Thread Rodrigo Rosenfeld Rosas
Em 05-07-2010 04:30, michael.hasenst...@googlemail.com escreveu: Hi, On Jul 4, 10:20 pm, Rodrigo Rosenfeld Rosas wrote: ... As I said, once you know the reasoning you can follow his suggestions. It just happens that we don't use minifiers at our company since Excuse me, but here

[Rails-core] Re: rails.js etc.

2010-07-05 Thread michael.hasenst...@googlemail.com
Hi, > >> This could be written using no variable as: > >> $('').appendTo('body') > > > I think this is just an example of a smart refactoring. No it is not. > >> Or even as: > > >> $('').text('content').appendTo('body').click(function(){alert('clicked: > >> ' + $(this).text())}) There is a re

[Rails-core] Re: rails.js etc.

2010-07-05 Thread michael.hasenst...@googlemail.com
Hi, On Jul 4, 10:20 pm, Rodrigo Rosenfeld Rosas wrote: > > Crockford's rules are backed by pretty strong logic. I'd recommend > > reading "The Good Parts" ... he has some compelling arguments. > > I'll take a look when I have some free time. http://developer.yahoo.com/yui/theater/ It is very, v

Re: [Rails-core] Re: rails.js etc.

2010-07-04 Thread Rodrigo Rosenfeld Rosas
Em 04-07-2010 16:34, Paul Campbell escreveu: Michael, I recently read Crockford's book "The Good Parts" and I absolutely share your opinions about bowing down to the master! That said, I think that his arguments simply make a lot of sense more than anything else, and it's useful to have a prescr

Re: [Rails-core] Re: rails.js etc.

2010-07-04 Thread Paul Campbell
Michael, I recently read Crockford's book "The Good Parts" and I absolutely share your opinions about bowing down to the master! That said, I think that his arguments simply make a lot of sense more than anything else, and it's useful to have a prescribed style at least to _start_ with, rather tha

Re: [Rails-core] Re: rails.js etc.

2010-07-04 Thread Rodrigo Rosenfeld Rosas
Hi Michael, I'm so sorry for the confusion that I made! :) I don't know why, but I thought you were talking about the jQuery rails.js driver. I've just seen you are talking about the default Prototype driver when you talked about the handleMethod function, which I didn't find in the jQuery dri

[Rails-core] Re: rails.js etc.

2010-07-04 Thread michael.hasenst...@googlemail.com
Hi, Yes, automatic semi. insertion is a feature - and a most horrible one! I am unwilling to discuss it though: I must admit I completely and uncritically submit to "higher authority" and Javascript-god Douglas Crockford as far as code writing rules are concerned, since as far as I'm concerned th

Re: [Rails-core] Re: rails.js etc.

2010-07-02 Thread Paul Campbell
Michael, I'd say there's a good chance that if you ran rails.js through jslint.com and made the appropriate changes that they'd be accepted. I believe the UJS helpers were written in quite a short time period by a crack team in January, and I doubt anyone would complain if you were to come in and

[Rails-core] Re: rails.js etc.

2010-07-02 Thread michael.hasenst...@googlemail.com
That was not my question. On Jul 2, 12:35 pm, Ivan Nastyukhin wrote: > and what stoping u, to use yui? > > Ivan Nastyukhin -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-c...@googlegrou