Re: [Rails-core] rails.js etc.

2010-07-02 Thread Jeremy Kemper
On Fri, Jul 2, 2010 at 3:27 AM, michael.hasenst...@googlemail.com wrote: > Hi, > > Just a comment. > > I just had a brief look at rails.js (latest Rails 3 master) and > immediately noticed some really ugly errors like an accidental global > variable (no "var" statement for it) and re-declaration o

Re: [Rails-core] rails.js etc.

2010-07-02 Thread Rodrigo Rosenfeld Rosas
Michael, please take a look at ECMAScript specification, section 7.9 - "Automatic Semicolon Insertion": http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-262.pdf This is not an error but a feature. The only case where this could lead to some problem is code like this: var l =

Re: [Rails-core] rails.js etc.

2010-07-02 Thread Ivan Nastyukhin
and what stoping u, to use yui? Ivan Nastyukhin dieinz...@me.com On Jul 2, 2010, at 2:27 PM, michael.hasenst...@googlemail.com wrote: > Hi, > > Just a comment. > > I just had a brief look at rails.js (latest Rails 3 master) and > immediately noticed some really ugly errors like an acciden

[Rails-core] rails.js etc.

2010-07-02 Thread michael.hasenst...@googlemail.com
Hi, Just a comment. I just had a brief look at rails.js (latest Rails 3 master) and immediately noticed some really ugly errors like an accidental global variable (no "var" statement for it) and re-declaration of variables (more than one "var" statement for the same variable in the same function)