[Rails] Re: Action Mailer new DSL merged

2010-01-26 Thread Olek
Just letting you know we have a new DSL for Action Mailer. I think removing the magic #deliver_* and #create_* methods, and returning an actual Mail object directly by an existing method makes a lot of sense. On the other hand, I think replacing methods like #body, #subject, etc. with a hash is

Re: [Rails] Re: Action Mailer new DSL merged

2010-01-26 Thread Mikel Lindsaar
On Tue, Jan 26, 2010 at 10:29 PM, Olek olek.janiszew...@gmail.com wrote: On the other hand, I think replacing methods like #body, #subject, etc. with a hash is a missed idea, it's harder to write and read, and less clear to grasp, especially when you notice that ActiveRecord API changes in

[Rails] Re: Action Mailer new DSL merged

2010-01-25 Thread Elad Meidar
Nice work! On Jan 25, 9:29 pm, Mikel Lindsaar raasd...@gmail.com wrote: Hi all, Just letting you know we have a new DSL for Action Mailer. class Notifier ActionMailer::Base   delivers_from(sys...@example.com)   def signup_notification(recipient)     @account = recipient