Re: [Ryu-devel] [PATCH 12/32] ofproto/ofproto_v1_0_parser: make FlowMod allow meaningful default parameter

2012-04-02 Thread Simon Horman
On Mon, Apr 02, 2012 at 04:08:26PM +0900, Isaku Yamahata wrote: > Cc: Simon Horman > Signed-off-by: Isaku Yamahata Acked-by: Simon Horman -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here

Re: [Ryu-devel] [PATCH 11/32] controller, ofproto_v1_0: avoid format for argument

2012-04-02 Thread Simon Horman
On Mon, Apr 02, 2012 at 04:08:25PM +0900, Isaku Yamahata wrote: > format is defined in builtin, so it should be avoid for argument. > use flow_format instead. > > Cc: Simon Horman > Signed-off-by: Isaku Yamahata Acked-by: Simon Horman -- Simon Horman/ホーマン サイモンsi...@horms.net Horms So

Re: [Ryu-devel] [PATCH 08/32] ofproto/ofproto_v1_0_parser: improve NXTRequest initializer

2012-04-02 Thread Simon Horman
On Mon, Apr 02, 2012 at 04:08:22PM +0900, Isaku Yamahata wrote: > initialize subtype by base class, NXTRequest, instead of subclass. > > Cc: Simon Horman > Signed-off-by: Isaku Yamahata Acked-by: Simon Horman -- This

[Ryu-devel] [PATCH 25/32] ryu-manager: pass tunnels as kwargs to applications

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-manager | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/bin/ryu-manager b/bin/ryu-manager index ef8355b..2edda4c 100755 --- a/bin/ryu-manager +++ b/bin/ryu-manager @@ -32,6 +32,7 @@ from ryu.base.app_manager import AppMan

[Ryu-devel] [PATCH 30/32] bin/ryu-manager: add rest_tunnel to default applications

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-manager |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bin/ryu-manager b/bin/ryu-manager index 2edda4c..de6d4c5 100755 --- a/bin/ryu-manager +++ b/bin/ryu-manager @@ -39,6 +39,7 @@ FLAGS = gflags.FLAGS gflags.DEFINE_multistring(

[Ryu-devel] [PATCH 24/32] controller/tunnel: introduce new class that tracks infos related to tunneling

2012-04-02 Thread Isaku Yamahata
- helper functions and event generator for gre tunnel - plug events for gre tunnel app Signed-off-by: Isaku Yamahata --- ryu/controller/tunnels.py | 196 + 1 files changed, 196 insertions(+), 0 deletions(-) create mode 100644 ryu/controller/tunnels.p

[Ryu-devel] [PATCH 31/32] app/gre_tunnel: implement GRETunnel app

2012-04-02 Thread Isaku Yamahata
- race masking layer - debug app: PortSetDebug - implement GRETunnel app: app/gre_tunnel Signed-off-by: Isaku Yamahata --- ryu/app/gre_tunnel.py | 840 + 1 files changed, 840 insertions(+), 0 deletions(-) create mode 100644 ryu/app/gre_tunnel.py

[Ryu-devel] [PATCH 29/32] bin/ryu-client: support gre tunnel client

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-client | 43 +++ 1 files changed, 31 insertions(+), 12 deletions(-) diff --git a/bin/ryu-client b/bin/ryu-client index 0b3e418..8607f8c 100755 --- a/bin/ryu-client +++ b/bin/ryu-client @@ -18,6 +18,7 @@ import s

[Ryu-devel] [PATCH 28/32] app/client: add GRE tunnel client

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index 33e280a..3003616 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@ -110,3

[Ryu-devel] [PATCH 11/32] controller, ofproto_v1_0: avoid format for argument

2012-04-02 Thread Isaku Yamahata
format is defined in builtin, so it should be avoid for argument. use flow_format instead. Cc: Simon Horman Signed-off-by: Isaku Yamahata --- ryu/controller/controller.py | 12 ++-- ryu/ofproto/ofproto_v1_0_parser.py |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-)

[Ryu-devel] [PATCH 12/32] ofproto/ofproto_v1_0_parser: make FlowMod allow meaningful default parameter

2012-04-02 Thread Isaku Yamahata
Cc: Simon Horman Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0_parser.py | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index a13f972..4563807 100644 --- a/ryu/ofproto/o

[Ryu-devel] [PATCH 08/32] ofproto/ofproto_v1_0_parser: improve NXTRequest initializer

2012-04-02 Thread Isaku Yamahata
initialize subtype by base class, NXTRequest, instead of subclass. Cc: Simon Horman Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0_parser.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1

[Ryu-devel] [PATCH 20/32] controller/network: factor out network.py and add event generator for gre tunnel and helper methods

2012-04-02 Thread Isaku Yamahata
- Factor out from network.py the logic to track network and dpid - introduce class Port to allow other info Later we'll track mac address associated to port. So allow intermediate layer to contain infos related to Port. - make network track mac address associated to port - generate events Sign

[Ryu-devel] [PATCH 32/32] bin/ryu-manager: make GRETunnel default app, remove SimpleIsolation

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-manager |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/bin/ryu-manager b/bin/ryu-manager index de6d4c5..3d4f12c 100755 --- a/bin/ryu-manager +++ b/bin/ryu-manager @@ -37,7 +37,10 @@ from ryu.controller import tunnels FLAGS

[Ryu-devel] [PATCH 09/32] ofproto/ofproto_v1_0_parser: serializer for nxt_flow_mod_table_id

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0_parser.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index da03508..c26f642 100644 --- a/ryu/ofproto/ofproto_v1_0_parser.py

[Ryu-devel] [PATCH 19/32] dpset: add port{add, delete, modify} event for convenience and helper functions

2012-04-02 Thread Isaku Yamahata
For discovery, it's interested only in datapath/port appearance/disappearance. With this, discovery app would not have to handle OFP events directly. Signed-off-by: Isaku Yamahata --- ryu/controller/dpset.py | 79 -- 1 files changed, 75 insertions(+)

[Ryu-devel] [PATCH 18/32] app/rest_nw_id: add type for vport-gre and RESERVED_NETWORK_IDS

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/rest_nw_id.py |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ryu/app/rest_nw_id.py b/ryu/app/rest_nw_id.py index 5422c81..b39e104 100644 --- a/ryu/app/rest_nw_id.py +++ b/ryu/app/rest_nw_id.py @@ -1,5 +1,5 @@ # Copyright

[Ryu-devel] [PATCH 27/32] app/client: add helper function to ignore NOT_FOUND, 404

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index eec9d0e..33e280a 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@ -17,6 +17,19 @@ import httplib import u

[Ryu-devel] [PATCH 26/32] app/rest_tunnel: REST API for tunnel

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/rest_tunnel.py | 230 1 files changed, 230 insertions(+), 0 deletions(-) create mode 100644 ryu/app/rest_tunnel.py diff --git a/ryu/app/rest_tunnel.py b/ryu/app/rest_tunnel.py new file mode 100644 index

[Ryu-devel] [PATCH 23/32] bin/ryu-client: support mac address tracking

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-client |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/bin/ryu-client b/bin/ryu-client index e91ed73..0b3e418 100755 --- a/bin/ryu-client +++ b/bin/ryu-client @@ -41,7 +41,11 @@ def client_test(): 'list_ports': lambd

[Ryu-devel] [PATCH 22/32] app/client: add mac support

2012-04-02 Thread Isaku Yamahata
- fix path to 'networks' - list_macs() must return string object, not implicit None Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index 873706f..eec

[Ryu-devel] [PATCH 03/32] app/wsapi/WSPathArbitraryString: wrong indent

2012-04-02 Thread Isaku Yamahata
WSPathArbitraryString.__str__ method should be instance method. Signed-off-by: Isaku Yamahata --- ryu/app/wsapi.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/app/wsapi.py b/ryu/app/wsapi.py index 6205565..2b6e7c3 100644 --- a/ryu/app/wsapi.py +++ b/ryu/app/ws

[Ryu-devel] [PATCH 06/32] ryu/app/client: factor out rest client code

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 53 +++-- 1 files changed, 31 insertions(+), 22 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index c2c02a4..873706f 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@

[Ryu-devel] [PATCH 17/32] ryu/exception: introduce more exception for later user

2012-04-02 Thread Isaku Yamahata
MacAddressAlreadyExists and MacAddressNotFound Signed-off-by: Isaku Yamahata --- ryu/exception.py | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/ryu/exception.py b/ryu/exception.py index f226960..749c884 100644 --- a/ryu/exception.py +++ b/ryu/exception

[Ryu-devel] [PATCH 10/32] ofproto/ofproto_v1_0_parser: serializer for NXActionResbumit

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0_parser.py | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index c26f642..72631da 100644 --- a/ryu/ofproto/ofproto

[Ryu-devel] [PATCH 15/32] controller/controller: make send_flow_mod() allow default value for priority

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/controller/controller.py |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py index 1787f3d..f425833 100644 --- a/ryu/controller/controller.py +++ b/ryu/controller/controller.p

[Ryu-devel] [PATCH 13/32] ofproto/ofproto_v1_0_parser: flowmod default parameter

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0_parser.py | 19 ++- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index 4563807..067d28a 100644 --- a/ryu/ofproto/ofproto_v1_0_pa

[Ryu-devel] [PATCH 14/32] app: use symbol instead of 32678 for default priority

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/cbench.py |4 ++-- ryu/app/simple_isolation.py | 11 +++ ryu/app/simple_switch.py|3 ++- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/ryu/app/cbench.py b/ryu/app/cbench.py index 5dc64a9..cf3d68d 100644 --

[Ryu-devel] [PATCH 16/32] lib/mac: improve helper functions

2012-04-02 Thread Isaku Yamahata
- docstring - add sanity check as haddr_to_bin() is used to parse user-giving string Signed-off-by: Isaku Yamahata --- ryu/lib/mac.py | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/ryu/lib/mac.py b/ryu/lib/mac.py index 8a7009c..1fe3865 100644 --- a/ryu/l

[Ryu-devel] [PATCH 21/32] app/rest: add API to register/update mac address for a given port

2012-04-02 Thread Isaku Yamahata
- mac address parser/serializer - move out WSPathNetwork from rest.py - introduce wspath.py for URI parser which will be commonly used and moved WSPathNetwork into it. Signed-off-by: Isaku Yamahata --- ryu/app/rest.py | 126 --- 1 files chan

[Ryu-devel] [PATCH 07/32] ofproto/ofproto_v1_0: more constants for nx

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/ofproto/ofproto_v1_0.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py index e666ad9..780563a 100644 --- a/ryu/ofproto/ofproto_v1_0.py +++ b/ryu/ofproto/ofproto_v1

[Ryu-devel] [PATCH 02/32] add missing super().__init__()

2012-04-02 Thread Isaku Yamahata
- app/event_dumper - controller/dispatcher - controller/mac_to_network - controller/mac_to_port - app/simple_switch Signed-off-by: Isaku Yamahata --- ryu/app/event_dumper.py |1 + ryu/app/simple_switch.py |1 + ryu/controller/dispatcher.py |2 ++ ryu/controller/m

[Ryu-devel] [PATCH 00/32] gre tunnel app

2012-04-02 Thread Isaku Yamahata
Hi. This patch series implements an ryu application which support gre tunneling. The first part (1-6) is simpley trivial bug fix, refactoring. The second part (7-15) is for openflow parser/serializer imporvement. The thirt part (16-30) is preparation for gre tunneling the last port(31-32) is real

[Ryu-devel] [PATCH 04/32] app/wsapi: make WSPathComponent inherit object

2012-04-02 Thread Isaku Yamahata
Later we create subclass of WSPathComponent so that make super() work. app/wsapi: super().__init__() Signed-off-by: Isaku Yamahata --- ryu/app/wsapi.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/app/wsapi.py b/ryu/app/wsapi.py index 2b6e7c3..7b7a548 100644 --

[Ryu-devel] [PATCH 01/32] app/simple_isolation: unbreak nx patch

2012-04-02 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/simple_isolation.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ryu/app/simple_isolation.py b/ryu/app/simple_isolation.py index 667739c..44eaa3a 100644 --- a/ryu/app/simple_isolation.py +++ b/ryu/app/simple_isolation.py @@ -

[Ryu-devel] [PATCH 05/32] app/wspath: URI parsers and related constants

2012-04-02 Thread Isaku Yamahata
adds various URI parsers, related constants Signed-off-by: Isaku Yamahata --- ryu/app/wspath.py | 95 + 1 files changed, 95 insertions(+), 0 deletions(-) create mode 100644 ryu/app/wspath.py diff --git a/ryu/app/wspath.py b/ryu/app/wspath.p