Re: [Ryu-devel] [PATCH v4 03/13] controller/dispatcher: cork/uncork

2012-05-31 Thread Isaku Yamahata
On Fri, Jun 01, 2012 at 06:53:26AM +0900, FUJITA Tomonori wrote: > On Thu, 31 May 2012 18:35:00 +0900 > Isaku Yamahata wrote: > > > When event dispatching, thread can be switched or blocked so that > > another events may cut in. > > Introduce EventQueue.cork/uncork method to disable/enable event

Re: [Ryu-devel] [PATCH] app/simple_switch: fix commit e5e4b844250d36788f9b1bf71cfd36a6e14d5315 regression

2012-05-31 Thread FUJITA Tomonori
On Fri, 1 Jun 2012 06:53:54 +0900 Isaku Yamahata wrote: > Looks good. Thank you for fixing. > BTW how did you hit this issue? Just try to run simple_switch. -- Live Security Virtual Conference Exclusive live event will

Re: [Ryu-devel] [PATCH v4 08/13] app/discovery: link discovery application

2012-05-31 Thread FUJITA Tomonori
On Thu, 31 May 2012 18:35:05 +0900 Isaku Yamahata wrote: > Signed-off-by: Isaku Yamahata > --- > Changes v3 -> v4: > - be aware of reserved port > - app mgr > - make it aware the race between EventPortAdd and EventOFPPacketIn > packet-in event can arrive before port-add event. > So when disc

Re: [Ryu-devel] [PATCH] app/simple_switch: fix commit e5e4b844250d36788f9b1bf71cfd36a6e14d5315 regression

2012-05-31 Thread Isaku Yamahata
Looks good. Thank you for fixing. BTW how did you hit this issue? On Fri, Jun 01, 2012 at 06:15:23AM +0900, FUJITA Tomonori wrote: > I've applied the following fix: > > = > >From 5b9ad7f459e07a9b32f1db455ba2843c1aab2b09 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori > Date: Fri, 1 Jun 2012 06:

Re: [Ryu-devel] [PATCH v4 03/13] controller/dispatcher: cork/uncork

2012-05-31 Thread FUJITA Tomonori
On Thu, 31 May 2012 18:35:00 +0900 Isaku Yamahata wrote: > When event dispatching, thread can be switched or blocked so that > another events may cut in. > Introduce EventQueue.cork/uncork method to disable/enable event dispatching. > > Signed-off-by: Isaku Yamahata > --- > ryu/controller/disp

[Ryu-devel] [PATCH] app/simple_switch: fix commit e5e4b844250d36788f9b1bf71cfd36a6e14d5315 regression

2012-05-31 Thread FUJITA Tomonori
I've applied the following fix: = >From 5b9ad7f459e07a9b32f1db455ba2843c1aab2b09 Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori Date: Fri, 1 Jun 2012 06:12:19 +0900 Subject: [PATCH] app/simple_switch: fix commit e5e4b844250d36788f9b1bf71cfd36a6e14d5315 regression Traceback (most recent call las

[Ryu-devel] [PATCH v4 10/13] ryu/app/rest_discovery.py: rest API to get topology

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - app mgr - use dict.items() instead of dict.iteritems() --- bin/ryu-manager |1 + ryu/app/rest_discovery.py | 105 + 2 files changed, 106 insertions(+), 0 deletions(-) create mode 1006

[Ryu-devel] [PATCH v4 11/13] ryu/app/client: factor out rest client code

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 53 +++-- 1 files changed, 31 insertions(+), 22 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index c472889..d54fe44 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@

[Ryu-devel] [PATCH v4 08/13] app/discovery: link discovery application

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v3 -> v4: - be aware of reserved port - app mgr - make it aware the race between EventPortAdd and EventOFPPacketIn packet-in event can arrive before port-add event. So when discovery.port_set may or may not have the port which recieved a packet. Catc

[Ryu-devel] [PATCH v4 12/13] ryu/app/client.py: client library for discovery REST API

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/app/client.py | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/ryu/app/client.py b/ryu/app/client.py index d54fe44..4f6287f 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@ -83,3 +83,24 @@ class OFPClientV

[Ryu-devel] [PATCH v4 06/13] lib/lldp: lldp parser/serializer

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v1 -> v2: - copyright --- ryu/lib/lldp.py | 472 +++ 1 files changed, 472 insertions(+), 0 deletions(-) create mode 100644 ryu/lib/lldp.py diff --git a/ryu/lib/lldp.py b/ryu/lib/lldp.py new file mode

[Ryu-devel] [PATCH v4 09/13] app/wspath: URI parsers and related constants

2012-05-31 Thread Isaku Yamahata
adds various URI parsers, related constants Signed-off-by: Isaku Yamahata --- Changes v1 -> v2: - copyright --- ryu/app/wspath.py | 96 + 1 files changed, 96 insertions(+), 0 deletions(-) create mode 100644 ryu/app/wspath.py diff --git a/ry

[Ryu-devel] [PATCH v4 07/13] controller/link_set: introduce a class to track link topology

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v1 -> v2: - copyright - use items() instead of iteritems() --- ryu/controller/link_set.py | 142 1 files changed, 142 insertions(+), 0 deletions(-) create mode 100644 ryu/controller/link_set.py diff --git a/

[Ryu-devel] [PATCH v4 03/13] controller/dispatcher: cork/uncork

2012-05-31 Thread Isaku Yamahata
When event dispatching, thread can be switched or blocked so that another events may cut in. Introduce EventQueue.cork/uncork method to disable/enable event dispatching. Signed-off-by: Isaku Yamahata --- ryu/controller/dispatcher.py | 38 ++ 1 files changed,

[Ryu-devel] [PATCH v4 13/13] bin/ryu-client: support discovery rest api

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- bin/ryu-client | 27 ++- 1 files changed, 18 insertions(+), 9 deletions(-) diff --git a/bin/ryu-client b/bin/ryu-client index 9d5c7e4..f8c0b03 100755 --- a/bin/ryu-client +++ b/bin/ryu-client @@ -19,6 +19,7 @@ import sys from optparse

[Ryu-devel] [PATCH v4 05/13] dpset: add port{add, delete, modify} event for convenience and helper functions

2012-05-31 Thread Isaku Yamahata
For discovery, it's interested only in datapath/port appearance/disappearance. With this, discovery app would not have to handle OFP events directly. Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - track port status change properly So far it isn't tracked. If port status is changed before

[Ryu-devel] [PATCH v4 02/13] controller/controller, handler: remove datapath.ports

2012-05-31 Thread Isaku Yamahata
eliminate ports addribute of datapath because They aren't used. Signed-off-by: Isaku Yamahata --- ryu/controller/controller.py |1 - ryu/controller/handler.py|1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/ryu/controller/controller.py b/ryu/controller/controller.

[Ryu-devel] [PATCH v4 00/13] topology discovery application

2012-05-31 Thread Isaku Yamahata
This patch series implements topology discovery. v4. 1 - 2: minor improvement 3 - 5: enhancements as preparation 6 - 8: implements discovery application 9 - 13: implements discovery REST API Changes v3 -> v4: - resolved event reordering in dpset event - exception in discovery There are races be

[Ryu-devel] [PATCH v4 01/13] ryu/controller/controller: add a helper method, is_reserved_port()

2012-05-31 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/controller/controller.py |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ryu/controller/controller.py b/ryu/controller/controller.py index 5158323..5457e24 100644 --- a/ryu/controller/controller.py +++ b/ryu/controller/controller.py

[Ryu-devel] [PATCH v4 04/13] controller/handler: split out config_dispatcher into config and barrier replay

2012-05-31 Thread Isaku Yamahata
split out config_dispatcher into config and barrier replay so that dpset can handle switch feature replay Signed-off-by: Isaku Yamahata --- ryu/app/cbench.py | 20 +++- ryu/controller/handler.py | 43 +++ 2 files changed, 38 ins