On Sat, Jun 02, 2012 at 09:52:13AM +0900, FUJITA Tomonori wrote:
> On Sat, 2 Jun 2012 09:45:27 +0900
> Simon Horman wrote:
>
> > On Sat, Jun 02, 2012 at 05:38:53AM +0900, FUJITA Tomonori wrote:
> >> We use OFPT_* names for class names. So 'OFPGetConfigReply' looks more
> >> appropriate for OFPT_G
On Sat, 2 Jun 2012 09:45:27 +0900
Simon Horman wrote:
> On Sat, Jun 02, 2012 at 05:38:53AM +0900, FUJITA Tomonori wrote:
>> We use OFPT_* names for class names. So 'OFPGetConfigReply' looks more
>> appropriate for OFPT_GET_CONFIG_REPLY.
>
> Hi Fujita-san,
>
> is it also appropriate to rename OF
On Sat, Jun 02, 2012 at 05:38:53AM +0900, FUJITA Tomonori wrote:
> We use OFPT_* names for class names. So 'OFPGetConfigReply' looks more
> appropriate for OFPT_GET_CONFIG_REPLY.
Hi Fujita-san,
is it also appropriate to rename OFP_SWITCH_CONFIG_PACK_STR ?
> Signed-off-by: FUJITA Tomonori
> ---
We use OFPT_* names for class names. So 'OFPGetConfigReply' looks more
appropriate for OFPT_GET_CONFIG_REPLY.
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0_parser.py|8
ryu/tests/unit/ofproto/test_parser_v10.py | 18 +-
2 files changed, 13 ins
On Fri, 1 Jun 2012 20:54:49 +0900
FUJITA Tomonori wrote:
> unittest crashes on commit e5e4b8442:
>
> ERROR: testInit (ryu.tests.unit.sample.test_simple_switch.TestSimpleSwitch)
>
> Traceback (most recent call last):
> File
> "/var/lib/jenkins/jobs/ryu-test-upstream/workspace/ryu/tests/unit/s
unittest crashes on commit e5e4b8442:
ERROR: testInit (ryu.tests.unit.sample.test_simple_switch.TestSimpleSwitch)
Traceback (most recent call last):
File
"/var/lib/jenkins/jobs/ryu-test-upstream/workspace/ryu/tests/unit/sample/test_simple_switch.py",
line 20, in testInit
ss = SimpleSwitch
I applied the following patch.
=
>From 2520ab2c333aadad835d56243544bd6dccda Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori
Date: Fri, 1 Jun 2012 20:46:57 +0900
Subject: [PATCH] test: add NTT copyright to unittest files
Signed-off-by: FUJITA Tomonori
---
ryu/tests/unit/ofproto/test_ofproto_
