I usually don't apply a patch to silence a style warning. However,
there are only two places in ryu that pep8 complains. I don't think
that anybody is working on this code so let's silence it.
-
>From 164f255bb5a56cee5f88bb220a8539b200fb3b28 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori
Date: Su
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|5 +
ryu/ofproto/ofproto_v1_0_parser.py | 23 +++
2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index f2ad6ac..a42c075 1
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|1 +
ryu/ofproto/ofproto_v1_0_parser.py | 18 ++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index a84f518..5ba2d2b 100644
---
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|5 +
ryu/ofproto/ofproto_v1_0_parser.py | 22 ++
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index a42c075..a84f518 10
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|5
ryu/ofproto/ofproto_v1_0_parser.py | 42
2 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index 5ba2d2
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py|6 ++
ryu/ofproto/ofproto_v1_0_parser.py | 14 ++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index 650a725..f2ad6ac 100644
--
On Sat, 2 Jun 2012 21:01:13 +0900
FUJITA Tomonori wrote:
> It's a really bad idea if ryu gets OFPT_ERROR_MSG. For example, ryu
> should continue to run about 'Request was not understood' type error
> because ryu doesn't know what request types the switch supports.
>
> Let applications catch OFP
On Sat, 2 Jun 2012 23:48:10 +0900
FUJITA Tomonori wrote:
> also fix its unittest.
>
> Signed-off-by: FUJITA Tomonori
> ---
> ryu/ofproto/ofproto_v1_0.py |4 ++--
> ryu/tests/unit/ofproto/test_parser_v10.py |6 --
> 2 files changed, 6 insertions(+), 4 deletions(-)
Ap
On Fri, 1 Jun 2012 09:28:33 +0900
Isaku Yamahata wrote:
> On Fri, Jun 01, 2012 at 06:53:26AM +0900, FUJITA Tomonori wrote:
>> On Thu, 31 May 2012 18:35:00 +0900
>> Isaku Yamahata wrote:
>>
>> > When event dispatching, thread can be switched or blocked so that
>> > another events may cut in.
>>
also fix its unittest.
Signed-off-by: FUJITA Tomonori
---
ryu/ofproto/ofproto_v1_0.py |4 ++--
ryu/tests/unit/ofproto/test_parser_v10.py |6 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
index
On Sat, 2 Jun 2012 21:01:13 +0900
FUJITA Tomonori wrote:
> It's a really bad idea if ryu gets OFPT_ERROR_MSG. For example, ryu
It's a really bad idea if ryu closes a conneciton with a switch when
geting OFPT_ERROR_MSG.
> should continue to run about 'Request was not understood' type error
> be
It's a really bad idea if ryu gets OFPT_ERROR_MSG. For example, ryu
should continue to run about 'Request was not understood' type error
because ryu doesn't know what request types the switch supports.
Let applications catch OFPT_ERROR_MSG and do whatever they want. The
core should not do anything
On Sat, 2 Jun 2012 05:38:53 +0900
FUJITA Tomonori wrote:
> We use OFPT_* names for class names. So 'OFPGetConfigReply' looks more
> appropriate for OFPT_GET_CONFIG_REPLY.
>
> Signed-off-by: FUJITA Tomonori
> ---
> ryu/ofproto/ofproto_v1_0_parser.py|8
> ryu/tests/unit/ofpr
On Wed, 16 May 2012 18:17:53 +0900 (JST)
FUJITA Tomonori wrote:
> On Wed, 16 May 2012 17:47:48 +0900
> Isaku Yamahata wrote:
>
> > On Wed, May 16, 2012 at 04:31:33PM +0900, FUJITA Tomonori wrote:
> >> On Wed, 16 May 2012 13:18:33 +0900
> >> Isaku Yamahata wrote:
> >>
> >> > ryu/app/wsapi.py s
14 matches
Mail list logo