On Fri, Jun 01, 2012 at 06:57:35AM +0900, FUJITA Tomonori wrote:
> > +class PortSet(dict):
> > +"""
> > +dict: (dp, port_no) -> PortData(timestamp, aux)
> > +slimed down version of OrderedDict as python 2.6 doesn't support it.
>
> Please kill this. Just use Ordereddict package in 2.6.
On Mon, Jun 04, 2012 at 02:29:55PM +0900, FUJITA Tomonori wrote:
> Thanks, here's an updated patch.
Looks good.
Arguments should be format checked. Something like dpid is type of [0-9a-f]{16}
They can be addressed later by another patches.
Reviewed-by: Isaku Yamahata
>
> -
> >From a0df167c9ccc
On Mon, 4 Jun 2012 13:58:20 +0900
Isaku Yamahata wrote:
> Although I'm not sure what type note is, some lines can be simplified with
> ord() (and bytearray).
> some comments inlined.
The note argument is a list. each entry has a hex value. bytearray
might be better.
--
On Mon, 4 Jun 2012 11:15:58 +0900
Isaku Yamahata wrote:
> On Sat, Jun 02, 2012 at 05:32:39PM +0900, FUJITA Tomonori wrote:
>> On Wed, 16 May 2012 18:17:53 +0900 (JST)
>> FUJITA Tomonori wrote:
>>
>> > On Wed, 16 May 2012 17:47:48 +0900
>> > Isaku Yamahata wrote:
>> >
>> > > On Wed, May 16, 20
Although I'm not sure what type note is, some lines can be simplified with
ord() (and bytearray).
some comments inlined.
On Sun, Jun 03, 2012 at 10:35:23AM +0900, FUJITA Tomonori wrote:
> Signed-off-by: FUJITA Tomonori
> ---
> ryu/ofproto/ofproto_v1_0.py|5
> ryu/ofproto/ofprot
On Sun, 3 Jun 2012 10:35:19 +0900
FUJITA Tomonori wrote:
> Signed-off-by: FUJITA Tomonori
> ---
> ryu/ofproto/ofproto_v1_0.py|6 ++
> ryu/ofproto/ofproto_v1_0_parser.py | 14 ++
> 2 files changed, 20 insertions(+), 0 deletions(-)
Merged the five patches.
---
On Sat, Jun 02, 2012 at 05:32:39PM +0900, FUJITA Tomonori wrote:
> On Wed, 16 May 2012 18:17:53 +0900 (JST)
> FUJITA Tomonori wrote:
>
> > On Wed, 16 May 2012 17:47:48 +0900
> > Isaku Yamahata wrote:
> >
> > > On Wed, May 16, 2012 at 04:31:33PM +0900, FUJITA Tomonori wrote:
> > >> On Wed, 16 Ma
On Sun, 3 Jun 2012 10:41:25 +0900
FUJITA Tomonori wrote:
> I usually don't apply a patch to silence a style warning. However,
> there are only two places in ryu that pep8 complains. I don't think
> that anybody is working on this code so let's silence it.
>
> -
> >From 164f255bb5a56cee5f88bb220a
