Re: [Ryu-devel] [PATCH 1/2] add Nicira Extension NXAST_LEARN support

2012-06-07 Thread FUJITA Tomonori
On Fri, 8 Jun 2012 11:32:57 +0900 Simon Horman wrote: > Sorry for not noticing this earlier. It has no bearing on the correctness > or performance of the code, but I think there is a typo. > > s/find_/fin_/ Oops, thanks. I fixed the typo and added some constants about NXAST_LEARN. The followin

Re: [Ryu-devel] [PATCH 1/2] add Nicira Extension NXAST_LEARN support

2012-06-07 Thread Simon Horman
On Fri, Jun 08, 2012 at 07:14:16AM +0900, FUJITA Tomonori wrote: > Signed-off-by: FUJITA Tomonori > --- > ryu/ofproto/ofproto_v1_0.py|5 > ryu/ofproto/ofproto_v1_0_parser.py | 39 > > 2 files changed, 44 insertions(+), 0 deletions(-) > > d

Re: [Ryu-devel] [PATCH 4/6] Add Nicira Extension NXT_PACKET_IN support

2012-06-07 Thread Isaku Yamahata
On Fri, Jun 08, 2012 at 11:05:22AM +0900, Isaku Yamahata wrote: > On Thu, Jun 07, 2012 at 09:47:21AM +0900, FUJITA Tomonori wrote: > > On Thu, 7 Jun 2012 09:40:02 +0900 > > Isaku Yamahata wrote: > > > > > On Thu, Jun 07, 2012 at 08:03:31AM +0900, FUJITA Tomonori wrote: > > >> On Thu, 7 Jun 2012 0

Re: [Ryu-devel] [PATCH 4/6] Add Nicira Extension NXT_PACKET_IN support

2012-06-07 Thread Isaku Yamahata
On Thu, Jun 07, 2012 at 09:47:21AM +0900, FUJITA Tomonori wrote: > > - fork dpkt: new bsd > > (or revive dpkt ourselves) > > > > - create our own frame praser > > fork from something(dpkt?) is a good starting point. > > Yeah, post a patch to dpkt and then if it doesn't work, then forking > dp

Re: [Ryu-devel] [PATCH 4/6] Add Nicira Extension NXT_PACKET_IN support

2012-06-07 Thread Isaku Yamahata
On Thu, Jun 07, 2012 at 09:47:21AM +0900, FUJITA Tomonori wrote: > On Thu, 7 Jun 2012 09:40:02 +0900 > Isaku Yamahata wrote: > > > On Thu, Jun 07, 2012 at 08:03:31AM +0900, FUJITA Tomonori wrote: > >> On Thu, 7 Jun 2012 07:48:34 +0900 > >> Isaku Yamahata wrote: > >> > >> > I meant ethernet fram

Re: [Ryu-devel] [PATCH 0/2] add Nicira Extension NXAST_LEARN support (we support all the NX actions)

2012-06-07 Thread Simon Horman
Likewise, Reviewed-by: Simon Horman On Fri, Jun 08, 2012 at 09:35:19AM +0900, Isaku Yamahata wrote: > Looks good. > Reviewed-by: Isaku Yamahata > > On Fri, Jun 08, 2012 at 07:14:15AM +0900, FUJITA Tomonori wrote: > > We can do better about NXAST_LEARN flow_mod_spec handling (we could > > creat

Re: [Ryu-devel] [PATCH 0/2] add Nicira Extension NXAST_LEARN support (we support all the NX actions)

2012-06-07 Thread Isaku Yamahata
Looks good. Reviewed-by: Isaku Yamahata On Fri, Jun 08, 2012 at 07:14:15AM +0900, FUJITA Tomonori wrote: > We can do better about NXAST_LEARN flow_mod_spec handling (we could > create a new class for it and passing its objects to NXActionLearn > class). However, I can set the learn action to ovs

[Ryu-devel] [PATCH 2/2] Make clear that ryu supports all the NX actions

2012-06-07 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_0.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py index c8db6e7..4462946 100644 --- a/ryu/ofproto/ofproto_v1_0.py +++ b/ryu/ofproto/ofproto_v1_0.py @@

[Ryu-devel] [PATCH 0/2] add Nicira Extension NXAST_LEARN support (we support all the NX actions)

2012-06-07 Thread FUJITA Tomonori
We can do better about NXAST_LEARN flow_mod_spec handling (we could create a new class for it and passing its objects to NXActionLearn class). However, I can set the learn action to ovs with this code. Better than nothing. Now we support all the NX actions! = ryu/ofproto/ofproto_v1_0.py|

[Ryu-devel] [PATCH 1/2] add Nicira Extension NXAST_LEARN support

2012-06-07 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_0.py|5 ryu/ofproto/ofproto_v1_0_parser.py | 39 2 files changed, 44 insertions(+), 0 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py index 9892c2