Re: [Ryu-devel] What is a status of /controller/mac_to_port.py module?

2013-02-19 Thread Isaku Yamahata
Hi. On Tue, Feb 19, 2013 at 03:07:02PM +0100, Piotr Niedzwiedz wrote: > There are several modules where this kind of mapping is required: > > - /app/simple_isolation.py > - /app/gre_tunnel.py > - /app/simple_switch.py > - /tests/mininet/l2/vlan/test_vlan.py > - /tests/mininet/l2/mpls/test_mpls.py

[Ryu-devel] [PATCH 1/2] ryu/controller/dpset.py: duplicate import

2013-02-19 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/controller/dpset.py |1 - 1 file changed, 1 deletion(-) diff --git a/ryu/controller/dpset.py b/ryu/controller/dpset.py index a63ed8b..0891c2e 100644 --- a/ryu/controller/dpset.py +++ b/ryu/controller/dpset.py @@ -18,7 +18,6 @@ import logging from ryu.

[Ryu-devel] [PATCH 2/2] RyuApp: teach event dispatcher source state

2013-02-19 Thread Isaku Yamahata
This fixes the following exception. This is because observer handler is called independent on event source state. So teach event dispatcher event source state. > $ ryu-manager ryu_app(OF1.2 app) > $ sudo mn --controller remote 127.0.0.1 > $ sudo ovs-vsctl set bridge s1 protocols='[OpenFlow10

Re: [Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread YAMADA Hideki
>>> +@handler.set_ev_cls(ofp_event.EventOFPPortStatus, >>> handler.MAIN_DISPATCHER) >>> +def port_status_handler(self, ev): >>> +msg = ev.msg >>> +reason = msg.reason >>> +dpid = msg.datapath.id >>> +port_no = msg.desc.port_no >>> +ofproto = msg.data

Re: [Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread YAMADA Hideki
>> +@handler.set_ev_cls(ofp_event.EventOFPPortStatus, >> handler.MAIN_DISPATCHER) >> +def port_status_handler(self, ev): >> +msg = ev.msg >> +reason = msg.reason >> +dpid = msg.datapath.id > > Do you see msg.datapath.id is None case? > I don't see. Is it possible ca

Re: [Ryu-devel] [PATCH 0/3] update cfg.py

2013-02-19 Thread YAMAMOTO Takashi
hi, > Hi, good work. > > openstack adopts the convention to use '-', not '_'. > E.g. --option-value instead of --option_value. > So how about switching to '-' for consistency? no strong opinion from me. YAMAMOTO Takashi > > On Wed, Feb 20, 2013 at 12:38:42PM +0900, YAMAMOTO Takashi wrote: >>

[Ryu-devel] [PATCH] of1.2: fix OFPGroupDescStats parser

2013-02-19 Thread KONDOH Tasuku
- add action's size to offset of bucket. Signed-off-by: KONDOH Tasuku --- ryu/ofproto/ofproto_v1_2_parser.py|7 ++--- ryu/tests/unit/ofproto/test_parser_v12.py | 40 + 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1

Re: [Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread YAMADA Hideki
Hi, (2013/02/20 11:37), Isaku Yamahata wrote: > General comment. Some of logic could be generic, not specific to > datapath tracking. > Thanks for your comment. >> +class DatapathDiscovery(app_manager.RyuApp): >> +_EVENTS = [EventDPEnter, EventDPLeave, >> + EventDPPortAdd, Event

Re: [Ryu-devel] [PATCH 0/3] update cfg.py

2013-02-19 Thread Isaku Yamahata
Hi, good work. openstack adopts the convention to use '-', not '_'. E.g. --option-value instead of --option_value. So how about switching to '-' for consistency? On Wed, Feb 20, 2013 at 12:38:42PM +0900, YAMAMOTO Takashi wrote: > import a new version of cfg.py from the upstream, mainly to > obtai

[Ryu-devel] [PATCH 2/3] switch from openstack.common.cfg to oslo.config.cfg

2013-02-19 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- bin/ryu-manager| 4 ++-- ryu/app/quantum_adapter.py | 2 +- ryu/app/tunnel_port_updater.py | 2 +- ryu/app/wsgi.py| 2 +- ryu/controller/controller.py | 2 +- ryu/flags.py | 2 +- ryu/lib/ovs/bridge.py

[Ryu-devel] [PATCH 0/3] update cfg.py

2013-02-19 Thread YAMAMOTO Takashi
import a new version of cfg.py from the upstream, mainly to obtain the following change. commit 16c4ecbefc94941821f3ae7ca253fad7bc377c58 Author: YAMAMOTO Takashi Date: Wed Feb 13 14:01:46 2013 +0900 sort options to make --help output prettier explicitly sort options when a

Re: [Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread Isaku Yamahata
On Tue, Feb 19, 2013 at 08:41:01PM +0900, YAMADA Hideki wrote: > This is alternative of dpset. > * Don't call other app's method directly. > * Use Event request/reply > > event.py: event class modules > datapath.py: datapath discovery app using ofp_event > dumper.py: test app using discovery event

Re: [Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread Isaku Yamahata
General comment. Some of logic could be generic, not specific to datapath tracking. On Tue, Feb 19, 2013 at 08:41:01PM +0900, YAMADA Hideki wrote: > This is alternative of dpset. > * Don't call other app's method directly. > * Use Event request/reply > > event.py: event class modules > datapath.

[Ryu-devel] What is a status of /controller/mac_to_port.py module?

2013-02-19 Thread Piotr Niedzwiedz
There are several modules where this kind of mapping is required: - /app/simple_isolation.py - /app/gre_tunnel.py - /app/simple_switch.py - /tests/mininet/l2/vlan/test_vlan.py - /tests/mininet/l2/mpls/test_mpls.py - /tests/mininet/l3/ip_ttl/test_ip_ttl.py - /tests/mininet/l3/icmp/test_icmp.py but

[Ryu-devel] [PATCH 1/2] app_manager: support separated modules of Event class and RyuApp class

2013-02-19 Thread YAMADA Hideki
Because handler.set_ev_cls() sets observer to module of ev_cls, Event class and RyuApp must be in same module. If RyuApp has a list of events to be generated in app, AppManager can bind sender app and receiver app via event class. Signed-off-by: YAMADA Hideki --- ryu/base/app_manager.py |8

[Ryu-devel] [PATCH 2/2] support physical topology discovery

2013-02-19 Thread YAMADA Hideki
This is alternative of dpset. * Don't call other app's method directly. * Use Event request/reply event.py: event class modules datapath.py: datapath discovery app using ofp_event dumper.py: test app using discovery event TODO: support link discovery using LLDP Signed-off-by: YAMADA Hideki ---

[Ryu-devel] [PATCH 0/2] Improve event mechanism

2013-02-19 Thread YAMADA Hideki
This patch is related with following commit. replace dispatcher mechanism https://github.com/osrg/ryu/commit/7578e7d6020ea446af4640b17adb0c325c7570a8 YAMADA Hideki (2): app_manager: support separated modules of Event class and RyuApp class support physical topology discovery ryu/base/ap

[Ryu-devel] Student candidates for Google Summer of Code 2013 for Ryu?

2013-02-19 Thread Isaku Yamahata
Hi. Google Summer of Code 2013 is announced.[1] Are there any students interested in Google Summer of Code 2013 with Ryu project? [1] http://www.google-melange.com/gsoc/homepage/google/gsoc2013 thanks, -- yamahata -- Eve