Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-20 Thread YAMAMOTO Takashi
hi, > Empty send_q.get() is blocking send thread. > Because of this issue, datapath state never transit to DEAD. oops, sorry. probably it's better to just leave it for gc? YAMAMOTO Takashi > > This fixes commit 83e3709a0d70f889e794d1c5f70c1c1eb73075f7. > - controller: fix send_q draining >

[Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-20 Thread YAMADA Hideki
Empty send_q.get() is blocking send thread. Because of this issue, datapath state never transit to DEAD. This fixes commit 83e3709a0d70f889e794d1c5f70c1c1eb73075f7. - controller: fix send_q draining https://github.com/osrg/ryu/commit/83e3709a0d70f889e794d1c5f70c1c1eb73075f7 Signed-off-by: Y

[Ryu-devel] [PATCH] add an option to run cProfile

2013-02-20 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- bin/ryu-manager | 47 +-- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/bin/ryu-manager b/bin/ryu-manager index f154bfe..580d1a5 100755 --- a/bin/ryu-manager +++ b/bin/ryu-manager @@ -48,7 +48,9 @@ C

[Ryu-devel] [PATCH] test: remove unnecessary variables

2013-02-20 Thread HIYAMA Manabu
Signed-off-by: HIYAMA Manabu --- ryu/tests/mininet/l2/mpls/test_mpls.py |1 - ryu/tests/mininet/l2/vlan/test_vlan.py |1 - ryu/tests/mininet/l3/icmp/test_icmp.py |1 - ryu/tests/mininet/l3/ip_ttl/test_ip_ttl.py |1 - 4 files changed, 4 deletions(-) diff --git a/ryu/t

Re: [Ryu-devel] What is a status of /controller/mac_to_port.py module?

2013-02-20 Thread HIYAMA Manabu
Hi, On Wed, 20 Feb 2013 14:45:03 +0900 Isaku Yamahata wrote: > Hi. > > On Tue, Feb 19, 2013 at 03:07:02PM +0100, Piotr Niedzwiedz wrote: > > There are several modules where this kind of mapping is required: > > > > - /app/simple_isolation.py > > - /app/gre_tunnel.py > > - /app/simple_switch.py

[Ryu-devel] [PATCH] packet lib: fix icmpv6.nd_s.parser() and support NDP option type

2013-02-20 Thread HIYAMA Manabu
This patch fixes parser error if there is no NDP option, and support the class to handle the NDP option. I have implemented only the option type = 1 and 2. We also need to implement other type, but this is enough in mininet for now. > Traceback (most recent call last): > (...) > File > "/usr/l

[Ryu-devel] [PATCH 2/3] update an example after option name changes

2013-02-20 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- etc/ryu/ryu.conf | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/etc/ryu/ryu.conf b/etc/ryu/ryu.conf index 341de67..e1a4458 100644 --- a/etc/ryu/ryu.conf +++ b/etc/ryu/ryu.conf @@ -2,7 +2,7 @@ [DEFAULT] -#wsapi_host= -#wsapi_por

[Ryu-devel] [PATCH 1/3] change --foo_bar options to --foo-bar

2013-02-20 Thread YAMAMOTO Takashi
rename options. (s/_/-/) according to Isaku Yamahata, this makes us look similar to openstack. caveat: no backward compat is provided. you need to update both of config files and cli options. Signed-off-by: YAMAMOTO Takashi --- bin/ryu-manager| 2 +- ryu/app/tunnel_port_update

[Ryu-devel] [PATCH 0/3] rename options

2013-02-20 Thread YAMAMOTO Takashi
rename options from --foo_bar to --foo-bar. according to Isaku Yamahata, the latter looks more similar to openstack these days. YAMAMOTO Takashi (3): change --foo_bar options to --foo-bar update an example after option name changes mechanical documentation update after option name changes

[Ryu-devel] [PATCH 3/3] mechanical documentation update after option name changes

2013-02-20 Thread YAMAMOTO Takashi
s/_/-/ in option names. note: some parts of them (eg. eventdumper, nova, ...) looks outdated but i didn't try to update them at least in this commit. Signed-off-by: YAMAMOTO Takashi --- doc/source/parameters.rst | 28 ++-- doc/source/tls.rst| 6 +++--- 2 files c

Re: [Ryu-devel] [PATCH 0/3] update cfg.py

2013-02-20 Thread YAMAMOTO Takashi
hi, > On Wed, 20 Feb 2013 12:46:17 +0900 > Isaku Yamahata wrote: > >> openstack adopts the convention to use '-', not '_'. >> E.g. --option-value instead of --option_value. >> So how about switching to '-' for consistency? > > Sounds better. Please update the patchset. which patchset? YAMAMOT

Re: [Ryu-devel] [PATCH 0/3] update cfg.py

2013-02-20 Thread FUJITA Tomonori
On Wed, 20 Feb 2013 12:46:17 +0900 Isaku Yamahata wrote: > openstack adopts the convention to use '-', not '_'. > E.g. --option-value instead of --option_value. > So how about switching to '-' for consistency? Sounds better. Please update the patchset. --

[Ryu-devel] [PATCH] of1.3: fix error in port_mod and get_config_reply logic

2013-02-20 Thread 张东亚
--- ryu/ofproto/ofproto_v1_3.py| 4 ++-- ryu/ofproto/ofproto_v1_3_parser.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_3.py b/ryu/ofproto/ofproto_v1_3.py index 021b2d5..1ff6428 100644 --- a/ryu/ofproto/ofproto_v1_3.py +++ b/ryu/ofproto/ofp