Re: [Ryu-devel] [PATCH 0/5] switch to eventlet

hi, do you want me rebase this? ie. convert new gevent users like ofctl_v1_2 and topology stuff? YAMAMOTO Takashi >> On Mon, 18 Mar 2013 17:29:54 +0900 >> YAMAMOTO Takashi wrote: >> >>> switch from gevent to eventlet. >> >> Great, thanks. >> >>> at this point, gevent can still be used with R

[Ryu-devel] [PATCH 6/9] lib/packet: checksum function with pseudo ipv4/ipv6 header

Signed-off-by: Isaku Yamahata --- ryu/lib/packet/packet_utils.py | 61 1 file changed, 61 insertions(+) diff --git a/ryu/lib/packet/packet_utils.py b/ryu/lib/packet/packet_utils.py index 2a7f221..b8f2e05 100644 --- a/ryu/lib/packet/packet_utils.py +++ b

[Ryu-devel] [PATCH 9/9] lib/packet/tcp: use checksum_ip()

Signed-off-by: Isaku Yamahata --- ryu/lib/packet/tcp.py |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/ryu/lib/packet/tcp.py b/ryu/lib/packet/tcp.py index a225847..a7ef178 100644 --- a/ryu/lib/packet/tcp.py +++ b/ryu/lib/packet/tcp.py @@ -17,7 +17,6 @@ import struc

[Ryu-devel] [PATCH 4/9] lib/packet/packet_utils: improve checksum padding

IP checksum needs padding. Move padding logic into checksum from caller. Signed-off-by: Isaku Yamahata --- ryu/lib/packet/icmp.py |2 -- ryu/lib/packet/icmpv6.py |2 -- ryu/lib/packet/packet_utils.py |3 +++ ryu/lib/packet/tcp.py |2 -- ryu/lib/packet/udp.p

[Ryu-devel] [PATCH 8/9] lib/packet/udp: use checksum_ip()

As side effect, IPv6 is also supported. Signed-off-by: Isaku Yamahata --- ryu/lib/packet/udp.py |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ryu/lib/packet/udp.py b/ryu/lib/packet/udp.py index 2944f8a..518f4fc 100644 --- a/ryu/lib/packet/udp.py +++ b/ryu/lib/pack

[Ryu-devel] [PATCH 7/9] lib/packet/icmpv6: use checksum_ip()

Signed-off-by: Isaku Yamahata --- ryu/lib/packet/icmpv6.py | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/ryu/lib/packet/icmpv6.py b/ryu/lib/packet/icmpv6.py index bcad884..e3bd781 100644 --- a/ryu/lib/packet/icmpv6.py +++ b/ryu/lib/packet/icmpv6.py @@ -17,6 +17,

[Ryu-devel] [PATCH 1/9] ryu/tests/unit/ofproto/test_parser_v10.py: make test pass

This patch make the following test pass. > TestOFPVendorStatsReply > test_parser > (ryu.tests.unit.ofproto.test_parser_v10.TestOFPVendorStatsReply)ERROR > > == > ERROR: test_parser > (ryu.tests.unit.ofproto.test_parser_v10.T

[Ryu-devel] [PATCH 3/9] tests/unit/packet/test_tcp.py: typo UDP -> TCP

TODO: test doesn't pass yet. Signed-off-by: Isaku Yamahata --- ryu/tests/unit/packet/test_tcp.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/packet/test_tcp.py b/ryu/tests/unit/packet/test_tcp.py index 978cb34..1214ab6 100644 --- a/ryu/tests/unit/pa

[Ryu-devel] [PATCH 2/9] test_icmpv6: correct icmpv6 checksum

icmpv6_csum() uses wrong format. It happened to produce correct value for csum. Signed-off-by: Isaku Yamahata --- ryu/tests/unit/packet/test_icmpv6.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/packet/test_icmpv6.py b/ryu/tests/unit/packet/test_icm

[Ryu-devel] [PATCH 0/9] lib/packet: checksum improvement

This patch series improves ip checksum logic. Isaku Yamahata (9): ryu/tests/unit/ofproto/test_parser_v10.py: make test pass test_icmpv6: correct icmpv6 checksum tests/unit/packet/test_tcp.py: typo UDP -> TCP lib/packet/packet_utils: improve checksum padding lib/packet/packet_utils: impro

[Ryu-devel] [PATCH 5/9] lib/packet/packet_utils: improve checksum byteswap

move byteswap logic into checksum from caller. Signed-off-by: Isaku Yamahata --- ryu/lib/packet/icmp.py |4 ++-- ryu/lib/packet/icmpv6.py |3 +-- ryu/lib/packet/ipv4.py |4 ++-- ryu/lib/packet/packet_utils.py |4 +++- ryu/lib/packet/t

[Ryu-devel] [PATCH 2/2] Minor changes to support IPv6 src/dst in NXM.

Changed pack string of IPv6 address from former '!4I' to '!16s'. Might need an IPv6Addr class or something to convert between human readable address and binary representation. Signed-off-by: Can Zhang --- ryu/ofproto/nx_match.py | 23 --- 1 file changed, 20 insertions(+), 3

[Ryu-devel] [PATCH 1/2] support parse OFPAction in NXFlowStats

Signed-off-by: Can Zhang --- ryu/ofproto/ofproto_v1_0_parser.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index 180e161..a6d3977 100644 --- a/ryu/ofproto/ofproto_v1_0_parser.py +++ b/ryu/ofproto/ofprot

[Ryu-devel] [PATCH] test_parser_v10: fix unittest breakage

Commit 366da0 break unittest. The following error occurs. $ ./run_tests.sh (...) == ERROR: test_parser (ryu.tests.unit.ofproto.test_parser_v10.TestOFPVendorStatsReply)

Re: [Ryu-devel] PATCH for File NX_Match

Hello, I implemented the nw_src_mask and nw_src_mask according to the Flow Match Structures in the Openflow-Spec-v1.0.0, Section 5.2.3. (/* IP source address wildcard bit count. 0 is exact match, 1 ignores the * LSB, 2 ignores the 2 least-significant bits, ..., 32 and higher wildcard * the entire

Re: [Ryu-devel] [PATCH] lib/packet/packet_base: fix signature of PacketBase.{parser, serialize}

On Thu, 28 Mar 2013 16:08:11 +0900 Isaku Yamahata wrote: > All subclasses define them as > parser(cls, buf) and serialize(self, payload, prev) > Not parser(cls), serialize(self). > > pylint also complains like >> W: 50,4:ipv4.parser: Arguments number differs from overridden method >> W: 65,4:ipv

Re: [Ryu-devel] patch about nx_flow_stats

On Thu, 28 Mar 2013 18:15:28 +0800 Can Zhang wrote: > I modified OHMURA's patch and added actions parser, and NXM IPv6 support. Can you update and repost a patch against the latest code? Thanks, -- Own the Future-Intel

Re: [Ryu-devel] patch about a typo

On Thu, 28 Mar 2013 18:11:28 +0800 Can Zhang wrote: > From 1b63bd9b8d12ca5dab9d0264696df5bf48443cd0 Mon Sep 17 00:00:00 2001 > From: Can Zhang > Date: Wed, 27 Mar 2013 22:15:48 +0800 > Subject: [PATCH] correct a typo. > > --- > ryu/ofproto/ofproto_v1_0_parser.py | 2 +- > 1 file changed, 1 ins

Re: [Ryu-devel] [PATCH] add VLAN_ID setting means

On Tue, 26 Mar 2013 18:36:46 +0900 竹下昇 wrote: > This patch contains the following update for ofctl_v1_2 library. > adding a means which sets up VLAN_ID. > > (I think that I will use this by a firewall Ryu application.) > > Signed-off-by: TAKESHITA Noboru > --- > ryu/lib/ofctl_v1_2.py |3

Re: [Ryu-devel] [PATCH 1/3] nx_match: add MFField parser

On Tue, 26 Mar 2013 17:59:17 +0900 OHMURA Kei wrote: > Signed-off-by: OHMURA Kei > --- > ryu/ofproto/nx_match.py | 128 > +++ > 1 file changed, 118 insertions(+), 10 deletions(-) Applied all, thanks. ---

[Ryu-devel] patch about nx_flow_stats

Hello, I modified OHMURA's patch and added actions parser, and NXM IPv6 support. diff file attached below. Best regards, Can Zhang nx_flow_stats.diff Description: Binary data -- Own the Future-Intel® Level Up Game

[Ryu-devel] patch about a typo

Hello, Attached a simple patch about a typo. Best regards, Can Zhang typo.diff Description: Binary data -- Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo co

Re: [Ryu-devel] REST API for topology module

(2013/03/27 15:22), Nikhil wrote: > Thanks a lot. Discovery module is designed to work with only OF1.0. When > can we expect OF1.2 or OF1.3 support? > Sorry, there is no plan for support OF1.2/OF1.3 yet. But I think it is needed. > Best Regards, > Nikhil > > -

[Ryu-devel] [PATCH 5/5] ryu-client: print http response

Signed-off-by: YAMADA Hideki --- bin/ryu-client |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/bin/ryu-client b/bin/ryu-client index ea3a3ea..9277964 100755 --- a/bin/ryu-client +++ b/bin/ryu-client @@ -99,7 +99,9 @@ def client_test(): for

[Ryu-devel] [PATCH 4/5] ryu-client: support Topology REST API

Signed-off-by: YAMADA Hideki --- bin/ryu-client|5 + ryu/app/client.py | 34 ++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/bin/ryu-client b/bin/ryu-client index 292ee26..ea3a3ea 100755 --- a/bin/ryu-client +++ b/bin/ryu-client @@

[Ryu-devel] [PATCH 3/5] topology: Add REST API

1. run topology/switches and app/rest_topology $ ./bin/ryu-manager --verbose --observe-links ryu/topology/switches.py ryu/app/rest_topology.py 2. You can get topology json $ curl http://127.0.0.1:8080/v1.0/topology/links [{"src": {"hw_addr": "06:96:65:51:f8:ff", "name": "s2-eth3", "port_no": "00

[Ryu-devel] [PATCH 2/5] topology: exported function returns Switch/Link list instead of event

Signed-off-by: YAMADA Hideki --- ryu/topology/switches.py |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ryu/topology/switches.py b/ryu/topology/switches.py index 6b69a00..318473f 100644 --- a/ryu/topology/switches.py +++ b/ryu/topology/switches.py @@ -804,7 +804,8

[Ryu-devel] [PATCH 1/5] lib/port_no: handling port_no as string

Signed-off-by: YAMADA Hideki --- ryu/lib/port_no.py | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) create mode 100644 ryu/lib/port_no.py diff --git a/ryu/lib/port_no.py b/ryu/lib/port_no.py new file mode 100644 index 000..33720f3 --- /dev/null +++

[Ryu-devel] [PATCH 0/5] Topology REST API

YAMADA Hideki (5): lib/port_no: handling port_no as string topology: exported function returns Switch/Link list instead of event topology: Add REST API ryu-client: support Topology REST API ryu-client: print http response bin/ryu-client |9 - ryu/app/client.py|

[Ryu-devel] [PATCH] lib/packet/packet_base: fix signature of PacketBase.{parser, serialize}

All subclasses define them as parser(cls, buf) and serialize(self, payload, prev) Not parser(cls), serialize(self). pylint also complains like > W: 50,4:ipv4.parser: Arguments number differs from overridden method > W: 65,4:ipv4.serialize: Arguments number differs from overridden method Signed-of

Re: [Ryu-devel] [PATCH] ofproto_parser: dump packets if error is encountered during parse

On Mon, Mar 25, 2013 at 04:54:46PM +0900, Isaku Yamahata wrote: > Thank you for testing. > > On Mon, Mar 25, 2013 at 03:23:15PM +0800, can. wrote: > > Hello, > > > > I tried to apply your patch to the latest master on github, but got an > > error at > > line 12: > > > > fatal: corrupt patch at