Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread can.
Very very sorry for the inconvenience. I think I forgot to reinstall ryu when I test those changes. So when I ran a test case I wrote, it actually ran with an older version, not the one I changed. Then I assumed it's OK but actually not. That's very awkward for me, thanks for your patience. 2013

Re: [Ryu-devel] [PATCH] topology/dumper: fix RyuApp.__init__ signature

2013-03-31 Thread YAMADA Hideki
Thanks. It's my mistake. Acked-by: YAMADA Hideki (2013/04/01 15:13), YAMAMOTO Takashi wrote: > so that this is at least instantiatable. > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/topology/dumper.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ryu/topology

[Ryu-devel] [PATCH] topology/dumper: fix RyuApp.__init__ signature

2013-03-31 Thread YAMAMOTO Takashi
so that this is at least instantiatable. Signed-off-by: YAMAMOTO Takashi --- ryu/topology/dumper.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/topology/dumper.py b/ryu/topology/dumper.py index b48d06f..8aafc62 100644 --- a/ryu/topology/dumper.py +++ b/ryu/topolog

[Ryu-devel] [PATCH] rest_firewall: fix comments

2013-03-31 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/app/rest_firewall.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index bcc2789..a2938a6 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -49,11 +49,11 @@

Re: [Ryu-devel] [PATCH] ryu/ofproto/ofproto_v1_0_parser: fix import error

2013-03-31 Thread FUJITA Tomonori
On Mon, 1 Apr 2013 13:15:22 +0900 Yoshihiro Kaneko wrote: > This patch fixes the following issue. > > Traceback (most recent call last): > File "/opt/stack/ryu/bin/ryu-manager", line 42, in > from ryu.base.app_manager import AppManager > File "/opt/stack/ryu/ryu/base/app_manager.py", l

[Ryu-devel] [PATCH] ryu/ofproto/ofproto_v1_0_parser: fix import error

2013-03-31 Thread Yoshihiro Kaneko
This patch fixes the following issue. Traceback (most recent call last): File "/opt/stack/ryu/bin/ryu-manager", line 42, in from ryu.base.app_manager import AppManager File "/opt/stack/ryu/ryu/base/app_manager.py", line 25, in from ryu.controller.handler import register_instance Fi

Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread Yoshihiro Kaneko
2013/4/1 FUJITA Tomonori : > On Mon, 1 Apr 2013 12:30:19 +0900 > Yoshihiro Kaneko wrote: > >> Hello, >> >> This change causes the following issue. >> -- >> Traceback (most recent call last): >> File "/opt/stack/ryu/bin/ryu-manager", line 42, in >> from ryu.base.app_manager import Ap

Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread FUJITA Tomonori
On Mon, 1 Apr 2013 12:30:19 +0900 Yoshihiro Kaneko wrote: > Hello, > > This change causes the following issue. > -- > Traceback (most recent call last): > File "/opt/stack/ryu/bin/ryu-manager", line 42, in > from ryu.base.app_manager import AppManager > File "/opt/stack/ryu/ryu/

Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread Yoshihiro Kaneko
Hello, This change causes the following issue. -- Traceback (most recent call last): File "/opt/stack/ryu/bin/ryu-manager", line 42, in from ryu.base.app_manager import AppManager File "/opt/stack/ryu/ryu/base/app_manager.py", line 25, in from ryu.controller.handler import re

[Ryu-devel] [PATCH] lib/packet/packet_utils: optimize checksum

2013-03-31 Thread Isaku Yamahata
builtin function, sum, is much faster than for loop. The result on my machine is as follows > def main(): > from timeit import timeit > data = bytearray().zfill(1500) > print 'new=', timeit(lambda : checksum(data), number=1000) > print 'old=', timeit(lambda : checksum_old(data), nu

[Ryu-devel] [PATCH] ryu/lib/packet/packet.py: should use isinstance instead of __class__.__base__

2013-03-31 Thread Isaku Yamahata
The current implementation doesn't allow inheriting twice from class PacketBase. Signed-off-by: Isaku Yamahata --- ryu/lib/packet/packet.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index a461eee..da9c412 100644 ---

Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread can.
Oops, I'm sorry. >From 2e9358c4f8fa0de8b6f5c49b714248d1ff210a70 Mon Sep 17 00:00:00 2001 From: Can Zhang Date: Mon, 1 Apr 2013 09:11:20 +0800 Subject: [PATCH] use utils.round_up Signed-off-by: Can Zhang --- ryu/ofproto/ofproto_v1_0_parser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread FUJITA Tomonori
On Mon, 1 Apr 2013 08:51:20 +0800 Can Zhang wrote: >>From 8bc4236b1cee2619d9b4ce938f6901e2fcecd283 Mon Sep 17 00:00:00 2001 > From: Can Zhang > Date: Mon, 1 Apr 2013 08:49:27 +0800 > Subject: [PATCH] use utils.round_up > > Signed-off-by: Can Zhang > --- > ryu/ofproto/ofproto_v1_0_parser.py |

[Ryu-devel] [PATCH] use utils.round_up

2013-03-31 Thread Can Zhang
>From 8bc4236b1cee2619d9b4ce938f6901e2fcecd283 Mon Sep 17 00:00:00 2001 From: Can Zhang Date: Mon, 1 Apr 2013 08:49:27 +0800 Subject: [PATCH] use utils.round_up Signed-off-by: Can Zhang --- ryu/ofproto/ofproto_v1_0_parser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

Re: [Ryu-devel] [PATCH 2/2] Minor changes to support IPv6 src/dst in NXM.

2013-03-31 Thread can.
2013/3/30 FUJITA Tomonori > On Fri, 29 Mar 2013 11:19:31 +0800 > Can Zhang wrote: > > > Changed pack string of IPv6 address from former '!4I' to '!16s'. > > I think that 8H would be better for consistency with of1.2 code. > > But format strings other than 16s will cause unpack_from() parameter e

Re: [Ryu-devel] request to reorganize ryu/app directory

2013-03-31 Thread Shivaram Mysore
I would then change "any" to "multiple" and save any combination of multiple version examples. It is the not the perfect answer, but it would be a start to reduce clutter. This will allow say, file names simple_swicth to be available in each version-nd directory instead of having _1_2 or _1_3

Re: [Ryu-devel] request to reorganize ryu/app directory

2013-03-31 Thread FUJITA Tomonori
On Sun, 31 Mar 2013 04:57:48 -0700 Shivaram Mysore wrote: > Then I would add "any" or "all" directory in addition to the ones > proposed and save it there Where I can put applications supporting _only_ 1.2 and 1.3? -- O

Re: [Ryu-devel] request to reorganize ryu/app directory

2013-03-31 Thread Shivaram Mysore
Then I would add "any" or "all" directory in addition to the ones proposed and save it there Thx /Shivaram ::Sent from my mobile device:: On Mar 31, 2013, at 1:34 AM, FUJITA Tomonori wrote: > On Sat, 30 Mar 2013 10:55:17 -0700 > Shivaram Mysore wrote: > >> ryu/app directory contains very

Re: [Ryu-devel] [PATCH 0/5] switch to eventlet

2013-03-31 Thread FUJITA Tomonori
Hi, On Fri, 29 Mar 2013 14:22:03 +0900 (JST) yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > do you want me rebase this? > ie. convert new gevent users like ofctl_v1_2 and topology stuff? Yes, please. I'll release 1.8 tomorrow. So please an updated version after that. Also please drop gevent

Re: [Ryu-devel] [PATCH 0/9] lib/packet: checksum improvement

2013-03-31 Thread FUJITA Tomonori
On Fri, 29 Mar 2013 12:50:53 +0900 Isaku Yamahata wrote: > This patch series improves ip checksum logic. > > Isaku Yamahata (9): > ryu/tests/unit/ofproto/test_parser_v10.py: make test pass > test_icmpv6: correct icmpv6 checksum > tests/unit/packet/test_tcp.py: typo UDP -> TCP > lib/packe

Re: [Ryu-devel] [PATCH 3/5] topology: Add REST API

2013-03-31 Thread FUJITA Tomonori
On Thu, 28 Mar 2013 18:50:27 +0900 YAMADA Hideki wrote: > 1. run topology/switches and app/rest_topology > $ ./bin/ryu-manager --verbose --observe-links ryu/topology/switches.py > ryu/app/rest_topology.py > > 2. You can get topology json > $ curl http://127.0.0.1:8080/v1.0/topology/links > [{"s

Re: [Ryu-devel] [PATCH 1/5] lib/port_no: handling port_no as string

2013-03-31 Thread FUJITA Tomonori
On Thu, 28 Mar 2013 18:50:25 +0900 YAMADA Hideki wrote: > > Signed-off-by: YAMADA Hideki > --- > ryu/lib/port_no.py | 31 +++ > 1 files changed, 31 insertions(+), 0 deletions(-) > create mode 100644 ryu/lib/port_no.py > > diff --git a/ryu/lib/port_no.py b/ryu/li

Re: [Ryu-devel] [PATCH 4/5] ryu-client: support Topology REST API

2013-03-31 Thread FUJITA Tomonori
On Thu, 28 Mar 2013 18:50:28 +0900 YAMADA Hideki wrote: > > Signed-off-by: YAMADA Hideki > --- > bin/ryu-client|5 + > ryu/app/client.py | 34 ++ > 2 files changed, 39 insertions(+), 0 deletions(-) Applied, but I think that we need to move bin/ryu

Re: [Ryu-devel] PATCH for File NX_Match

2013-03-31 Thread FUJITA Tomonori
On Thu, 28 Mar 2013 16:28:59 +0100 Christopher Scherb wrote: > Hello, > > I implemented the nw_src_mask and nw_src_mask according to the Flow > Match Structures in the Openflow-Spec-v1.0.0, Section 5.2.3. > (/* IP source address wildcard bit count. 0 is exact match, 1 ignores the > * LSB, 2 igno

Re: [Ryu-devel] request to reorganize ryu/app directory

2013-03-31 Thread FUJITA Tomonori
On Sat, 30 Mar 2013 10:55:17 -0700 Shivaram Mysore wrote: > ryu/app directory contains very good examples. It would be great if you > had sub directories underneath that such as "1_0", "1_2", 1_3" > to correspond against specific OF versions and include examples accordingly > underneath that. T

Re: [Ryu-devel] Getting REST service to work with Ryu

2013-03-31 Thread FUJITA Tomonori
On Sat, 30 Mar 2013 10:51:19 -0700 Shivaram Mysore wrote: > But, this rest works with OF 1.0. Is there one for OF 1.3.1 ? Not. We have ryu/lib/ofctl_v1_2.py though. -- Own the Future-Intel(R) Level Up Game Demo Contest

Re: [Ryu-devel] How to get multiple ryu applications working at the same time?

2013-03-31 Thread FUJITA Tomonori
On Sat, 30 Mar 2013 10:49:30 -0700 Shivaram Mysore wrote: > If I have multiple Ryu applications (say, l2_learn_switch.py, > ofctl_rest.py, l2_firewall.py) that I want to run, how can I do it with > ryu-manager? ryu-manager runs all applications that you specify: $ ryu-manager app/l2_learn_switc