Re: [Ryu-devel] [PATCH 1/3] lib/packet/packet_base: add tostring function

2013-06-06 Thread Isaku Yamahata
On Fri, Jun 07, 2013 at 11:38:44AM +0900, watanabe.fumitaka wrote: > Hi, > > > If value is not buildin type, some twist is necessary. recursion? > > For icmp, icmpv6 and lldp. > > If value is not buildin type like icmp.echo > it changed to inheriting PacketBase too, I think. PacketBase is not suit

Re: [Ryu-devel] [PATCH 3/3] lib/packet/ethernet and ipv4: add an individual conversion

2013-06-06 Thread watanabe.fumitaka
Hi, there is no reason which must be an instance attribute, so I will correct it to a class attribute. thanks. (2013/06/06 0:15), Isaku Yamahata wrote: > Why not _STR_CONVERT be class attribute instead of instance attribute? > > thanks, > > On Wed, Jun 05, 2013 at 01:58:19PM +0900, watanabe.fum

Re: [Ryu-devel] [PATCH 1/3] lib/packet/packet_base: add tostring function

2013-06-06 Thread watanabe.fumitaka
Hi, > If value is not buildin type, some twist is necessary. recursion? > For icmp, icmpv6 and lldp. If value is not buildin type like icmp.echo it changed to inheriting PacketBase too, I think. (2013/06/06 0:43), Isaku Yamahata wrote: > On Wed, Jun 05, 2013 at 01:57:34PM +0900, watanabe.fumi

Re: [Ryu-devel] about ryu and ryu plugin

2013-06-06 Thread Isaku Yamahata
On Thu, Jun 06, 2013 at 09:51:02PM +0800, Yong Sheng Gong wrote: > hi, Hi. > comparing the all SDN plugins, I found ryu plugin is the cleanest. > I want to know how to join the development of ryu itself? Ryu development is done openly at Ryu devel mailing list. Subscribe the ML and then discuss