Re: [Ryu-devel] [PATCH 0/7] RFC: OFPMatch api changes

2013-07-10 Thread YAMAMOTO Takashi
> On Wed, 10 Jul 2013 12:52:35 +0900 > YAMAMOTO Takashi wrote: > >> this set adds a new set of OFPMatch compose/query api for OF1.2/1.3. >> a usage example: >> https://github.com/yamt/LINC-Switch/commit/5ec3d893308469f9cc80b5696a1eefcfcc94191d > > Can you document the proposed APIs here? Then de

Re: [Ryu-devel] Ryu and Openstack Quantum

2013-07-10 Thread Yoshihiro Kaneko
2013/7/10 Isaku Yamahata : > On Mon, Jul 08, 2013 at 12:45:26PM +0200, Antonio wrote: >> I have a simple infrastructure with Openstack Grizzly (with Quantum), >> consisting of three nodes (one controller [running quantum-server], one >> network >> node [running quantum agents] and a compute node)

Re: [Ryu-devel] [PATCH 0/7] RFC: OFPMatch api changes

2013-07-10 Thread FUJITA Tomonori
On Wed, 10 Jul 2013 12:52:35 +0900 YAMAMOTO Takashi wrote: > this set adds a new set of OFPMatch compose/query api for OF1.2/1.3. > a usage example: > https://github.com/yamt/LINC-Switch/commit/5ec3d893308469f9cc80b5696a1eefcfcc94191d Can you document the proposed APIs here? Then developers who

[Ryu-devel] [PATCH 3/4] app/quantum_adapter: fix missing change to neutron

2013-07-10 Thread Yoshihiro Kaneko
Signed-off-by: Yoshihiro Kaneko --- ryu/app/quantum_adapter.py |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ryu/app/quantum_adapter.py b/ryu/app/quantum_adapter.py index 7a072be..2ead71f 100644 --- a/ryu/app/quantum_adapter.py +++ b/ryu/app/quantum_adapter.py @@ -20

[Ryu-devel] [PATCH 4/4] ryu/flags: rename config paramerters related to openstack

2013-07-10 Thread Yoshihiro Kaneko
Signed-off-by: Yoshihiro Kaneko --- ryu/app/quantum_adapter.py | 26 +- ryu/flags.py | 42 +- 2 files changed, 38 insertions(+), 30 deletions(-) diff --git a/ryu/app/quantum_adapter.py b/ryu/app/quantum_adapter.py

[Ryu-devel] [PATCH 2/4] app/quantum_adapter: project rename quantum -> neutron

2013-07-10 Thread Yoshihiro Kaneko
From: Isaku Yamahata Catch up for rename from quantumclient to neutronclient. Signed-off-by: Isaku Yamahata --- ryu/app/quantum_adapter.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ryu/app/quantum_adapter.py b/ryu/app/quantum_adapter.py index eca1360..7a

[Ryu-devel] [PATCH 1/4] app/client: update for quantum->neutron change

2013-07-10 Thread Yoshihiro Kaneko
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- ryu/app/client.py |1 + 1 file changed, 1 insertion(+) diff --git a/ryu/app/client.py b/ryu/app/client.py index 52dae7c..1cd8e58 100644 --- a/ryu/app/client.py +++ b/ryu/app/client.py @@ -245,6 +245,7 @@ class QuantumIfaceClientV1_0(Ry

[Ryu-devel] [PATCH 0/4] update for quantum->neutron change

2013-07-10 Thread Yoshihiro Kaneko
Quantum was renamed to Neutron. This set adds Neutron support. Isaku Yamahata (2): app/client: update for quantum->neutron change app/quantum_adapter: project rename quantum -> neutron Yoshihiro Kaneko (2): app/quantum_adapter: fix missing change to neutron ryu/flags: rename config parame

Re: [Ryu-devel] [PATCH] fix comment typos (ofprotp -> ofproto)

2013-07-10 Thread FUJITA Tomonori
On Wed, 10 Jul 2013 11:25:34 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/tests/unit/ofproto/test_ofproto_common.py | 2 +- > ryu/tests/unit/ofproto/test_ofproto_parser.py | 2 +- > ryu/tests/unit/ofproto/test_ofproto_v12.py| 2 +- > ryu/tests/unit/of

Re: [Ryu-devel] [PATCH] fix typos (mpls_lable -> mpls_label)

2013-07-10 Thread FUJITA Tomonori
On Wed, 10 Jul 2013 11:07:50 +0900 YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_2_parser.py| 2 +- > ryu/ofproto/ofproto_v1_3_parser.py| 2 +- > ryu/tests/unit/ofproto/test_parser_v12.py | 2 +- > 3 files changed, 3 insertions(+), 3

Re: [Ryu-devel] Ryu and Openstack Quantum

2013-07-10 Thread Isaku Yamahata
On Mon, Jul 08, 2013 at 12:45:26PM +0200, Antonio wrote: > I have a simple infrastructure with Openstack Grizzly (with Quantum), > consisting of three nodes (one controller [running quantum-server], one > network > node [running quantum agents] and a compute node) as in http:// > docs.openstack.or

[Ryu-devel] [PATCH v3 09/12] quantum_adapter: race between ovs port deletion and plugin port deletion

2013-07-10 Thread Isaku Yamahata
The order between the notification of ovs port deletion via OVSDB protocol and the notification network id/port deletion via REST from quantum plugin isn't deterministic. So when ovs port is deleted, the corresponding network id may or may not exist. The code wrongly assumed the order, so resulted

[Ryu-devel] [PATCH v3 05/12] gre_tunnel: exception due to race condition

2013-07-10 Thread Isaku Yamahata
This depends on thread scheduling. When event handler is invoked, there may not corresponding network_id in network module. In fact, Network.remove_network() fires EventNetworkPort(add_del=False) before EventNetworkDel event so that it is unnecessary to call _vm_port_mac_handler(). > 127.0.0.1 - -

[Ryu-devel] [PATCH v3 11/12] controller/network: pylint

2013-07-10 Thread Isaku Yamahata
W: 18,0: Unused import logging Signed-off-by: Isaku Yamahata --- ryu/controller/network.py |1 - 1 file changed, 1 deletion(-) diff --git a/ryu/controller/network.py b/ryu/controller/network.py index 2908c40..93fed29 100644 --- a/ryu/controller/network.py +++ b/ryu/controller/network.py @@

[Ryu-devel] [PATCH v3 03/12] network: sort out order between event and actual deletion of network

2013-07-10 Thread Isaku Yamahata
And make Network.remove_network more robust. Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - new patch --- ryu/controller/network.py | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ryu/controller/network.py b/ryu/controller/network.py index b029507..

[Ryu-devel] [PATCH v3 12/12] app/simple_vlan: pylint

2013-07-10 Thread Isaku Yamahata
W: 17,0: Unused import logging Signed-off-by: Isaku Yamahata --- ryu/app/simple_vlan.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/app/simple_vlan.py b/ryu/app/simple_vlan.py index a337789..a64d4eb 100644 --- a/ryu/app/simple_vlan.py +++ b/ryu/app/simple_vlan.py @@ -14,8 +14,6 @

[Ryu-devel] [PATCH v3 04/12] network.py: exception in Networks.remove_port()

2013-07-10 Thread Isaku Yamahata
Neutron plugin can call remove_port after network deletion for automatic delete port like router/dhcp port. So ignore NetworkNotFound exception. Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - new patch --- ryu/controller/network.py |7 ++- 1 file changed, 6 insertions(+), 1 deleti

[Ryu-devel] [PATCH v3 02/12] network.py: sort out order between event and actual deletion of port

2013-07-10 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - new patch --- ryu/controller/network.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ryu/controller/network.py b/ryu/controller/network.py index a3441a8..b029507 100644 --- a/ryu/controller/network.py +++ b/ry

[Ryu-devel] [PATCH v3 01/12] app/gre_tunnel.py: typo has_network -> has_networks

2013-07-10 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - new patch --- ryu/app/gre_tunnel.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/app/gre_tunnel.py b/ryu/app/gre_tunnel.py index 903d6d2..2302aed 100644 --- a/ryu/app/gre_tunnel.py +++ b/ryu/app/gre_tunnel.py @@ -

[Ryu-devel] [PATCH v3 06/12] network: add a helper function to list ports that doesn't raise

2013-07-10 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - new patch --- ryu/controller/network.py |6 ++ 1 file changed, 6 insertions(+) diff --git a/ryu/controller/network.py b/ryu/controller/network.py index 01fa727..2908c40 100644 --- a/ryu/controller/network.py +++ b/ryu/controller/netwo

[Ryu-devel] [PATCH v3 08/12] simple_vlan.py: race condition

2013-07-10 Thread Isaku Yamahata
When tunnel key is registers, network is is not always registered. Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - use list_ports_noraise() --- ryu/app/simple_vlan.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/app/simple_vlan.py b/ryu/app/simple_vlan.py inde

[Ryu-devel] [PATCH v3 10/12] app/quantum_adapter: pylint

2013-07-10 Thread Isaku Yamahata
W: 18,0: Unused import logging W: 28,0: Unused import event Signed-off-by: Isaku Yamahata --- ryu/app/quantum_adapter.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/app/quantum_adapter.py b/ryu/app/quantum_adapter.py index c362e4d..5ae0b74 100644 --- a/ryu/app/quantum_adapter.py

[Ryu-devel] [PATCH v3 00/12] openstack: fixes race condition

2013-07-10 Thread Isaku Yamahata
This patch addresses race condition with openstack which causes in exceptions. Changes v2 -> v3: - clean up of controller.network.py for ordering between event and actual deletion - various minor fixes Isaku Yamahata (12): app/gre_tunnel.py: typo has_network -> has_networks network.py: sort

[Ryu-devel] [PATCH v3 07/12] gre_tunnel.py: race condition

2013-07-10 Thread Isaku Yamahata
When tunnel key add/del event fires, the corresponding network_id does not necessarily exists due to race condition. So mask it. (15612) accepted ('127.0.0.1', 45714) 127.0.0.1 - - [25/Jun/2013 12:18:18] "DELETE /v1.0/networks/462be334-3160-48ae-9ef8-a456dc866f8f HTTP/1.1" 200 115 0.000393 (15612)

Re: [Ryu-devel] [PATCH 2/7] oxm_fields: make this a little non-OFPXMC_OPENFLOW_BASIC friendly

2013-07-10 Thread Isaku Yamahata
How about symbolic value for 7, 8, 9 and 0x3f? On Wed, Jul 10, 2013 at 12:52:37PM +0900, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/ofproto/ofproto_v1_3_parser.py | 4 ++-- > ryu/ofproto/oxm_fields.py | 12 ++-- > 2 files changed, 12 insertions(+),