Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 04:07:25PM +0900, YAMAMOTO Takashi wrote: > > On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: > >> On Tue, 4 Mar 2014 12:07:36 +0900 (JST) > >> yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > >> > >> > OFPPropCommonExperimenter4ByteData takes "data" of

Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread YAMAMOTO Takashi
> On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: >> On Tue, 4 Mar 2014 12:07:36 +0900 (JST) >> yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: >> >> > OFPPropCommonExperimenter4ByteData takes "data" of a list of words. >> > others like OFPActionExperimenter and OFPErrorExperime

Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: > On Tue, 4 Mar 2014 12:07:36 +0900 (JST) > yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > > > OFPPropCommonExperimenter4ByteData takes "data" of a list of words. > > others like OFPActionExperimenter and OFPErrorExperimenterMsg

Re: [Ryu-devel] [PATCH] fix load_apps() in AppManager class

2014-03-03 Thread FUJITA Tomonori
On Thu, 27 Feb 2014 17:02:16 +0900 (JST) FUJITA Tomonori wrote: > On Thu, 27 Feb 2014 14:45:39 +0900 > FUJITA Tomonori wrote: > >> fix the following bug: >> >> http://sourceforge.net/p/ryu/mailman/message/32022286/ >> >> Dependent services are not loaded properly with '_CONTEXTS'. >> >> Sign

Re: [Ryu-devel] [PATCH] six.add_metaclass requires six>=1.4.0

2014-03-03 Thread FUJITA Tomonori
On Sat, 1 Mar 2014 22:52:59 +0800 Wei-Li Tang wrote: > python-six package from Ubuntu 12.04 LTS remains version 1.1.0, > which prevents ryu-manager from being started and raises exception > "AttributeError: 'module' object has no attribute 'add_metaclass'". > > Signed-off-by: Wei-Li Tang > ---

Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread FUJITA Tomonori
On Tue, 4 Mar 2014 12:07:36 +0900 (JST) yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > OFPPropCommonExperimenter4ByteData takes "data" of a list of words. > others like OFPActionExperimenter and OFPErrorExperimenterMsg takes > bytes. IMO it would be better to be consistent either way. > i pr

Re: [Ryu-devel] [PATCH v2] of14: Correct documentation of table mod flags and properties

2014-03-03 Thread FUJITA Tomonori
On Tue, 4 Mar 2014 15:12:46 +0900 Simon Horman wrote: > * Document properties > * The valid flags for OpenFlow 1.4 are OFPTC_EVICTION and OFPTC_VACANCY_EVENTS > > Signed-off-by: Simon Horman > > --- > v2 > * Update properties documentation > * OFPTC_EVICTION and OFPTC_VACANCY_EVENTS are the v

[Ryu-devel] [PATCH v2] of14: Correct documentation of table mod flags and properties

2014-03-03 Thread Simon Horman
* Document properties * The valid flags for OpenFlow 1.4 are OFPTC_EVICTION and OFPTC_VACANCY_EVENTS Signed-off-by: Simon Horman --- v2 * Update properties documentation * OFPTC_EVICTION and OFPTC_VACANCY_EVENTS are the valid flags. v1 incorrectly claimed there were no valid flags --- ryu/ofp

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 02:48:59PM +0900, FUJITA Tomonori wrote: > On Tue, 4 Mar 2014 14:08:48 +0900 > Simon Horman wrote: > > > On Tue, Mar 04, 2014 at 01:51:33PM +0900, FUJITA Tomonori wrote: > >> On Mon, 3 Mar 2014 11:38:30 +0900 > >> Simon Horman wrote: > >> > >> > * There are no valid fla

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread FUJITA Tomonori
On Tue, 4 Mar 2014 14:08:48 +0900 Simon Horman wrote: > On Tue, Mar 04, 2014 at 01:51:33PM +0900, FUJITA Tomonori wrote: >> On Mon, 3 Mar 2014 11:38:30 +0900 >> Simon Horman wrote: >> >> > * There are no valid flags >> > >> > Signed-off-by: Simon Horman >> > --- >> > ryu/ofproto/ofproto_v1_

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 01:51:33PM +0900, FUJITA Tomonori wrote: > On Mon, 3 Mar 2014 11:38:30 +0900 > Simon Horman wrote: > > > * There are no valid flags > > > > Signed-off-by: Simon Horman > > --- > > ryu/ofproto/ofproto_v1_4_parser.py | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletio

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread FUJITA Tomonori
On Mon, 3 Mar 2014 11:38:30 +0900 Simon Horman wrote: > * There are no valid flags > > Signed-off-by: Simon Horman > --- > ryu/ofproto/ofproto_v1_4_parser.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ryu/ofproto/ofproto_v1_4_parser.py > b/ryu/ofproto/ofproto

[Ryu-devel] experimenter payload type

2014-03-03 Thread YAMAMOTO Takashi
hi, OFPPropCommonExperimenter4ByteData takes "data" of a list of words. others like OFPActionExperimenter and OFPErrorExperimenterMsg takes bytes. IMO it would be better to be consistent either way. i prefer bytes. YAMAMOTO Takashi ---

[Ryu-devel] [PATCH 3/5] [RFC] of14: Add bundle add message support

2014-03-03 Thread Simon Horman
--- ryu/ofproto/ofproto_v1_4.py| 5 +++- ryu/ofproto/ofproto_v1_4_parser.py | 60 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 5f83e07..0687803 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH 4/5] [RFC] Allow messages inside messages

2014-03-03 Thread Simon Horman
Bundle Add Message, which is part of OpenFlow 1.4, encapsulates an OpenFlow message in side an OpenFlow message. This patch prepares for this by crudely allowing MsgBase subclasses to be used anywhere when parsing classes from JSON: previously they were only allowed at the top-level. This change

[Ryu-devel] [PATCH 1/5] of14: Add bundle control message support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 64 ++ 1 file changed, 64 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 6120633..b4e0382 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 2/5] of14: Add bundle control message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-68-ofp_bundle_ctrl_msg.packet | Bin 0 -> 72 bytes ryu/tests/packet_data_generator/src/x5.erl | 19 ++- .../json/of14/5-68-ofp_bundle_ctrl_msg.packet.json | 36 + ryu/tests/unit/ofproto/test_parser.py

[Ryu-devel] [PATCH 5/5] [RFC] of14: Add bundle add message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-69-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 +++ .../json/of14/5-69-ofp_bundle_add_msg.packet.json | 41 + ryu/tests/unit/ofproto/test_parser.py

[Ryu-devel] [PATCH 0/5] of14: Add bundle support

2014-03-03 Thread Simon Horman
Hi, the aim of this series is to add an implementation of and tests for bundle control message and bundle add message. A complication of implementing unit tests for bundle control add message is that they are OpenFlow messages that encapsulate an OpenFlow message. And thus some infrastructures ch

[Ryu-devel] [PATCH 0/7] of14: Add Flow monitor support

2014-03-03 Thread Simon Horman
Hi, the aim of this series is to add an implementation of and tests for flow monitor requests and replies. To create packet data for unit tests of_protocol updates are required to: * Update to upstream v5 branch which includes an implementation of flow monitor and; * Update to use pull request

[Ryu-devel] [PATCH 2/7] of14: Add flow monitor request support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 7 +++- ryu/ofproto/ofproto_v1_4_parser.py | 82 ++ 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 0d8efb6..5f8

[Ryu-devel] [PATCH 6/7] packet_data_generator: Update ofproto dependency for v5 fix

2014-03-03 Thread Simon Horman
Update ofproto dependency to include a fix for flow monitor reply messages. Signed-off-by: Simon Horman --- The fix pull/68 which has been sent to the of_protocol maintainers. --- ryu/tests/packet_data_generator/rebar.config | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff -

[Ryu-devel] [PATCH 7/7] of14: Add flow monitor reply message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-67-ofp_flow_monitor_reply.packet| Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 30 +- .../of14/5-67-ofp_flow_monitor_reply.packet.json | 66 + 3 files changed, 95 insertions(+), 1 deletio

[Ryu-devel] [PATCH 4/7] packet_data_generator: New ofproto dependency for v5 updates

2014-03-03 Thread Simon Horman
Update ofproto dependency to include a merge of the mainline v5 branch which includes: * Bundle messages * Flow monitor messages Signed-off-by: Simon Horman --- ryu/tests/packet_data_generator/rebar.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/tests/packet_data_

[Ryu-devel] [PATCH 1/7] of14: Add OFPFlowUpdate

2014-03-03 Thread Simon Horman
This will be used by flow monitor reply messages Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 6 +- ryu/ofproto/ofproto_v1_4_parser.py | 116 + 2 files changed, 121 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.p

[Ryu-devel] [PATCH 5/7] of14: Add flow monitor request unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-66-ofp_flow_monitor_request.packet | Bin 0 -> 48 bytes ryu/tests/packet_data_generator/src/x5.erl | 18 +- .../of14/5-66-ofp_flow_monitor_request.packet.json | 27 + 3 files changed, 44 insertions(+), 1 del

[Ryu-devel] [PATCH 3/7] of14: Add flow monitor reply support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 50 ++ 1 file changed, 50 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index e9d49b0..6120633 100644 --- a/ryu/ofproto/ofproto_v1_4_pars